Emanuel Muckenhuber wrote:
Where the important piece is that deployers don't inject services directly rather in the services they deploy.
I think what you are saying here is, say we have a mythical WebServer service that's the entire runtime webserver. A mythical WarDeployer service should not have that injected into it and programatically inject it into a mythical WarDeploymentService it's working on. Rather WarDeploymentService should expose an Injector<WebServer> and WarDeploymentService should do something like this:
BatchServiceBuilder<WarDeploymentService> builder = .... came from somewhere
WarDeploymentService warService = .... came from somewhere
builder.addDependency(WebServer.SERVICE_NAME, WebServer.class, warService.getWebServerInjector());
Agreed on this.
Your 300 ms improvement by doing deployments and non-deployer services in parallel is good evidence that your basic idea is correct. The trick is we need to sort out how to do it. Your patch impl works with the current way things are done, buy David is looking at ditching batches as a result of MSC-21. That needs to be discussed in full before we do it and the implications fully understood. Seems that discussion needs to happen right now.