Jesper Pedersen wrote:
How does the CachedConnectionManager play into the JCA container now? Is it still a hard dependency? If its still there, it would be really great to be able to remove it completely from the configuration.
CCM is still there, since it implements one of the SPIs. If it'll be used is another matter - I think EJB is the only user of the SPI in question. Discussing for another thread.
I like the fact that you will be able to turn on and off the statistics, as we will be able to directly measure the difference, and it probably helps with the benchmarking activities.
The overhead of statistics is minimal. However I considered that there will be use-cases where you don't want to record the results. The key method is clear(), which will allow you to reset all counters.
The one statistic that seems to be missing is the max connection count in use, which is probably also the worst from a performance perspective. Was that intentional? It seems like you could just use the created count for that, if it was greater than the min and less than the max anyway.
https://issues.jboss.org/browse/JBJCA-545
Did you want to start another thread on the CCM here?