Jason Greene wrote:
jaikiran pai wrote:
Nice! :)
Here's some questions I have:
Brian Stansberry wrote:
For zipped archives:
Scanner will detect an archive in the hot-deploy dir, e.g. hot-deploy/foo.war. Scanner will use the same deployment API that an external client would use to register the content with the server and deploy it. Once the content is registered the server will maintain it's own copy in an internal directory (e.g. server/data/deployments). Scanner will replace the hot-deploy/foo.war file with a simple marker file hot-deploy/foo.war.deployed.
Would it be a "rename" or would the foo.war.deployed be a completely different file? From what I understand, I believe it would be a completely different file without any .war semantics, but just wanted to be sure. Furthermore, where would be original foo.war be moved to? Are users expected to know where it's moved to? If not, then they probably will have to maintain a copy of their original deployment somewhere (I know most of them already do that, but again I just wanted to be clear about the expectations).
Brian meant a different file, and they shouldn't necessarily be poking in the data area, which I admit is not intuitive. That's a very good point. It's also inconsistent with the exploded dir, which preserves the original. We could alternatively leave the file there and just add the .deployed as an indicator that it was deployed. The only side effect is that it would require a copy vs a move, but IMO not a huge deal for zips.
If you leave the original archive in place, I think there is little point having a marker file there hanging. Logs/console/cli should tell you if a deployment was successfull or not and for index purposes or otherwise you can always keep state somewhere else, outside the users view.
Unless you want to have archives in ./deploy and not wanting them to deploy? (but then why have them there in first place).
Now, regarding exploded deployments, why not using the containing directory to be the marker itself? "Touching" the upper level directory conceptually is similar to touching a zipped archive. Although it's not so straightforward to do on Windoze.