I've introduced checkstyle into the AS7 codebase. Right now it prints violations out on the console, however in the (near) future it will cause the build to fail if a violation is detected.
This means a few things.
- Make sure your patches do not introduce new violations.
- People with topic branches beware: at some point (soon) the existing violations in trunk will be fixed, which can cause merge conflicts when a rebase is performed unless you rebase using this command: git --whitespace=fix rebase upstream/master
- To avoid productivity loss in the future, make sure your IDE matches the code style, in particular the following points:
- Strip trailing whitespace from modified lines
- Do not use tab characters under any circumstances
- Remove unused and star imports, or imports of classes from the same package
- Do not specify redundant modifiers (like "public" on interface methods)
The existing violation corrections will be going in over the next couple of days; once they're all gone, the build will no longer proceed if a violation is introduced.