Hi Alessio,
Just caught me before I disappear on holiday for 2 weeks :-)
Alessio Soldano wrote:
OK, so th CXF XPathUtils needs to see a XPathFactory implementation. I have two concerns regarding your proposed solution:- I don't think it's correct to force the default impl; afaik we do have custom implementation from Xalan module; btw there should be a javax.xml.jaxp-provider module in AS7 for this. Can you try setting the dependency on that module and see if works too?
- I'm not really sure this dependency should live in the org.jboss.ws.cxf.jbossws-cxf-client module, as this seems quite a common need (any standard client might suffer from this problem, regardless of it using cxf/jbossws-cxf customizations or not). This is probably something for the org.jboss.ws.jaxws-client module, which is automatically loaded by the JAXWS Provider. On this topic, there's something I'd like to verify: you should be going through the org.jboss.wsf.stack.cxf.client.ProviderImpl implementation of JAXWS Provider when doing the call from client; that provider is supposed to set the TCCL in createServiceDelegate(..) so that it use or delegate as fallback to the modular classloader for org.jboss.ws.jaxws-client (that's why adding the dependency in there should be the solution for every client). Btw, this is required because the XPathUtils (as well as many other 3rd party code) relies on TCCL for loading stuff.
I'm agnostic on the second point and tend to agree with you that jaxws-client probably ought to expose it. If you look at the (second) client-side exception trace in my first message you will see that ClientFaultConverter is tyingto load the XPathFactory when processing a reply under the proxy method invoke. I checked in the debugger and the class load was being done using the war classloader.
As for point one, I don't tink my solution forces a specific load. It just allows the default, hard-wired class to be visible in case no META-INF/services override is supplied. Anyway, if you can think of a better way to do this please feel free to implement it. I was just trying to make sure my tests ran so I could see if there were any bugs in the pipeline before I disappeared :-)