From galder.zamarreno at redhat.com Tue Apr 22 13:22:00 2008 Content-Type: multipart/mixed; boundary="===============4959913202890238338==" MIME-Version: 1.0 From: Galder Zamarreno To: jboss-development at lists.jboss.org Subject: [jboss-dev] Patch for JBAS-5471 Date: Tue, 22 Apr 2008 19:21:45 +0200 Message-ID: <480E1EA9.5020807@redhat.com> --===============4959913202890238338== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Scott/Carlo, Re: http://jira.jboss.com/jira/browse/JBAS-5471 I've fixed this applying the changes in the attached patch. Explanation = of the resolution can be found in the comments I made in the JIRA. As I = hardly know this area, could you please review it? Cheers, -- = Galder Zamarre=C3=B1o Sr. Software Maintenance Engineer JBoss, a division of Red Hat Index: /home/galder/jboss/code/as/trunk.ejbthree-1015/ejb3/src/main/org/jbo= ss/ejb3/deployers/Ejb3JBoss5Deployment.java =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- /home/galder/jboss/code/as/trunk.ejbthree-1015/ejb3/src/main/org/jboss/= ejb3/deployers/Ejb3JBoss5Deployment.java (revision 72518) +++ /home/galder/jboss/code/as/trunk.ejbthree-1015/ejb3/src/main/org/jboss/= ejb3/deployers/Ejb3JBoss5Deployment.java (working copy) @@ -28,10 +28,10 @@ import org.jboss.ejb3.DeploymentScope; import org.jboss.ejb3.DeploymentUnit; import org.jboss.ejb3.Ejb3Deployment; -import org.jboss.ejb3.MCKernelAbstraction; import org.jboss.ejb3.javaee.JavaEEComponent; import org.jboss.ejb3.metadata.jpa.spec.PersistenceUnitsMetaData; import org.jboss.kernel.Kernel; +import org.jboss.logging.Logger; import org.jboss.metadata.ejb.jboss.JBossMetaData; = /** @@ -39,6 +39,7 @@ * * @author Bill Burke * @author adrian(a)jboss.org + * @author Galder Zamarren= o * @version $Revision: 56592 $ */ public class Ejb3JBoss5Deployment extends Ejb3Deployment @@ -43,6 +44,8 @@ */ public class Ejb3JBoss5Deployment extends Ejb3Deployment { = + private static final Logger log =3D Logger.getLogger(Ejb3JBoss5Deployme= nt.class); + = private org.jboss.deployers.structure.spi.DeploymentUnit jbossUnit; = public Ejb3JBoss5Deployment(DeploymentUnit ejb3Unit, Kernel kernel, MBe= anServer mbeanServer, org.jboss.deployers.structure.spi.DeploymentUnit jbos= sUnit, DeploymentScope deploymentScope, JBossMetaData metaData, Persistence= UnitsMetaData persistenceUnitsMetaData) @@ -51,7 +54,13 @@ this.jbossUnit =3D jbossUnit; kernelAbstraction =3D new JBossASKernel(kernel); = - // todo maybe mbeanServer should be injected? + // inject mbean server + if (log.isTraceEnabled()) + { + log.trace("Inject mbean server in kernel abstraction."); + } + kernelAbstraction.setMbeanServer(mbeanServer); + = this.mbeanServer =3D mbeanServer; } = Index: /home/galder/jboss/code/as/trunk.ejbthree-1015/ejb3/src/main/org/jbo= ss/ejb3/deployers/JBossASKernel.java =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- /home/galder/jboss/code/as/trunk.ejbthree-1015/ejb3/src/main/org/jboss/= ejb3/deployers/JBossASKernel.java (revision 72518) +++ /home/galder/jboss/code/as/trunk.ejbthree-1015/ejb3/src/main/org/jboss/= ejb3/deployers/JBossASKernel.java (working copy) @@ -34,7 +34,6 @@ import javax.management.MBeanServer; import javax.management.ObjectName; import javax.management.ReflectionException; -import javax.management.RuntimeMBeanException; = import org.jboss.beans.metadata.plugins.AbstractBeanMetaData; import org.jboss.beans.metadata.plugins.AbstractConstructorMetaData; @@ -40,7 +39,6 @@ import org.jboss.beans.metadata.plugins.AbstractConstructorMetaData; import org.jboss.beans.metadata.plugins.AbstractDemandMetaData; import org.jboss.beans.metadata.plugins.AbstractValueMetaData; -import org.jboss.beans.metadata.spi.BeanMetaData; import org.jboss.beans.metadata.spi.BeanMetaDataFactory; import org.jboss.beans.metadata.spi.DemandMetaData; import org.jboss.beans.metadata.spi.SupplyMetaData; @@ -59,6 +57,7 @@ * The JBossAS implementation of the ejb3 KernelAbstraction integration api * @author Bill Burke * @author Scott.Stark(a)jboss.org + * @author Galder Zamarren= o * @version $Revision:$ */ public class JBossASKernel @@ -137,7 +136,6 @@ try { mbeanServer.registerMBean(service, on); - install(on.getCanonicalName(), dependencies, null, service); = // EJBTHREE-606: emulate the ServiceController calls MBeanInfo info =3D mbeanServer.getMBeanInfo(on); // redundant cal= l for speed --===============4959913202890238338==-- From sstark at redhat.com Tue Apr 22 13:31:03 2008 Content-Type: multipart/mixed; boundary="===============8428770175664455729==" MIME-Version: 1.0 From: Scott Stark To: jboss-development at lists.jboss.org Subject: [jboss-dev] Re: Patch for JBAS-5471 Date: Tue, 22 Apr 2008 10:30:58 -0700 Message-ID: <480E20D2.8020709@redhat.com> In-Reply-To: 480E1EA9.5020807@redhat.com --===============8428770175664455729== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable I'll have to pull down the beta4 branch source to see what we were doing = with kernel abstraction in that version. Galder Zamarreno wrote: > Hi Scott/Carlo, > > Re: http://jira.jboss.com/jira/browse/JBAS-5471 > > I've fixed this applying the changes in the attached patch. = > Explanation of the resolution can be found in the comments I made in = > the JIRA. As I hardly know this area, could you please review it? > > Cheers, --===============8428770175664455729==-- From galder.zamarreno at redhat.com Tue Apr 22 13:44:09 2008 Content-Type: multipart/mixed; boundary="===============6657942716371229432==" MIME-Version: 1.0 From: Galder Zamarreno To: jboss-development at lists.jboss.org Subject: Re: [jboss-dev] Patch for JBAS-5471 Date: Tue, 22 Apr 2008 19:44:03 +0200 Message-ID: <480E23E3.4030009@redhat.com> In-Reply-To: 480E1EA9.5020807@redhat.com --===============6657942716371229432== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Actually, a question on this: Where are the EJB3 integration tests = living now? IOW, tests that ensure deployment of EJB3 artifacts, such as = this EJB3 service in AS? Are they disabled by any chance? Galder Zamarreno wrote: > Hi Scott/Carlo, > = > Re: http://jira.jboss.com/jira/browse/JBAS-5471 > = > I've fixed this applying the changes in the attached patch. Explanation = > of the resolution can be found in the comments I made in the JIRA. As I = > hardly know this area, could you please review it? > = > Cheers, > = > = > ------------------------------------------------------------------------ > = > _______________________________________________ > jboss-development mailing list > jboss-development(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/jboss-development -- = Galder Zamarre=C3=B1o Sr. Software Maintenance Engineer JBoss, a division of Red Hat --===============6657942716371229432==-- From sstark at redhat.com Tue Apr 22 14:00:42 2008 Content-Type: multipart/mixed; boundary="===============4410833946681167767==" MIME-Version: 1.0 From: Scott Stark To: jboss-development at lists.jboss.org Subject: Re: [jboss-dev] Patch for JBAS-5471 Date: Tue, 22 Apr 2008 11:00:37 -0700 Message-ID: <480E27C5.7060809@redhat.com> In-Reply-To: 480E23E3.4030009@redhat.com --===============4410833946681167767== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Integration specific tests are in jbossas/testsuite. The ejb3-core tests = still have a lot of integration tests: http://wiki.jboss.org/wiki/DevEJB3RunningUnitTests Galder Zamarreno wrote: > Actually, a question on this: Where are the EJB3 integration tests = > living now? IOW, tests that ensure deployment of EJB3 artifacts, such = > as this EJB3 service in AS? Are they disabled by any chance? > > Galder Zamarreno wrote: >> Hi Scott/Carlo, >> >> Re: http://jira.jboss.com/jira/browse/JBAS-5471 >> >> I've fixed this applying the changes in the attached patch. = >> Explanation of the resolution can be found in the comments I made in = >> the JIRA. As I hardly know this area, could you please review it? >> >> Cheers, >> >> >> ------------------------------------------------------------------------ >> >> _______________________________________________ >> jboss-development mailing list >> jboss-development(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/jboss-development > --===============4410833946681167767==-- From galder.zamarreno at redhat.com Tue Apr 22 14:30:53 2008 Content-Type: multipart/mixed; boundary="===============6111487328121446956==" MIME-Version: 1.0 From: Galder Zamarreno To: jboss-development at lists.jboss.org Subject: Re: [jboss-dev] Patch for JBAS-5471 Date: Tue, 22 Apr 2008 20:30:48 +0200 Message-ID: <480E2ED8.2060608@redhat.com> In-Reply-To: 480E27C5.7060809@redhat.com --===============6111487328121446956== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Scott Stark wrote: > Integration specific tests are in jbossas/testsuite. The ejb3-core tests = > still have a lot of integration tests: > = > http://wiki.jboss.org/wiki/DevEJB3RunningUnitTests In this particular case, assuming that the code I wanna be fixing lives = in AS within the ejb3 integration layer, any test case I create for = this should live in AS, correct? I don't see any org.jboss.test.ejb3 package to test the ejb3 integration = layer in jbossas/testsuite unless these tests are located somewhere else. Or do you expect a test case to fix JBAS-5471, assuming the fix only = involved fixing the ejb3 integration layer in AS, to live in the ejb3 = project? I'm sure there's such test there but probably those tests = haven't run yet as the EJB3 team are currently trying to untangle the = dependency issues. > = > = > Galder Zamarreno wrote: >> Actually, a question on this: Where are the EJB3 integration tests = >> living now? IOW, tests that ensure deployment of EJB3 artifacts, such = >> as this EJB3 service in AS? Are they disabled by any chance? >> >> Galder Zamarreno wrote: >>> Hi Scott/Carlo, >>> >>> Re: http://jira.jboss.com/jira/browse/JBAS-5471 >>> >>> I've fixed this applying the changes in the attached patch. = >>> Explanation of the resolution can be found in the comments I made in = >>> the JIRA. As I hardly know this area, could you please review it? >>> >>> Cheers, >>> >>> >>> ------------------------------------------------------------------------ >>> >>> _______________________________________________ >>> jboss-development mailing list >>> jboss-development(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/jboss-development >> > = -- = Galder Zamarre=C3=B1o Sr. Software Maintenance Engineer JBoss, a division of Red Hat --===============6111487328121446956==-- From sstark at redhat.com Tue Apr 22 14:39:32 2008 Content-Type: multipart/mixed; boundary="===============2949007792142058321==" MIME-Version: 1.0 From: Scott Stark To: jboss-development at lists.jboss.org Subject: Re: [jboss-dev] Patch for JBAS-5471 Date: Tue, 22 Apr 2008 11:39:14 -0700 Message-ID: <480E30D2.2050702@redhat.com> In-Reply-To: 480E2ED8.2060608@redhat.com --===============2949007792142058321== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable There is no specific org.jboss.test.ejb3 package as the tests are = packaged more along the lines of the function. Create an = org.jboss.test.ejb3.service package under the testsuite module and add = your testcase. The code in question is part of the jbossas/ejb3 deployers integration code. Galder Zamarreno wrote: > > > Scott Stark wrote: >> Integration specific tests are in jbossas/testsuite. The ejb3-core = >> tests still have a lot of integration tests: >> >> http://wiki.jboss.org/wiki/DevEJB3RunningUnitTests > > In this particular case, assuming that the code I wanna be fixing = > lives in AS within the ejb3 integration layer, any test case I create = > for this should live in AS, correct? > > I don't see any org.jboss.test.ejb3 package to test the ejb3 = > integration layer in jbossas/testsuite unless these tests are located = > somewhere else. > > Or do you expect a test case to fix JBAS-5471, assuming the fix only = > involved fixing the ejb3 integration layer in AS, to live in the ejb3 = > project? I'm sure there's such test there but probably those tests = > haven't run yet as the EJB3 team are currently trying to untangle the = > dependency issues. --===============2949007792142058321==-- From galder.zamarreno at redhat.com Wed Apr 23 13:39:46 2008 Content-Type: multipart/mixed; boundary="===============9035230823495223235==" MIME-Version: 1.0 From: Galder Zamarreno To: jboss-development at lists.jboss.org Subject: Re: [jboss-dev] Patch for JBAS-5471 Date: Wed, 23 Apr 2008 19:39:43 +0200 Message-ID: <480F745F.1090704@redhat.com> In-Reply-To: 480E30D2.2050702@redhat.com --===============9035230823495223235== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable I've been thinking through this a bit further, so please bear with me :) To be mote precise, my test case is just a simple EJB3 service I'm = trying to deploy. Right now, this is just an example I have and haven't = integrated into any testsuite or anything. (Side note: I'm doing all this cos I was trying to verify whether = http://jira.jboss.com/jira/browse/EJBTHREE-1015 fails in trunk as well.) So, unless EJB3 team are planning to move such tests into AS testsuite = (They have AS deployment tests in EJB3 project), I have the feeling it = might be pointless for me to add another deployment, in-AS, test to = org.jboss.test.ejb3.service in jbossas/testsuite. Am I right? Judging = from the link you passed me, they already have such type of tests there. What probably makes more sense is for org.jboss.test.ejb3.service = package (or if diving by lines of function, which I'm happy with, = org.jboss.test.deployers.ejb3, bearing in mind that I'm trying to test = code in org.jboss.ejb3.deployers.*) within jbossas/testsuite to contain = standalone unit test that mocks other parts and tests the integration = code itself. I can see adding more value with the latter rather than repeating a EJB3 = service deployment test within jbossas/testsuite and I'm more than happy = to do such thing. Does this make any sense? Scott Stark wrote: > There is no specific org.jboss.test.ejb3 package as the tests are = > packaged more along the lines of the function. Create an = > org.jboss.test.ejb3.service package under the testsuite module and add = > your testcase. > = > The code in question is part of the jbossas/ejb3 deployers integration = > code. > = > Galder Zamarreno wrote: >> >> >> Scott Stark wrote: >>> Integration specific tests are in jbossas/testsuite. The ejb3-core = >>> tests still have a lot of integration tests: >>> >>> http://wiki.jboss.org/wiki/DevEJB3RunningUnitTests >> >> In this particular case, assuming that the code I wanna be fixing = >> lives in AS within the ejb3 integration layer, any test case I create = >> for this should live in AS, correct? >> >> I don't see any org.jboss.test.ejb3 package to test the ejb3 = >> integration layer in jbossas/testsuite unless these tests are located = >> somewhere else. >> >> Or do you expect a test case to fix JBAS-5471, assuming the fix only = >> involved fixing the ejb3 integration layer in AS, to live in the ejb3 = >> project? I'm sure there's such test there but probably those tests = >> haven't run yet as the EJB3 team are currently trying to untangle the = >> dependency issues. > = -- = Galder Zamarre=C3=B1o Sr. Software Maintenance Engineer JBoss, a division of Red Hat --===============9035230823495223235==-- From galder.zamarreno at redhat.com Wed Apr 23 13:39:53 2008 Content-Type: multipart/mixed; boundary="===============1013276711178711326==" MIME-Version: 1.0 From: Galder Zamarreno To: jboss-development at lists.jboss.org Subject: Re: [jboss-dev] Patch for JBAS-5471 Date: Wed, 23 Apr 2008 19:39:50 +0200 Message-ID: <480F7466.1040802@redhat.com> In-Reply-To: 480E30D2.2050702@redhat.com --===============1013276711178711326== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable I've been thinking through this a bit further, so please bear with me :) To be mote precise, my test case is just a simple EJB3 service I'm = trying to deploy. Right now, this is just an example I have and haven't = integrated into any testsuite or anything. (Side note: I'm doing all this cos I was trying to verify whether = http://jira.jboss.com/jira/browse/EJBTHREE-1015 fails in trunk as well.) So, unless EJB3 team are planning to move such tests into AS testsuite = (They have AS deployment tests in EJB3 project), I have the feeling it = might be pointless for me to add another deployment, in-AS, test to = org.jboss.test.ejb3.service in jbossas/testsuite. Am I right? Judging = from the link you passed me, they already have such type of tests there. What probably makes more sense is for org.jboss.test.ejb3.service = package (or if diving by lines of function, which I'm happy with, = org.jboss.test.deployers.ejb3, bearing in mind that I'm trying to test = code in org.jboss.ejb3.deployers.*) within jbossas/testsuite to contain = standalone unit test that mocks other parts and tests the integration = code itself. I can see adding more value with the latter rather than repeating a EJB3 = service deployment test within jbossas/testsuite and I'm more than happy = to do such thing. Does this make any sense? Carlo? Scott Stark wrote: > There is no specific org.jboss.test.ejb3 package as the tests are = > packaged more along the lines of the function. Create an = > org.jboss.test.ejb3.service package under the testsuite module and add = > your testcase. > = > The code in question is part of the jbossas/ejb3 deployers integration = > code. > = > Galder Zamarreno wrote: >> >> >> Scott Stark wrote: >>> Integration specific tests are in jbossas/testsuite. The ejb3-core = >>> tests still have a lot of integration tests: >>> >>> http://wiki.jboss.org/wiki/DevEJB3RunningUnitTests >> >> In this particular case, assuming that the code I wanna be fixing = >> lives in AS within the ejb3 integration layer, any test case I create = >> for this should live in AS, correct? >> >> I don't see any org.jboss.test.ejb3 package to test the ejb3 = >> integration layer in jbossas/testsuite unless these tests are located = >> somewhere else. >> >> Or do you expect a test case to fix JBAS-5471, assuming the fix only = >> involved fixing the ejb3 integration layer in AS, to live in the ejb3 = >> project? I'm sure there's such test there but probably those tests = >> haven't run yet as the EJB3 team are currently trying to untangle the = >> dependency issues. > = -- = Galder Zamarre=C3=B1o Sr. Software Maintenance Engineer JBoss, a division of Red Hat --===============1013276711178711326==--