Author: anil.saldhana(a)jboss.com
Date: 2009-06-17 12:57:41 -0400 (Wed, 17 Jun 2009)
New Revision: 616
Modified:
identity-federation/trunk/jboss-identity-bindings/src/main/java/org/jboss/identity/federation/bindings/servlets/SOAPSAMLXACMLServlet.java
Log:
remove the lock on the pdp evaluation as pdp evaluation is thread safe as of JBossXACML
v2.0.3.SP2
Modified:
identity-federation/trunk/jboss-identity-bindings/src/main/java/org/jboss/identity/federation/bindings/servlets/SOAPSAMLXACMLServlet.java
===================================================================
---
identity-federation/trunk/jboss-identity-bindings/src/main/java/org/jboss/identity/federation/bindings/servlets/SOAPSAMLXACMLServlet.java 2009-06-16
20:22:59 UTC (rev 615)
+++
identity-federation/trunk/jboss-identity-bindings/src/main/java/org/jboss/identity/federation/bindings/servlets/SOAPSAMLXACMLServlet.java 2009-06-17
16:57:41 UTC (rev 616)
@@ -25,8 +25,6 @@
import java.io.InputStream;
import java.io.OutputStream;
import java.security.PrivilegedActionException;
-import java.util.concurrent.locks.Lock;
-import java.util.concurrent.locks.ReentrantLock;
import javax.servlet.ServletConfig;
import javax.servlet.ServletException;
@@ -88,8 +86,6 @@
boolean debug = false;
private PolicyDecisionPoint pdp = null;
-
- private Lock lock = new ReentrantLock();
public void init(ServletConfig config) throws ServletException
{
@@ -193,19 +189,9 @@
RequestContext requestContext = new JBossRequestContext();
requestContext.setRequest(requestType);
- ResponseContext responseContext = null;
+ //pdp evaluation is thread safe
+ ResponseContext responseContext = pdp.evaluate(requestContext);
- //Get a lock
- lock.lock();
- try
- {
- responseContext = pdp.evaluate(requestContext);
- }
- finally
- {
- lock.unlock();
- }
-
ResponseType responseType = new ResponseType();
ResultType resultType = responseContext.getResult();
responseType.getResult().add(resultType);
Show replies by date