May 2018 - jboss-jira - Jboss List Archives

[JBoss JIRA] (DROOLS-2514) Concurrent modification when initialising packages in KnowledgeBuilderImpl

by Tibor Zimányi (JIRA)

[ https://issues.jboss.org/browse/DROOLS-2514?page=com.atlassian.jira.plugi... ] Tibor Zimányi commented on DROOLS-2514: --------------------------------------- This is probably related to this http://thisthread.blogspot.cz/2017/12/hashmapcomputeifabsent-behavior-in-... > Concurrent modification when initialising packages in KnowledgeBuilderImpl > -------------------------------------------------------------------------- > > Key: DROOLS-2514 > URL: https://issues.jboss.org/browse/DROOLS-2514 > Project: Drools > Issue Type: Bug > Components: core engine > Affects Versions: 7.2.0.Final, 7.3.0.Final, 7.7.0.Final > Reporter: Max Zerzouri > Assignee: Mario Fusco > Attachments: Main.java, main.drl > > > When parallel compilation is enabled, common structures are modified concurrently by {{KnowledgeBuilderImpl.initPackage}}, resulting in the following stack trace in Java 9/10. > {code:java} > Exception in thread "main" java.util.ConcurrentModificationException: java.util.ConcurrentModificationException > at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) > at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) > at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) > at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:488) > at java.base/java.util.concurrent.ForkJoinTask.getThrowableException(ForkJoinTask.java:600) > at java.base/java.util.concurrent.ForkJoinTask.reportException(ForkJoinTask.java:678) > at java.base/java.util.concurrent.ForkJoinTask.invoke(ForkJoinTask.java:737) > at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateParallel(ForEachOps.java:159) > at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateParallel(ForEachOps.java:173) > at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:233) > at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:497) > at org.drools.compiler.builder.impl.KnowledgeBuilderImpl.compileRulesLevel(KnowledgeBuilderImpl.java:1238) > at org.drools.compiler.builder.impl.KnowledgeBuilderImpl.compileRules(KnowledgeBuilderImpl.java:1218) > at org.drools.compiler.builder.impl.KnowledgeBuilderImpl.compileKnowledgePackages(KnowledgeBuilderImpl.java:1056) > at org.drools.compiler.builder.impl.KnowledgeBuilderImpl.addPackage(KnowledgeBuilderImpl.java:1047) > at org.drools.compiler.builder.impl.KnowledgeBuilderImpl.addPackageFromDrl(KnowledgeBuilderImpl.java:553) > at org.drools.compiler.builder.impl.KnowledgeBuilderImpl.addKnowledgeResource(KnowledgeBuilderImpl.java:773) > at org.drools.compiler.builder.impl.KnowledgeBuilderImpl.add(KnowledgeBuilderImpl.java:2360) > at org.drools.compiler.builder.impl.KnowledgeBuilderImpl.add(KnowledgeBuilderImpl.java:2349) > at Main.attempt(Main.java:48) > at Main.main(Main.java:29) > Caused by: java.util.ConcurrentModificationException > at java.base/java.util.HashMap.computeIfAbsent(HashMap.java:1139) > at org.drools.compiler.builder.impl.KnowledgeBuilderImpl.initPackage(KnowledgeBuilderImpl.java:1146) > at org.drools.compiler.builder.impl.KnowledgeBuilderImpl.createPackageRegistry(KnowledgeBuilderImpl.java:1109) > at org.drools.compiler.builder.impl.KnowledgeBuilderImpl.lambda$getOrCreatePackageRegistry$0(KnowledgeBuilderImpl.java:1105) > at java.base/java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1751) > at org.drools.compiler.builder.impl.KnowledgeBuilderImpl.getOrCreatePackageRegistry(KnowledgeBuilderImpl.java:1105) > at org.drools.compiler.builder.impl.TypeDeclarationCache.createTypeDeclarationForBean(TypeDeclarationCache.java:262) > at org.drools.compiler.builder.impl.TypeDeclarationCache.getAndRegisterTypeDeclaration(TypeDeclarationCache.java:90) > at org.drools.compiler.builder.impl.TypeDeclarationBuilder.getAndRegisterTypeDeclaration(TypeDeclarationBuilder.java:69) > at org.drools.compiler.builder.impl.KnowledgeBuilderImpl.getAndRegisterTypeDeclaration(KnowledgeBuilderImpl.java:1860) > at org.drools.compiler.rule.builder.PatternBuilder.processClassObjectType(PatternBuilder.java:305) > at org.drools.compiler.rule.builder.PatternBuilder.build(PatternBuilder.java:181) > at org.drools.compiler.rule.builder.PatternBuilder.build(PatternBuilder.java:151) > at org.drools.compiler.rule.builder.PatternBuilder.build(PatternBuilder.java:133) > at org.drools.compiler.rule.builder.GroupElementBuilder.build(GroupElementBuilder.java:66) > at org.drools.compiler.rule.builder.RuleBuilder.build(RuleBuilder.java:105) > at org.drools.compiler.builder.impl.KnowledgeBuilderImpl.addRule(KnowledgeBuilderImpl.java:1281) > at org.drools.compiler.builder.impl.KnowledgeBuilderImpl.lambda$compileRulesLevel$3(KnowledgeBuilderImpl.java:1242) > at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183) > at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:177) > at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1492) > at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484) > at java.base/java.util.stream.ForEachOps$ForEachTask.compute(ForEachOps.java:290) > at java.base/java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:746) > at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290) > at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1603) > at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:177) > {code} > Looking at the code, it looks like additional concurrency-unsafe modifications are performed, since it accesses the mentioned {{HashMap}} to get a shared {{LinkedList}} which it then modifies. > Note that the stack trace above is obtained on Java 9/10, as JDK9 added the extra check to {{HashMap.computeIfAbsent}}, but the code relies on race conditions in any JDK version. > Attached a sample Java class source that can trigger the stack trace reliably on my machine (using OpenJDK 10)—should hopefully be reproducible using JDK9/JDK10 as long as the common ForkJoinPool has more than 1 thread. > Also attached a "drl" file with the rules generated by the sample class (not needed when testing, as the contents are generated by the sample class). -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 7 months

1
0
0 / 0

[JBoss JIRA] (WFLY-10205) Upgrade apache-cxf from 3.2.4 to 3.2.5

by Lin Gao (JIRA)

[ https://issues.jboss.org/browse/WFLY-10205?page=com.atlassian.jira.plugin... ] Lin Gao updated WFLY-10205: --------------------------- Labels: downstream_dependency (was: ) > Upgrade apache-cxf from 3.2.4 to 3.2.5 > -------------------------------------- > > Key: WFLY-10205 > URL: https://issues.jboss.org/browse/WFLY-10205 > Project: WildFly > Issue Type: Component Upgrade > Components: Web Services > Reporter: Lin Gao > Assignee: Alessio Soldano > Labels: downstream_dependency > > apache-cxf needs to be upgraded to include fixes for: > * https://issues.apache.org/jira/browse/CXF-7682 -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 7 months

1
0
0 / 0

[JBoss JIRA] (WFCORE-3786) ManagementAuthenticationUsersTestCase fails on latest JDKs

by Ken Wills (JIRA)

[ https://issues.jboss.org/browse/WFCORE-3786?page=com.atlassian.jira.plugi... ] Ken Wills commented on WFCORE-3786: ----------------------------------- [~dlofthouse] AFAIK, [~dmlloyd] patched jboss-modules, and when that upgrade went in, this would be fixed. If there are additional issues in the testsuite etc, I wasn't aware. > ManagementAuthenticationUsersTestCase fails on latest JDKs > ---------------------------------------------------------- > > Key: WFCORE-3786 > URL: https://issues.jboss.org/browse/WFCORE-3786 > Project: WildFly Core > Issue Type: Bug > Components: Security > Reporter: Richard Opalka > Assignee: Darran Lofthouse > Fix For: 5.0.0.Alpha5 > > > I downloaded both jdk1.8.0_b171 & jdk1.8.0_b172. > When running whole WFCORE test suite on them > I'm getting InvalidUserStore exception in > ManagementAuthenticationUsersTestCase -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 7 months

1
0
0 / 0

[JBoss JIRA] (WFWIP-5) Prompt behaves differently with color ouput and without it

by Ingo Weiss (JIRA)

[ https://issues.jboss.org/browse/WFWIP-5?page=com.atlassian.jira.plugin.sy... ] Ingo Weiss resolved WFWIP-5. ---------------------------- Resolution: Done > Prompt behaves differently with color ouput and without it > ---------------------------------------------------------- > > Key: WFWIP-5 > URL: https://issues.jboss.org/browse/WFWIP-5 > Project: WildFly WIP > Issue Type: Bug > Reporter: Erich Duda > Assignee: Ingo Weiss > Labels: WFCORE-3577 > > When I run the CLI with option {{--no-color-output}}, the batch or workflow mode is not highlighted by changing of prompt. > {code} > [disconnected /] batch > [disconnected /] > {code} > If I do the same with colors enabled, the batch mode adds extra # character into the prompt. > {code} > [disconnected /] batch > [disconnected / #] > {code} > The behavior is inconsistent. There is no reason to add # character to prompt only in color enabled mode. The same applies for if/for/try commands. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 7 months

1
0
0 / 0

[JBoss JIRA] (WFWIP-6) Color output cannot be disabled by jboss-cli.xml

by Ingo Weiss (JIRA)

[ https://issues.jboss.org/browse/WFWIP-6?page=com.atlassian.jira.plugin.sy... ] Ingo Weiss resolved WFWIP-6. ---------------------------- Resolution: Done > Color output cannot be disabled by jboss-cli.xml > ------------------------------------------------ > > Key: WFWIP-6 > URL: https://issues.jboss.org/browse/WFWIP-6 > Project: WildFly WIP > Issue Type: Bug > Reporter: Erich Duda > Assignee: Ingo Weiss > Labels: WFCORE-3577 > > When I disabled color output in {{jboss-cli.xml}} using following configuration, the colors were still displayed. > {code:xml} > <color-output> > <enabled>false</enabled> > </color-output> > {code} -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 7 months

1
0
0 / 0

[JBoss JIRA] (WFWIP-7) CLI argument --no-color-output has no precedence before XML configuration

by Ingo Weiss (JIRA)

[ https://issues.jboss.org/browse/WFWIP-7?page=com.atlassian.jira.plugin.sy... ] Ingo Weiss resolved WFWIP-7. ---------------------------- Resolution: Done > CLI argument --no-color-output has no precedence before XML configuration > ------------------------------------------------------------------------- > > Key: WFWIP-7 > URL: https://issues.jboss.org/browse/WFWIP-7 > Project: WildFly WIP > Issue Type: Bug > Reporter: Erich Duda > Assignee: Ingo Weiss > Labels: WFCORE-3577 > > When I uncommented {{color-output}} configuration in jboss-cli.xml where {{enabled}} option is set on {{true}}, the {{--no-color-output}} option had not effect. The colors were displayed. > {code:xml|title=jboss-cli.xml} > <color-output> > <enabled>true</enabled> > <error-color>red</error-color> > <warn-color>yellow</warn-color> > <success-color>default</success-color> > <required-color>magenta</required-color> > <workflow-color>default</workflow-color> > <prompt-color>default</prompt-color> > </color-output> > {code} > {code:title=Bash command} > $ ./jboss-cli.sh --no-color-output > {code} > In this case the {{--no-color-output}} should have precedence and no colors should be displayed. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 7 months

1
0
0 / 0

[JBoss JIRA] (DROOLS-2521) Implement FEEL functions in preparation for DMN 1.2

by Edson Tirelli (JIRA)

[ https://issues.jboss.org/browse/DROOLS-2521?page=com.atlassian.jira.plugi... ] Edson Tirelli updated DROOLS-2521: ---------------------------------- Sprint: 2018 Week 17-18 > Implement FEEL functions in preparation for DMN 1.2 > --------------------------------------------------- > > Key: DROOLS-2521 > URL: https://issues.jboss.org/browse/DROOLS-2521 > Project: Drools > Issue Type: Enhancement > Components: dmn engine > Affects Versions: 7.7.0.Final > Reporter: Edson Tirelli > Assignee: Fedor Gavrilov > Fix For: 7.8.0.Final > > Attachments: DMN12-190_proposal_v4.docx > > > There are a few new FEEL functions defined for DMN 1.2. > See attached document for the list of functions. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 7 months

1
0
0 / 0

[JBoss JIRA] (DROOLS-2521) Implement FEEL functions in preparation for DMN 1.2

by Edson Tirelli (JIRA)

[ https://issues.jboss.org/browse/DROOLS-2521?page=com.atlassian.jira.plugi... ] Edson Tirelli reassigned DROOLS-2521: ------------------------------------- Assignee: Fedor Gavrilov (was: Edson Tirelli) > Implement FEEL functions in preparation for DMN 1.2 > --------------------------------------------------- > > Key: DROOLS-2521 > URL: https://issues.jboss.org/browse/DROOLS-2521 > Project: Drools > Issue Type: Enhancement > Components: dmn engine > Affects Versions: 7.7.0.Final > Reporter: Edson Tirelli > Assignee: Fedor Gavrilov > Fix For: 7.8.0.Final > > Attachments: DMN12-190_proposal_v4.docx > > > There are a few new FEEL functions defined for DMN 1.2. > See attached document for the list of functions. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 7 months

1
0
0 / 0

[JBoss JIRA] (DROOLS-2521) Implement FEEL functions in preparation for DMN 1.2

by Edson Tirelli (JIRA)

[ https://issues.jboss.org/browse/DROOLS-2521?page=com.atlassian.jira.plugi... ] Edson Tirelli updated DROOLS-2521: ---------------------------------- Attachment: DMN12-190_proposal_v4.docx > Implement FEEL functions in preparation for DMN 1.2 > --------------------------------------------------- > > Key: DROOLS-2521 > URL: https://issues.jboss.org/browse/DROOLS-2521 > Project: Drools > Issue Type: Enhancement > Components: dmn engine > Affects Versions: 7.7.0.Final > Reporter: Edson Tirelli > Assignee: Fedor Gavrilov > Fix For: 7.8.0.Final > > Attachments: DMN12-190_proposal_v4.docx > > > There are a few new FEEL functions defined for DMN 1.2. > See attached document for the list of functions. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 7 months

1
0
0 / 0

[JBoss JIRA] (DROOLS-2521) Implement FEEL functions in preparation for DMN 1.2

by Edson Tirelli (JIRA)

Edson Tirelli created DROOLS-2521: ------------------------------------- Summary: Implement FEEL functions in preparation for DMN 1.2 Key: DROOLS-2521 URL: https://issues.jboss.org/browse/DROOLS-2521 Project: Drools Issue Type: Enhancement Components: dmn engine Affects Versions: 7.7.0.Final Reporter: Edson Tirelli Assignee: Edson Tirelli Fix For: 7.8.0.Final There are a few new FEEL functions defined for DMN 1.2. See attached document for the list of functions. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 7 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jboss-jira May 2018