From issues at jboss.org Fri Dec 23 09:47:00 2016
Content-Type: multipart/mixed; boundary="===============6332587306132976899=="
MIME-Version: 1.0
From: Michael Biarnes Kiefer (JIRA) <issues at jboss.org>
To: jboss-jira at lists.jboss.org
Subject: [jboss-jira] [JBoss JIRA] (DROOLS-1052) Remove @author tags from
 sources
Date: Fri, 23 Dec 2016 09:47:00 -0500
Message-ID: <JIRA.12602607.1454592650000.17099.1482504420196@Atlassian.JIRA>
In-Reply-To: JIRA.12602607.1454592650000@Atlassian.JIRA

--===============6332587306132976899==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


    [ https://issues.jboss.org/browse/DROOLS-1052?page=3Dcom.atlassian.jira=
.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D13341794#=
comment-13341794 ] =


Michael Biarnes Kiefer commented on DROOLS-1052:
------------------------------------------------

Should I only look in the java files or in the drl files too?

What should I do in this case:
/**
 * Finds currently available server ports.
 *
 * @author <a href=3D"mailto:dev(a)directory.apache.org">Apache Directory P=
roject</a>
 * @see <a href=3D"http://www.iana.org/assignments/port-numbers">IANA.org</=
a>
 */

There are a bunch of @authors in test java files, like i.e.
public class StandaloneDocBuilder {

    public static void main(String[] args) throws FileNotFoundException,
                                          ParseException {

        String drl =3D "";
        drl +=3D "# important information\n";
        drl +=3D "# about this package\n";
        drl +=3D "# it contains some rules\n";
        drl +=3D "package org.kie.test\n";
        drl +=3D "global java.util.List list\n";
        drl +=3D "# Really important information about this rule \n";
        drl +=3D "# Another line because one was not enough \n";
        drl +=3D "#  \n";
        drl +=3D "# @author: trikkola \n";

Should this be removed too?

> Remove @author tags from sources
> --------------------------------
>
>                 Key: DROOLS-1052
>                 URL: https://issues.jboss.org/browse/DROOLS-1052
>             Project: Drools
>          Issue Type: Task
>            Reporter: Petr =C5=A0irok=C3=BD
>            Assignee: Michael Biarnes Kiefer
>
> Some of our sources contain author Javadoc tags. As per our README ( http=
s://github.com/droolsjbpm/droolsjbpm-build-bootstrap/blob/master/README.md#=
faq) we should not using those as they promote code ownership and discourag=
e team work.
> We need to scan through the sources and remove those tags.
> See https://github.com/droolsjbpm/jbpm/commit/ff5fd1ea464fe791933b9ea436c=
d2c4cffd41b15 for example of removing the tags from one of the jBPM modules.



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)


--===============6332587306132976899==--