]
Geoffrey De Smet resolved JBRULES-2720.
---------------------------------------
Resolution: Done
Fixed by replacing the ant script with maven-war-plugin filtered-webapp resources.
Changed the version.txt into AboutInfo.html.
The preferred way to solve it, with BuildConstants was not possible because the gwt plugin
can't cope with filtered resources (yet?).
Guvnor: In the about dialog the version and revision should be
automatically up to date or removed. Make the version up to date and remove the revision.
--------------------------------------------------------------------------------------------------------------------------------------------------------
Key: JBRULES-2720
URL:
https://jira.jboss.org/browse/JBRULES-2720
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-guvnor
Affects Versions: 5.1.1.FINAL
Reporter: Geoffrey De Smet
Assignee: Geoffrey De Smet
Priority: Optional
Fix For: 5.2.0.M1
There's an old ANT script, revision-number.xml, which is commented out and a
version.txt file to do this,
But it hasn't been used in over a year apparently:
- on trunk, the version.txt says "5.0.0.SNAPSHOT 25673M"
-- The version is wrong 5.0.0.SNAPSHOT should be 5.2.0.SNAPSHOT
-- The revision is wrong: the current revision is at least 10000 revisions higher
- on branch 5.1.X it's the same "5.0.0.SNAPSHOT 25673M"
I am removing the old ANT script and version.txt, replacing it with maven filtered
properties, see
drools/drools-guvnor/src/main/filtered-resources/org/drools/guvnor/client/messages/BuildConstants.properties
Making the version up to date with ${pom.version}. Note: when you build from eclipse you
might see ${pom.version} because eclipse doesn't support maven filtering, but any
maven or hudson or release build will have the correct version filled in.
Not adding the revision (yet?). If anyone wants this (QA maybe?), I can do that in the
BuildConstants.properties too, with the buildnumber-maven-plugin.
http://mojo.codehaus.org/buildnumber-maven-plugin/index.html
but that plugin is beta, might slow down the build (network access) and by default it
wants to have svn on command line (which doesn't work if your svn command line is out
of date with the version used by your IDE), however there's a way to use javasvn
instead apparently.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: