[JBoss JIRA] Created: (JBRULES-1471) Accumulate should not call getResult() more then necessary

[JBoss JIRA] (AS7-4780) Incorrect...

[JBoss JIRA] Created:...

Geoffrey De Smet (JIRA)

Sunday, 17 February 2008 Sun, 17 Feb '08

8:11 p.m.

Accumulate should not call getResult() more then necessary ---------------------------------------------------------- Key: JBRULES-1471 URL: http://jira.jboss.com/jira/browse/JBRULES-1471 Project: JBoss Drools Issue Type: Task Security Level: Public (Everyone can see) Components: Reteoo Reporter: Geoffrey De Smet Assigned To: Edson Tirelli Fix For: 5.0.0-M1 For this rule: rule "roomCapacityTooSmall" // TODO it takes 50-90% of the performance of drools-solver when $period : Period(); $room : Room($capacity : capacity); $totalStudentSize : Number(intValue > $capacity) from accumulate( Exam(period == $period, room == $room, $studentSize : topicStudentSize), sum($studentSize) ); ... end Outside drl, I update 2 out of 700 Exam objects and call fireAllRulesAndCalculateDecisionScore. The drl never changes an Exam. Period and Room never change. That results into this log: Breakpoint reached at org.drools.solver.core.evaluation.EvaluationHandler.fireAllRulesAndCalculateDecisionScore(EvaluationHandler.java:90) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) There are 4 accumulate calls and 4 reverse calls. That might be accurate. There are 8 getResult calls, that should only be 1. Also, the getResult method creates a new Double instance each time: return new Double( data.total ); It might be better to do return Double.valueOf(data.total); to allow the JVM to hot spot optimize it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

Show replies by thread

Geoffrey De Smet (JIRA)

Sunday, 17 February Sun, 17 Feb

8:17 p.m.

New subject: [JBoss JIRA] Commented: (JBRULES-1471) Accumulate should not call getResult() more then necessary

[ http://jira.jboss.com/jira/browse/JBRULES-1471?page=comments#action_12399677 ] Geoffrey De Smet commented on JBRULES-1471: ------------------------------------------- Currently: - accumulate - getResults - accumulate - getResults - other restrictions Mark thinks about putting the result from a from node on the agenda, instead of processing it directly. That might result in worse performance, for those that use an accumulate as an early restriction of which the other restrictions are expensive to evaluate: - accumulate -> schedule getResults - accumulate -> schedule getResults - other restrictions - getResults I've been wondering if it's possible to do a best of both worlds? Schedule it on the agenda, but before the other restrictions are evaluated: - accumulate -> schedule getResults - accumulate -> schedule getResults - getResults - other restrictions Does that look possible to implement?

...

Accumulate should not call getResult() more then necessary ---------------------------------------------------------- Key: JBRULES-1471 URL: http://jira.jboss.com/jira/browse/JBRULES-1471 Project: JBoss Drools Issue Type: Task Security Level: Public(Everyone can see) Components: Reteoo Reporter: Geoffrey De Smet Assigned To: Edson Tirelli Fix For: 5.0.0-M1 For this rule: rule "roomCapacityTooSmall" // TODO it takes 50-90% of the performance of drools-solver when $period : Period(); $room : Room($capacity : capacity); $totalStudentSize : Number(intValue > $capacity) from accumulate( Exam(period == $period, room == $room, $studentSize : topicStudentSize), sum($studentSize) ); ... end Outside drl, I update 2 out of 700 Exam objects and call fireAllRulesAndCalculateDecisionScore. The drl never changes an Exam. Period and Room never change. That results into this log: Breakpoint reached at org.drools.solver.core.evaluation.EvaluationHandler.fireAllRulesAndCalculateDecisionScore(EvaluationHandler.java:90) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) There are 4 accumulate calls and 4 reverse calls. That might be accurate. There are 8 getResult calls, that should only be 1. Also, the getResult method creates a new Double instance each time: return new Double( data.total ); It might be better to do return Double.valueOf(data.total); to allow the JVM to hot spot optimize it.

-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

Mark Proctor (JIRA)

Thursday, 24 July Thu, 24 Jul

2:20 a.m.

New subject: [JBoss JIRA] Updated: (JBRULES-1471) Accumulate should not call getResult() more then necessary

[ https://jira.jboss.org/jira/browse/JBRULES-1471?page=com.atlassian.jira.p... ] Mark Proctor updated JBRULES-1471: ---------------------------------- Fix Version/s: 5.0.0.M2 (was: 5.0.0.M1)

...

Accumulate should not call getResult() more then necessary ---------------------------------------------------------- Key: JBRULES-1471 URL: https://jira.jboss.org/jira/browse/JBRULES-1471 Project: JBoss Drools Issue Type: Task Security Level: Public(Everyone can see) Components: Reteoo Reporter: Geoffrey De Smet Assignee: Edson Tirelli Fix For: 5.0.0.M2 For this rule: rule "roomCapacityTooSmall" // TODO it takes 50-90% of the performance of drools-solver when $period : Period(); $room : Room($capacity : capacity); $totalStudentSize : Number(intValue > $capacity) from accumulate( Exam(period == $period, room == $room, $studentSize : topicStudentSize), sum($studentSize) ); ... end Outside drl, I update 2 out of 700 Exam objects and call fireAllRulesAndCalculateDecisionScore. The drl never changes an Exam. Period and Room never change. That results into this log: Breakpoint reached at org.drools.solver.core.evaluation.EvaluationHandler.fireAllRulesAndCalculateDecisionScore(EvaluationHandler.java:90) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) There are 4 accumulate calls and 4 reverse calls. That might be accurate. There are 8 getResult calls, that should only be 1. Also, the getResult method creates a new Double instance each time: return new Double( data.total ); It might be better to do return Double.valueOf(data.total); to allow the JVM to hot spot optimize it.

-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

Edson Tirelli (JIRA)

Monday, 6 October Mon, 6 Oct

1:29 a.m.

New subject: [JBoss JIRA] Updated: (JBRULES-1471) Accumulate should not call getResult() more then necessary

[ https://jira.jboss.org/jira/browse/JBRULES-1471?page=com.atlassian.jira.p... ] Edson Tirelli updated JBRULES-1471: ----------------------------------- Fix Version/s: 5.0.0.M3 (was: 5.0.0.M2)

...

Accumulate should not call getResult() more then necessary ---------------------------------------------------------- Key: JBRULES-1471 URL: https://jira.jboss.org/jira/browse/JBRULES-1471 Project: JBoss Drools Issue Type: Task Security Level: Public(Everyone can see) Components: Reteoo Reporter: Geoffrey De Smet Assignee: Edson Tirelli Fix For: 5.0.0.M3 For this rule: rule "roomCapacityTooSmall" // TODO it takes 50-90% of the performance of drools-solver when $period : Period(); $room : Room($capacity : capacity); $totalStudentSize : Number(intValue > $capacity) from accumulate( Exam(period == $period, room == $room, $studentSize : topicStudentSize), sum($studentSize) ); ... end Outside drl, I update 2 out of 700 Exam objects and call fireAllRulesAndCalculateDecisionScore. The drl never changes an Exam. Period and Room never change. That results into this log: Breakpoint reached at org.drools.solver.core.evaluation.EvaluationHandler.fireAllRulesAndCalculateDecisionScore(EvaluationHandler.java:90) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) There are 4 accumulate calls and 4 reverse calls. That might be accurate. There are 8 getResult calls, that should only be 1. Also, the getResult method creates a new Double instance each time: return new Double( data.total ); It might be better to do return Double.valueOf(data.total); to allow the JVM to hot spot optimize it.

Edson Tirelli (JIRA)

Wednesday, 26 November Wed, 26 Nov

4:51 p.m.

New subject: [JBoss JIRA] Updated: (JBRULES-1471) Accumulate should not call getResult() more then necessary

[ https://jira.jboss.org/jira/browse/JBRULES-1471?page=com.atlassian.jira.p... ] Edson Tirelli updated JBRULES-1471: ----------------------------------- Fix Version/s: 5.0.0.CR1 (was: 5.0.0.M3)

...

Accumulate should not call getResult() more then necessary ---------------------------------------------------------- Key: JBRULES-1471 URL: https://jira.jboss.org/jira/browse/JBRULES-1471 Project: JBoss Drools Issue Type: Task Security Level: Public(Everyone can see) Components: drools-core (expert) Reporter: Geoffrey De Smet Assignee: Edson Tirelli Fix For: 5.0.0.CR1 For this rule: rule "roomCapacityTooSmall" // TODO it takes 50-90% of the performance of drools-solver when $period : Period(); $room : Room($capacity : capacity); $totalStudentSize : Number(intValue > $capacity) from accumulate( Exam(period == $period, room == $room, $studentSize : topicStudentSize), sum($studentSize) ); ... end Outside drl, I update 2 out of 700 Exam objects and call fireAllRulesAndCalculateDecisionScore. The drl never changes an Exam. Period and Room never change. That results into this log: Breakpoint reached at org.drools.solver.core.evaluation.EvaluationHandler.fireAllRulesAndCalculateDecisionScore(EvaluationHandler.java:90) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) There are 4 accumulate calls and 4 reverse calls. That might be accurate. There are 8 getResult calls, that should only be 1. Also, the getResult method creates a new Double instance each time: return new Double( data.total ); It might be better to do return Double.valueOf(data.total); to allow the JVM to hot spot optimize it.

Mark Proctor (JIRA)

Friday, 23 January Fri, 23 Jan

4:32 a.m.

New subject: [JBoss JIRA] Updated: (JBRULES-1471) Accumulate should not call getResult() more then necessary

[ https://jira.jboss.org/jira/browse/JBRULES-1471?page=com.atlassian.jira.p... ] Mark Proctor updated JBRULES-1471: ---------------------------------- Fix Version/s: 5.0.0.CR1 (was: 5.0.0.M5)

...

Accumulate should not call getResult() more then necessary ---------------------------------------------------------- Key: JBRULES-1471 URL: https://jira.jboss.org/jira/browse/JBRULES-1471 Project: JBoss Drools Issue Type: Task Security Level: Public(Everyone can see) Components: drools-core (expert) Reporter: Geoffrey De Smet Assignee: Edson Tirelli Fix For: 5.0.0.CR1 For this rule: rule "roomCapacityTooSmall" // TODO it takes 50-90% of the performance of drools-solver when $period : Period(); $room : Room($capacity : capacity); $totalStudentSize : Number(intValue > $capacity) from accumulate( Exam(period == $period, room == $room, $studentSize : topicStudentSize), sum($studentSize) ); ... end Outside drl, I update 2 out of 700 Exam objects and call fireAllRulesAndCalculateDecisionScore. The drl never changes an Exam. Period and Room never change. That results into this log: Breakpoint reached at org.drools.solver.core.evaluation.EvaluationHandler.fireAllRulesAndCalculateDecisionScore(EvaluationHandler.java:90) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) There are 4 accumulate calls and 4 reverse calls. That might be accurate. There are 8 getResult calls, that should only be 1. Also, the getResult method creates a new Double instance each time: return new Double( data.total ); It might be better to do return Double.valueOf(data.total); to allow the JVM to hot spot optimize it.

Mark Proctor (JIRA)

Thursday, 19 March Thu, 19 Mar

3:28 a.m.

New subject: [JBoss JIRA] Updated: (JBRULES-1471) Accumulate should not call getResult() more then necessary

[ https://jira.jboss.org/jira/browse/JBRULES-1471?page=com.atlassian.jira.p... ] Mark Proctor updated JBRULES-1471: ---------------------------------- Fix Version/s: 5.0.0.GA (was: 5.0.0.CR1)

...

Accumulate should not call getResult() more then necessary ---------------------------------------------------------- Key: JBRULES-1471 URL: https://jira.jboss.org/jira/browse/JBRULES-1471 Project: JBoss Drools Issue Type: Task Security Level: Public(Everyone can see) Components: drools-core (expert) Reporter: Geoffrey De Smet Assignee: Edson Tirelli Fix For: 5.0.0.GA For this rule: rule "roomCapacityTooSmall" // TODO it takes 50-90% of the performance of drools-solver when $period : Period(); $room : Room($capacity : capacity); $totalStudentSize : Number(intValue > $capacity) from accumulate( Exam(period == $period, room == $room, $studentSize : topicStudentSize), sum($studentSize) ); ... end Outside drl, I update 2 out of 700 Exam objects and call fireAllRulesAndCalculateDecisionScore. The drl never changes an Exam. Period and Room never change. That results into this log: Breakpoint reached at org.drools.solver.core.evaluation.EvaluationHandler.fireAllRulesAndCalculateDecisionScore(EvaluationHandler.java:90) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) There are 4 accumulate calls and 4 reverse calls. That might be accurate. There are 8 getResult calls, that should only be 1. Also, the getResult method creates a new Double instance each time: return new Double( data.total ); It might be better to do return Double.valueOf(data.total); to allow the JVM to hot spot optimize it.

Edson Tirelli (JIRA)

Wednesday, 20 May Wed, 20 May

4:07 p.m.

New subject: [JBoss JIRA] Updated: (JBRULES-1471) Accumulate should not call getResult() more then necessary

[ https://jira.jboss.org/jira/browse/JBRULES-1471?page=com.atlassian.jira.p... ] Edson Tirelli updated JBRULES-1471: ----------------------------------- Fix Version/s: 5.1.0.M1 (was: 5.0.1.FINAL)

...

Accumulate should not call getResult() more then necessary ---------------------------------------------------------- Key: JBRULES-1471 URL: https://jira.jboss.org/jira/browse/JBRULES-1471 Project: JBoss Drools Issue Type: Task Security Level: Public(Everyone can see) Components: drools-core (expert) Reporter: Geoffrey De Smet Assignee: Edson Tirelli Fix For: 5.1.0.M1 For this rule: rule "roomCapacityTooSmall" // TODO it takes 50-90% of the performance of drools-solver when $period : Period(); $room : Room($capacity : capacity); $totalStudentSize : Number(intValue > $capacity) from accumulate( Exam(period == $period, room == $room, $studentSize : topicStudentSize), sum($studentSize) ); ... end Outside drl, I update 2 out of 700 Exam objects and call fireAllRulesAndCalculateDecisionScore. The drl never changes an Exam. Period and Room never change. That results into this log: Breakpoint reached at org.drools.solver.core.evaluation.EvaluationHandler.fireAllRulesAndCalculateDecisionScore(EvaluationHandler.java:90) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) There are 4 accumulate calls and 4 reverse calls. That might be accurate. There are 8 getResult calls, that should only be 1. Also, the getResult method creates a new Double instance each time: return new Double( data.total ); It might be better to do return Double.valueOf(data.total); to allow the JVM to hot spot optimize it.

Edson Tirelli (JIRA)

Sunday, 11 October Sun, 11 Oct

9:27 p.m.

New subject: [JBoss JIRA] Updated: (JBRULES-1471) Accumulate should not call getResult() more then necessary

[ https://jira.jboss.org/jira/browse/JBRULES-1471?page=com.atlassian.jira.p... ] Edson Tirelli updated JBRULES-1471: ----------------------------------- Fix Version/s: 5.1.0.M2 (was: 5.1.0.M1)

...

Accumulate should not call getResult() more then necessary ---------------------------------------------------------- Key: JBRULES-1471 URL: https://jira.jboss.org/jira/browse/JBRULES-1471 Project: Drools Issue Type: Task Security Level: Public(Everyone can see) Components: drools-core (expert) Reporter: Geoffrey De Smet Assignee: Edson Tirelli Fix For: 5.1.0.M2 For this rule: rule "roomCapacityTooSmall" // TODO it takes 50-90% of the performance of drools-solver when $period : Period(); $room : Room($capacity : capacity); $totalStudentSize : Number(intValue > $capacity) from accumulate( Exam(period == $period, room == $room, $studentSize : topicStudentSize), sum($studentSize) ); ... end Outside drl, I update 2 out of 700 Exam objects and call fireAllRulesAndCalculateDecisionScore. The drl never changes an Exam. Period and Room never change. That results into this log: Breakpoint reached at org.drools.solver.core.evaluation.EvaluationHandler.fireAllRulesAndCalculateDecisionScore(EvaluationHandler.java:90) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) There are 4 accumulate calls and 4 reverse calls. That might be accurate. There are 8 getResult calls, that should only be 1. Also, the getResult method creates a new Double instance each time: return new Double( data.total ); It might be better to do return Double.valueOf(data.total); to allow the JVM to hot spot optimize it.

Edson Tirelli (JIRA)

Friday, 28 May Fri, 28 May

9:32 p.m.

New subject: [JBoss JIRA] Updated: (JBRULES-1471) Accumulate should not call getResult() more then necessary

[ https://jira.jboss.org/browse/JBRULES-1471?page=com.atlassian.jira.plugin... ] Edson Tirelli updated JBRULES-1471: ----------------------------------- Fix Version/s: 5.1.0.CR1 (was: 5.1.0.M2)

...

Accumulate should not call getResult() more then necessary ---------------------------------------------------------- Key: JBRULES-1471 URL: https://jira.jboss.org/browse/JBRULES-1471 Project: Drools Issue Type: Task Security Level: Public(Everyone can see) Components: drools-core (expert) Reporter: Geoffrey De Smet Assignee: Edson Tirelli Fix For: 5.1.0.CR1 For this rule: rule "roomCapacityTooSmall" // TODO it takes 50-90% of the performance of drools-solver when $period : Period(); $room : Room($capacity : capacity); $totalStudentSize : Number(intValue > $capacity) from accumulate( Exam(period == $period, room == $room, $studentSize : topicStudentSize), sum($studentSize) ); ... end Outside drl, I update 2 out of 700 Exam objects and call fireAllRulesAndCalculateDecisionScore. The drl never changes an Exam. Period and Room never change. That results into this log: Breakpoint reached at org.drools.solver.core.evaluation.EvaluationHandler.fireAllRulesAndCalculateDecisionScore(EvaluationHandler.java:90) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) There are 4 accumulate calls and 4 reverse calls. That might be accurate. There are 8 getResult calls, that should only be 1. Also, the getResult method creates a new Double instance each time: return new Double( data.total ); It might be better to do return Double.valueOf(data.total); to allow the JVM to hot spot optimize it.

-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

Mark Proctor (JIRA)

Thursday, 22 July Thu, 22 Jul

11:40 p.m.

New subject: [JBoss JIRA] Updated: (JBRULES-1471) Accumulate should not call getResult() more then necessary

[ https://jira.jboss.org/browse/JBRULES-1471?page=com.atlassian.jira.plugin... ] Mark Proctor updated JBRULES-1471: ---------------------------------- Fix Version/s: 5.2.0.M1 (was: 5.1.0.CR1)

...

Accumulate should not call getResult() more then necessary ---------------------------------------------------------- Key: JBRULES-1471 URL: https://jira.jboss.org/browse/JBRULES-1471 Project: Drools Issue Type: Task Security Level: Public(Everyone can see) Components: drools-core (expert) Reporter: Geoffrey De Smet Assignee: Edson Tirelli Fix For: 5.2.0.M1 For this rule: rule "roomCapacityTooSmall" // TODO it takes 50-90% of the performance of drools-solver when $period : Period(); $room : Room($capacity : capacity); $totalStudentSize : Number(intValue > $capacity) from accumulate( Exam(period == $period, room == $room, $studentSize : topicStudentSize), sum($studentSize) ); ... end Outside drl, I update 2 out of 700 Exam objects and call fireAllRulesAndCalculateDecisionScore. The drl never changes an Exam. Period and Room never change. That results into this log: Breakpoint reached at org.drools.solver.core.evaluation.EvaluationHandler.fireAllRulesAndCalculateDecisionScore(EvaluationHandler.java:90) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) There are 4 accumulate calls and 4 reverse calls. That might be accurate. There are 8 getResult calls, that should only be 1. Also, the getResult method creates a new Double instance each time: return new Double( data.total ); It might be better to do return Double.valueOf(data.total); to allow the JVM to hot spot optimize it.

Mark Proctor (JIRA)

Tuesday, 17 May Tue, 17 May

7:36 a.m.

New subject: [JBoss JIRA] Updated: (JBRULES-1471) Accumulate should not call getResult() more then necessary

[ https://issues.jboss.org/browse/JBRULES-1471?page=com.atlassian.jira.plug... ] Mark Proctor updated JBRULES-1471: ---------------------------------- Fix Version/s: 5.3.0.M1 (was: 5.2.0.M1)

...

Accumulate should not call getResult() more then necessary ---------------------------------------------------------- Key: JBRULES-1471 URL: https://issues.jboss.org/browse/JBRULES-1471 Project: Drools Issue Type: Task Security Level: Public(Everyone can see) Components: drools-core (expert) Reporter: Geoffrey De Smet Assignee: Edson Tirelli Fix For: 5.3.0.M1 For this rule: rule "roomCapacityTooSmall" // TODO it takes 50-90% of the performance of drools-solver when $period : Period(); $room : Room($capacity : capacity); $totalStudentSize : Number(intValue > $capacity) from accumulate( Exam(period == $period, room == $room, $studentSize : topicStudentSize), sum($studentSize) ); ... end Outside drl, I update 2 out of 700 Exam objects and call fireAllRulesAndCalculateDecisionScore. The drl never changes an Exam. Period and Room never change. That results into this log: Breakpoint reached at org.drools.solver.core.evaluation.EvaluationHandler.fireAllRulesAndCalculateDecisionScore(EvaluationHandler.java:90) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) There are 4 accumulate calls and 4 reverse calls. That might be accurate. There are 8 getResult calls, that should only be 1. Also, the getResult method creates a new Double instance each time: return new Double( data.total ); It might be better to do return Double.valueOf(data.total); to allow the JVM to hot spot optimize it.

-- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

Geoffrey De Smet (JIRA)

Tuesday, 9 August Tue, 9 Aug

1:42 p.m.

New subject: [JBoss JIRA] Updated: (JBRULES-1471) Accumulate should not call getResult() more then necessary

[ https://issues.jboss.org/browse/JBRULES-1471?page=com.atlassian.jira.plug... ] Geoffrey De Smet updated JBRULES-1471: -------------------------------------- Fix Version/s: 5.3.0.CR1 (was: 5.3.0.Beta1)

...

Accumulate should not call getResult() more then necessary ---------------------------------------------------------- Key: JBRULES-1471 URL: https://issues.jboss.org/browse/JBRULES-1471 Project: Drools Issue Type: Task Security Level: Public(Everyone can see) Components: drools-core (expert) Reporter: Geoffrey De Smet Assignee: Edson Tirelli Fix For: 5.3.0.CR1 For this rule: rule "roomCapacityTooSmall" // TODO it takes 50-90% of the performance of drools-solver when $period : Period(); $room : Room($capacity : capacity); $totalStudentSize : Number(intValue > $capacity) from accumulate( Exam(period == $period, room == $room, $studentSize : topicStudentSize), sum($studentSize) ); ... end Outside drl, I update 2 out of 700 Exam objects and call fireAllRulesAndCalculateDecisionScore. The drl never changes an Exam. Period and Room never change. That results into this log: Breakpoint reached at org.drools.solver.core.evaluation.EvaluationHandler.fireAllRulesAndCalculateDecisionScore(EvaluationHandler.java:90) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) There are 4 accumulate calls and 4 reverse calls. That might be accurate. There are 8 getResult calls, that should only be 1. Also, the getResult method creates a new Double instance each time: return new Double( data.total ); It might be better to do return Double.valueOf(data.total); to allow the JVM to hot spot optimize it.

-- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

Geoffrey De Smet (JIRA)

Sunday, 25 September Sun, 25 Sep

10:04 a.m.

New subject: [JBoss JIRA] Updated: (JBRULES-1471) Accumulate should not call getResult() more then necessary

...

Accumulate should not call getResult() more then necessary ---------------------------------------------------------- Key: JBRULES-1471 URL: https://issues.jboss.org/browse/JBRULES-1471 Project: Drools Issue Type: Task Security Level: Public(Everyone can see) Components: drools-core (expert) Reporter: Geoffrey De Smet Assignee: Edson Tirelli Fix For: 5.3.0.Final For this rule: rule "roomCapacityTooSmall" // TODO it takes 50-90% of the performance of drools-solver when $period : Period(); $room : Room($capacity : capacity); $totalStudentSize : Number(intValue > $capacity) from accumulate( Exam(period == $period, room == $room, $studentSize : topicStudentSize), sum($studentSize) ); ... end Outside drl, I update 2 out of 700 Exam objects and call fireAllRulesAndCalculateDecisionScore. The drl never changes an Exam. Period and Room never change. That results into this log: Breakpoint reached at org.drools.solver.core.evaluation.EvaluationHandler.fireAllRulesAndCalculateDecisionScore(EvaluationHandler.java:90) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) There are 4 accumulate calls and 4 reverse calls. That might be accurate. There are 8 getResult calls, that should only be 1. Also, the getResult method creates a new Double instance each time: return new Double( data.total ); It might be better to do return Double.valueOf(data.total); to allow the JVM to hot spot optimize it.

-- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

Geoffrey De Smet (Updated) (JIRA)

Friday, 21 October Fri, 21 Oct

5:02 p.m.

New subject: [JBoss JIRA] (JBRULES-1471) Accumulate should not call getResult() more then necessary

...

Accumulate should not call getResult() more then necessary ---------------------------------------------------------- Key: JBRULES-1471 URL: https://issues.jboss.org/browse/JBRULES-1471 Project: Drools Issue Type: Task Security Level: Public(Everyone can see) Components: drools-core (expert) Reporter: Geoffrey De Smet Assignee: Edson Tirelli Fix For: 5.4.0.Beta1 For this rule: rule "roomCapacityTooSmall" // TODO it takes 50-90% of the performance of drools-solver when $period : Period(); $room : Room($capacity : capacity); $totalStudentSize : Number(intValue > $capacity) from accumulate( Exam(period == $period, room == $room, $studentSize : topicStudentSize), sum($studentSize) ); ... end Outside drl, I update 2 out of 700 Exam objects and call fireAllRulesAndCalculateDecisionScore. The drl never changes an Exam. Period and Room never change. That results into this log: Breakpoint reached at org.drools.solver.core.evaluation.EvaluationHandler.fireAllRulesAndCalculateDecisionScore(EvaluationHandler.java:90) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) There are 4 accumulate calls and 4 reverse calls. That might be accurate. There are 8 getResult calls, that should only be 1. Also, the getResult method creates a new Double instance each time: return new Double( data.total ); It might be better to do return Double.valueOf(data.total); to allow the JVM to hot spot optimize it.

-- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

Geoffrey De Smet (Updated) (JIRA)

Tuesday, 20 December Tue, 20 Dec

11:15 a.m.

New subject: [JBoss JIRA] (JBRULES-1471) Accumulate should not call getResult() more then necessary

...

Accumulate should not call getResult() more then necessary ---------------------------------------------------------- Key: JBRULES-1471 URL: https://issues.jboss.org/browse/JBRULES-1471 Project: Drools Issue Type: Task Security Level: Public(Everyone can see) Components: drools-core (expert) Reporter: Geoffrey De Smet Assignee: Edson Tirelli Fix For: 5.4.0.Beta2 For this rule: rule "roomCapacityTooSmall" // TODO it takes 50-90% of the performance of drools-solver when $period : Period(); $room : Room($capacity : capacity); $totalStudentSize : Number(intValue > $capacity) from accumulate( Exam(period == $period, room == $room, $studentSize : topicStudentSize), sum($studentSize) ); ... end Outside drl, I update 2 out of 700 Exam objects and call fireAllRulesAndCalculateDecisionScore. The drl never changes an Exam. Period and Room never change. That results into this log: Breakpoint reached at org.drools.solver.core.evaluation.EvaluationHandler.fireAllRulesAndCalculateDecisionScore(EvaluationHandler.java:90) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) There are 4 accumulate calls and 4 reverse calls. That might be accurate. There are 8 getResult calls, that should only be 1. Also, the getResult method creates a new Double instance each time: return new Double( data.total ); It might be better to do return Double.valueOf(data.total); to allow the JVM to hot spot optimize it.

Geoffrey De Smet (JIRA)

Wednesday, 1 February Wed, 1 Feb

11:27 a.m.

New subject: [JBoss JIRA] (JBRULES-1471) Accumulate should not call getResult() more then necessary

...

Accumulate should not call getResult() more then necessary ---------------------------------------------------------- Key: JBRULES-1471 URL: https://issues.jboss.org/browse/JBRULES-1471 Project: Drools Issue Type: Task Security Level: Public(Everyone can see) Components: drools-core (expert) Reporter: Geoffrey De Smet Assignee: Edson Tirelli Fix For: 5.4.0.Beta3 For this rule: rule "roomCapacityTooSmall" // TODO it takes 50-90% of the performance of drools-solver when $period : Period(); $room : Room($capacity : capacity); $totalStudentSize : Number(intValue > $capacity) from accumulate( Exam(period == $period, room == $room, $studentSize : topicStudentSize), sum($studentSize) ); ... end Outside drl, I update 2 out of 700 Exam objects and call fireAllRulesAndCalculateDecisionScore. The drl never changes an Exam. Period and Room never change. That results into this log: Breakpoint reached at org.drools.solver.core.evaluation.EvaluationHandler.fireAllRulesAndCalculateDecisionScore(EvaluationHandler.java:90) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) There are 4 accumulate calls and 4 reverse calls. That might be accurate. There are 8 getResult calls, that should only be 1. Also, the getResult method creates a new Double instance each time: return new Double( data.total ); It might be better to do return Double.valueOf(data.total); to allow the JVM to hot spot optimize it.

Toni Rikkola (JIRA)

Thursday, 12 April Thu, 12 Apr

9:37 a.m.

New subject: [JBoss JIRA] (JBRULES-1471) Accumulate should not call getResult() more then necessary

[ https://issues.jboss.org/browse/JBRULES-1471?page=com.atlassian.jira.plug... ] Toni Rikkola updated JBRULES-1471: ---------------------------------- Fix Version/s: 5.4.0.Final (was: 5.4.0.CR1)

...

Accumulate should not call getResult() more then necessary ---------------------------------------------------------- Key: JBRULES-1471 URL: https://issues.jboss.org/browse/JBRULES-1471 Project: Drools Issue Type: Task Security Level: Public(Everyone can see) Components: drools-core (expert) Reporter: Geoffrey De Smet Assignee: Edson Tirelli Fix For: 5.4.0.Final For this rule: rule "roomCapacityTooSmall" // TODO it takes 50-90% of the performance of drools-solver when $period : Period(); $room : Room($capacity : capacity); $totalStudentSize : Number(intValue > $capacity) from accumulate( Exam(period == $period, room == $room, $studentSize : topicStudentSize), sum($studentSize) ); ... end Outside drl, I update 2 out of 700 Exam objects and call fireAllRulesAndCalculateDecisionScore. The drl never changes an Exam. Period and Room never change. That results into this log: Breakpoint reached at org.drools.solver.core.evaluation.EvaluationHandler.fireAllRulesAndCalculateDecisionScore(EvaluationHandler.java:90) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) There are 4 accumulate calls and 4 reverse calls. That might be accurate. There are 8 getResult calls, that should only be 1. Also, the getResult method creates a new Double instance each time: return new Double( data.total ); It might be better to do return Double.valueOf(data.total); to allow the JVM to hot spot optimize it.

Toni Rikkola (JIRA)

Tuesday, 15 May Tue, 15 May

2:02 p.m.

New subject: [JBoss JIRA] (JBRULES-1471) Accumulate should not call getResult() more then necessary

[ https://issues.jboss.org/browse/JBRULES-1471?page=com.atlassian.jira.plug... ] Toni Rikkola updated JBRULES-1471: ---------------------------------- Fix Version/s: 5.5.0.Beta1 (was: 5.4.0.Final)

...

Accumulate should not call getResult() more then necessary ---------------------------------------------------------- Key: JBRULES-1471 URL: https://issues.jboss.org/browse/JBRULES-1471 Project: Drools Issue Type: Task Security Level: Public(Everyone can see) Components: drools-core (expert) Reporter: Geoffrey De Smet Assignee: Edson Tirelli Fix For: 5.5.0.Beta1 For this rule: rule "roomCapacityTooSmall" // TODO it takes 50-90% of the performance of drools-solver when $period : Period(); $room : Room($capacity : capacity); $totalStudentSize : Number(intValue > $capacity) from accumulate( Exam(period == $period, room == $room, $studentSize : topicStudentSize), sum($studentSize) ); ... end Outside drl, I update 2 out of 700 Exam objects and call fireAllRulesAndCalculateDecisionScore. The drl never changes an Exam. Period and Room never change. That results into this log: Breakpoint reached at org.drools.solver.core.evaluation.EvaluationHandler.fireAllRulesAndCalculateDecisionScore(EvaluationHandler.java:90) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) There are 4 accumulate calls and 4 reverse calls. That might be accurate. There are 8 getResult calls, that should only be 1. Also, the getResult method creates a new Double instance each time: return new Double( data.total ); It might be better to do return Double.valueOf(data.total); to allow the JVM to hot spot optimize it.

Michael Anstis (JIRA)

Wednesday, 26 September Wed, 26 Sep

11:29 a.m.

New subject: [JBoss JIRA] (JBRULES-1471) Accumulate should not call getResult() more then necessary

[ https://issues.jboss.org/browse/JBRULES-1471?page=com.atlassian.jira.plug... ] Michael Anstis updated JBRULES-1471: ------------------------------------ Fix Version/s: 5.5.0.CR1 (was: 5.5.0.Beta1)

...

Accumulate should not call getResult() more then necessary ---------------------------------------------------------- Key: JBRULES-1471 URL: https://issues.jboss.org/browse/JBRULES-1471 Project: Drools Issue Type: Task Security Level: Public(Everyone can see) Components: drools-core (expert) Reporter: Geoffrey De Smet Assignee: Edson Tirelli Fix For: 5.5.0.CR1 For this rule: rule "roomCapacityTooSmall" // TODO it takes 50-90% of the performance of drools-solver when $period : Period(); $room : Room($capacity : capacity); $totalStudentSize : Number(intValue > $capacity) from accumulate( Exam(period == $period, room == $room, $studentSize : topicStudentSize), sum($studentSize) ); ... end Outside drl, I update 2 out of 700 Exam objects and call fireAllRulesAndCalculateDecisionScore. The drl never changes an Exam. Period and Room never change. That results into this log: Breakpoint reached at org.drools.solver.core.evaluation.EvaluationHandler.fireAllRulesAndCalculateDecisionScore(EvaluationHandler.java:90) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) There are 4 accumulate calls and 4 reverse calls. That might be accurate. There are 8 getResult calls, that should only be 1. Also, the getResult method creates a new Double instance each time: return new Double( data.total ); It might be better to do return Double.valueOf(data.total); to allow the JVM to hot spot optimize it.

-- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

Michael Anstis (JIRA)

Tuesday, 23 October Tue, 23 Oct

10:43 p.m.

New subject: [JBoss JIRA] (JBRULES-1471) Accumulate should not call getResult() more then necessary

[ https://issues.jboss.org/browse/JBRULES-1471?page=com.atlassian.jira.plug... ] Michael Anstis updated JBRULES-1471: ------------------------------------ Fix Version/s: 6.0.0.Beta1 (was: 5.5.0.CR1)

...

Accumulate should not call getResult() more then necessary ---------------------------------------------------------- Key: JBRULES-1471 URL: https://issues.jboss.org/browse/JBRULES-1471 Project: Drools Issue Type: Task Security Level: Public(Everyone can see) Components: drools-core (expert) Reporter: Geoffrey De Smet Assignee: Edson Tirelli Fix For: 6.0.0.Beta1 For this rule: rule "roomCapacityTooSmall" // TODO it takes 50-90% of the performance of drools-solver when $period : Period(); $room : Room($capacity : capacity); $totalStudentSize : Number(intValue > $capacity) from accumulate( Exam(period == $period, room == $room, $studentSize : topicStudentSize), sum($studentSize) ); ... end Outside drl, I update 2 out of 700 Exam objects and call fireAllRulesAndCalculateDecisionScore. The drl never changes an Exam. Period and Room never change. That results into this log: Breakpoint reached at org.drools.solver.core.evaluation.EvaluationHandler.fireAllRulesAndCalculateDecisionScore(EvaluationHandler.java:90) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.reverse(SumAccumulateFunction.java:62) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.accumulate(SumAccumulateFunction.java:53) Breakpoint reached at org.drools.base.accumulators.SumAccumulateFunction.getResult(SumAccumulateFunction.java:70) There are 4 accumulate calls and 4 reverse calls. That might be accurate. There are 8 getResult calls, that should only be 1. Also, the getResult method creates a new Double instance each time: return new Double( data.total ); It might be better to do return Double.valueOf(data.total); to allow the JVM to hot spot optimize it.

4196

days inactive

5906

days old

jboss-jira@lists.jboss.org

Manage subscription

20 comments

6 participants

tags (0)

participants (6)

Edson Tirelli (JIRA)
Geoffrey De Smet (JIRA)
Geoffrey De Smet (Updated) (JIRA)
Mark Proctor (JIRA)
Michael Anstis (JIRA)
Toni Rikkola (JIRA)

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

[JBoss JIRA] Created: (JBRULES-1471) Accumulate should not call getResult() more then necessary