[DMN Designer] Do not default to a LiteralExpression when no expression is defined ---------------------------------------------------------------------------------- Key: DROOLS-4724 URL: https://issues.jboss.org/browse/DROOLS-4724 Project: Drools Issue Type: Enhancement Components: DMN Editor Reporter: Matteo Mortari Assignee: Michael Anstis Priority: Major Labels: drools-tools Attachments: Screenshot from 2019-11-29 12-04-18.png, error.log, image-2019-11-04-19-39-01-113.png, image-2019-11-04-19-40-27-201.png, m.dmn, save-context.webm, screenshot-1.png, screenshot-2.png Currently, the DMN Editor will default to a blank LiteralExpression on Save if the user did not provide an expression for an element. However Error message is reported anyway to the user: !image-2019-11-04-19-39-01-113.png|thumbnail! This also as the (imho undesired) side-effect that if the user was to re-open later that file, instead of a empty element, it would be a blank LiteralExpression !image-2019-11-04-19-40-27-201.png|thumbnail! so the current behavior is not consistent across re-open of the editor. Let's revert this default. The DMN Editor on save should +not+ default to a blank LiteralExpression if the user did not provide an expression for the element. Once this change is applied from the f/e side, I am happy to be involved in order to assess which of the messages reported by the Validator or the Compiler are causing issue to the WB (if any). Currently, the DMN Compiler will throw 1 Warning. Currently, the DMN Validator will throw 1 Error (I can align this to be a Warn too). Currently, the DMN Validator schema check is not reporting any XSD violation. h2. Manual acceptance test Try to save default / empty h3. Business Central - Decision node (?) - BKM node (?) - Cleared Function (?) - Context entry (?) [^error.log] [^save-context.webm] - Invocation (?) h3. Kogito - Decision node (?) - BKM node (?) - Cleared Function (?) - Context entry (?) - Invocation (?)