[JBoss JIRA] (JGRP-1542) RELAY2: preserve messages flags when forwarding / routing / delivering messages
3:25 a.m.
Bela Ban created JGRP-1542:
------------------------------
Summary: RELAY2: preserve messages flags when forwarding / routing /
delivering messages
Key: JGRP-1542
URL: https://issues.jboss.org/browse/JGRP-1542
Project: JGroups
Issue Type: Enhancement
Reporter: Bela Ban
Assignee: Bela Ban
Priority: Minor
Fix For: 3.3
When forwarding a message to the local site master, routing a message from the site master
over the bridge to a remote site master and delivering a message received from a remote
site master in the local site, the original message M is marshalled into a byte buffer and
tucked into a new message M'.
However, M' does *not* copy the flags of M. So, for instance, if M was tagged as OOB,
M' won't be OOB, therefore forwarding, routing and delivering locally won't be
done on the OOB thread pool. Only when M' is unpacked, then M will have the original
flags preserved.
SOLUTION:
Copy the flags of the original message into the wrapping message used to forward, route
and deliver the original message.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:18 p.m.
[
https://issues.jboss.org/browse/JGRP-1542?page=com.atlassian.jira.plugin....
]
Bela Ban commented on JGRP-1542:
--------------------------------
This can lead to the following issue:
- When sending a sync RPC from site A to site B, the RPC message would be marked as
DONT_BUNDLE (or OOB) (Infinispan)
- The bridge transport between sites A and B, however, doesn't copy the flags and
therefore sends the message *bundled* !
- This can add up to 60ms to a sync RPC (max_bundle_timeout=30) !
JGRP-1542 fixes this issue
RELAY2: preserve messages flags when forwarding / routing /
delivering messages
-------------------------------------------------------------------------------
Key: JGRP-1542
URL: https://issues.jboss.org/browse/JGRP-1542
Project: JGroups
Issue Type: Enhancement
Reporter: Bela Ban
Assignee: Bela Ban
Priority: Minor
Fix For: 3.3
When forwarding a message to the local site master, routing a message from the site
master over the bridge to a remote site master and delivering a message received from a
remote site master in the local site, the original message M is marshalled into a byte
buffer and tucked into a new message M'.
However, M' does *not* copy the flags of M. So, for instance, if M was tagged as OOB,
M' won't be OOB, therefore forwarding, routing and delivering locally won't be
done on the OOB thread pool. Only when M' is unpacked, then M will have the original
flags preserved.
SOLUTION:
Copy the flags of the original message into the wrapping message used to forward, route
and deliver the original message.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:20 p.m.
[
https://issues.jboss.org/browse/JGRP-1542?page=com.atlassian.jira.plugin....
]
Bela Ban edited comment on JGRP-1542 at 11/22/12 12:19 PM:
-----------------------------------------------------------
This can lead to the following issue:
- When sending a sync RPC from site A to site B, the RPC message would be marked as
DONT_BUNDLE (or OOB) (Infinispan)
- The bridge transport between sites A and B, however, doesn't copy the flags and
therefore sends the message *bundled* !
- This can add up to 60ms to a sync RPC (max_bundle_timeout=30) !
JGRP-1542 fixes this issue.
A workaround is to set enable_bundling / enable_unicast_bundling in the bride
configuration to false. However, this will also slow down async RPCs !
was (Author: belaban):
This can lead to the following issue:
- When sending a sync RPC from site A to site B, the RPC message would be marked as
DONT_BUNDLE (or OOB) (Infinispan)
- The bridge transport between sites A and B, however, doesn't copy the flags and
therefore sends the message *bundled* !
- This can add up to 60ms to a sync RPC (max_bundle_timeout=30) !
JGRP-1542 fixes this issue
RELAY2: preserve messages flags when forwarding / routing /
delivering messages
-------------------------------------------------------------------------------
Key: JGRP-1542
URL: https://issues.jboss.org/browse/JGRP-1542
Project: JGroups
Issue Type: Enhancement
Reporter: Bela Ban
Assignee: Bela Ban
Priority: Minor
Fix For: 3.3
When forwarding a message to the local site master, routing a message from the site
master over the bridge to a remote site master and delivering a message received from a
remote site master in the local site, the original message M is marshalled into a byte
buffer and tucked into a new message M'.
However, M' does *not* copy the flags of M. So, for instance, if M was tagged as OOB,
M' won't be OOB, therefore forwarding, routing and delivering locally won't be
done on the OOB thread pool. Only when M' is unpacked, then M will have the original
flags preserved.
SOLUTION:
Copy the flags of the original message into the wrapping message used to forward, route
and deliver the original message.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:18 a.m.
[
https://issues.jboss.org/browse/JGRP-1542?page=com.atlassian.jira.plugin....
]
Bela Ban updated JGRP-1542:
---------------------------
Fix Version/s: 3.2.3
RELAY2: preserve messages flags when forwarding / routing /
delivering messages
-------------------------------------------------------------------------------
Key: JGRP-1542
URL: https://issues.jboss.org/browse/JGRP-1542
Project: JGroups
Issue Type: Enhancement
Reporter: Bela Ban
Assignee: Bela Ban
Priority: Minor
Fix For: 3.2.3, 3.3
When forwarding a message to the local site master, routing a message from the site
master over the bridge to a remote site master and delivering a message received from a
remote site master in the local site, the original message M is marshalled into a byte
buffer and tucked into a new message M'.
However, M' does *not* copy the flags of M. So, for instance, if M was tagged as OOB,
M' won't be OOB, therefore forwarding, routing and delivering locally won't be
done on the OOB thread pool. Only when M' is unpacked, then M will have the original
flags preserved.
SOLUTION:
Copy the flags of the original message into the wrapping message used to forward, route
and deliver the original message.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:49 a.m.
[
https://issues.jboss.org/browse/JGRP-1542?page=com.atlassian.jira.plugin....
]
Bela Ban commented on JGRP-1542:
--------------------------------
Solution: copy the original message, change the dest to the next dest and add the final
dest and original sender to the message as a header. When received at the final dest, copy
the message again and switch the dest/src to the ones from the header.
This is faster than marshalling, a quick perf test shows an improvement for LON2 -->
SiteMaster(SFO) (via the local SM(LON)) from 49'000 async RPCs/s to 71'000.
RELAY2: preserve messages flags when forwarding / routing /
delivering messages
-------------------------------------------------------------------------------
Key: JGRP-1542
URL: https://issues.jboss.org/browse/JGRP-1542
Project: JGroups
Issue Type: Enhancement
Reporter: Bela Ban
Assignee: Bela Ban
Priority: Minor
Fix For: 3.2.3, 3.3
When forwarding a message to the local site master, routing a message from the site
master over the bridge to a remote site master and delivering a message received from a
remote site master in the local site, the original message M is marshalled into a byte
buffer and tucked into a new message M'.
However, M' does *not* copy the flags of M. So, for instance, if M was tagged as OOB,
M' won't be OOB, therefore forwarding, routing and delivering locally won't be
done on the OOB thread pool. Only when M' is unpacked, then M will have the original
flags preserved.
SOLUTION:
Copy the flags of the original message into the wrapping message used to forward, route
and deliver the original message.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:49 a.m.
[
https://issues.jboss.org/browse/JGRP-1542?page=com.atlassian.jira.plugin....
]
Bela Ban resolved JGRP-1542.
----------------------------
Resolution: Done
RELAY2: preserve messages flags when forwarding / routing /
delivering messages
-------------------------------------------------------------------------------
Key: JGRP-1542
URL: https://issues.jboss.org/browse/JGRP-1542
Project: JGroups
Issue Type: Enhancement
Reporter: Bela Ban
Assignee: Bela Ban
Priority: Minor
Fix For: 3.2.3, 3.3
When forwarding a message to the local site master, routing a message from the site
master over the bridge to a remote site master and delivering a message received from a
remote site master in the local site, the original message M is marshalled into a byte
buffer and tucked into a new message M'.
However, M' does *not* copy the flags of M. So, for instance, if M was tagged as OOB,
M' won't be OOB, therefore forwarding, routing and delivering locally won't be
done on the OOB thread pool. Only when M' is unpacked, then M will have the original
flags preserved.
SOLUTION:
Copy the flags of the original message into the wrapping message used to forward, route
and deliver the original message.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:51 a.m.
[
https://issues.jboss.org/browse/JGRP-1542?page=com.atlassian.jira.plugin....
]
Bela Ban commented on JGRP-1542:
--------------------------------
still need to backport this to 3.2.3
RELAY2: preserve messages flags when forwarding / routing /
delivering messages
-------------------------------------------------------------------------------
Key: JGRP-1542
URL: https://issues.jboss.org/browse/JGRP-1542
Project: JGroups
Issue Type: Enhancement
Reporter: Bela Ban
Assignee: Bela Ban
Priority: Minor
Fix For: 3.2.3, 3.3
When forwarding a message to the local site master, routing a message from the site
master over the bridge to a remote site master and delivering a message received from a
remote site master in the local site, the original message M is marshalled into a byte
buffer and tucked into a new message M'.
However, M' does *not* copy the flags of M. So, for instance, if M was tagged as OOB,
M' won't be OOB, therefore forwarding, routing and delivering locally won't be
done on the OOB thread pool. Only when M' is unpacked, then M will have the original
flags preserved.
SOLUTION:
Copy the flags of the original message into the wrapping message used to forward, route
and deliver the original message.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:51 a.m.
[
https://issues.jboss.org/browse/JGRP-1542?page=com.atlassian.jira.plugin....
]
Bela Ban reopened JGRP-1542:
----------------------------
Backport to 3.2.3 needed
RELAY2: preserve messages flags when forwarding / routing /
delivering messages
-------------------------------------------------------------------------------
Key: JGRP-1542
URL: https://issues.jboss.org/browse/JGRP-1542
Project: JGroups
Issue Type: Enhancement
Reporter: Bela Ban
Assignee: Bela Ban
Priority: Minor
Fix For: 3.2.3, 3.3
When forwarding a message to the local site master, routing a message from the site
master over the bridge to a remote site master and delivering a message received from a
remote site master in the local site, the original message M is marshalled into a byte
buffer and tucked into a new message M'.
However, M' does *not* copy the flags of M. So, for instance, if M was tagged as OOB,
M' won't be OOB, therefore forwarding, routing and delivering locally won't be
done on the OOB thread pool. Only when M' is unpacked, then M will have the original
flags preserved.
SOLUTION:
Copy the flags of the original message into the wrapping message used to forward, route
and deliver the original message.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:58 a.m.
[
https://issues.jboss.org/browse/JGRP-1542?page=com.atlassian.jira.plugin....
]
Bela Ban resolved JGRP-1542.
----------------------------
Resolution: Done
Backported to 3.2
RELAY2: preserve messages flags when forwarding / routing /
delivering messages
-------------------------------------------------------------------------------
Key: JGRP-1542
URL: https://issues.jboss.org/browse/JGRP-1542
Project: JGroups
Issue Type: Enhancement
Reporter: Bela Ban
Assignee: Bela Ban
Priority: Minor
Fix For: 3.2.3, 3.3
When forwarding a message to the local site master, routing a message from the site
master over the bridge to a remote site master and delivering a message received from a
remote site master in the local site, the original message M is marshalled into a byte
buffer and tucked into a new message M'.
However, M' does *not* copy the flags of M. So, for instance, if M was tagged as OOB,
M' won't be OOB, therefore forwarding, routing and delivering locally won't be
done on the OOB thread pool. Only when M' is unpacked, then M will have the original
flags preserved.
SOLUTION:
Copy the flags of the original message into the wrapping message used to forward, route
and deliver the original message.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4166
days inactive
4172
days old
8 comments
1 participants
participants (1)
-
Bela Ban (JIRA)