Marius Bogoevici wrote:
2) EJB container provides a hook for preprocessing interceptors after instantiation. The main reason is that EJB interceptors may be CDI-injected
(note: could we reuse the same mechanism as for EJB instantiation, since it boils down to producing an instance of the class? )
I'm pretty sure we could do this too. We have this bit of code, though I haven't verified if it's currently used or cruft:
public Object createInterceptor(Class<?> interceptorClass) throws InstantiationException, IllegalAccessException
{
Object instance = interceptorClass.newInstance();
InterceptorInjector interceptorInjector = interceptorInjectors.get(interceptorClass);
assert interceptorInjector != null : "interceptorInjector not found for " + interceptorClass;
interceptorInjector.inject(null, instance);
return instance;
}
Plenty of room in there to both abstract away the instantiation or give some post-instantiation callback before the instance is returned.
This looks good, and I see that is currently being used for @Resource injection in the least. The main challenge seems to be that interceptorInjectors is encapsulated and initialized inside org.jboss.ejb3.EJBContainer.
I am wondering if we could provide a mechanism similar to the instantiator for passing a custom interceptor injector at deployment time.