From jbosscache-commits at lists.jboss.org Thu Jan 29 10:37:00 2009
Content-Type: multipart/mixed; boundary="===============3387993897006527724=="
MIME-Version: 1.0
From: jbosscache-commits at lists.jboss.org
To: jbosscache-commits at lists.jboss.org
Subject: [jbosscache-commits] JBoss Cache SVN: r7612 - in
 searchable/trunk/src: test/java/org/jboss/cache/search and 1 other directory.
Date: Thu, 29 Jan 2009 10:37:00 -0500
Message-ID: <E1LSYwu-0004Ib-0Y@committer01.frg.pub.inap.atl.jboss.com>

--===============3387993897006527724==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

Author: navssurtani
Date: 2009-01-29 10:36:59 -0500 (Thu, 29 Jan 2009)
New Revision: 7612

Added:
   searchable/trunk/src/test/java/org/jboss/cache/search/SearchableCacheFac=
toryTest.java
Modified:
   searchable/trunk/src/main/java/org/jboss/cache/search/SearchableCacheFac=
tory.java
Log:
More validation

Modified: searchable/trunk/src/main/java/org/jboss/cache/search/SearchableC=
acheFactory.java
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- searchable/trunk/src/main/java/org/jboss/cache/search/SearchableCacheFa=
ctory.java	2009-01-29 12:44:21 UTC (rev 7611)
+++ searchable/trunk/src/main/java/org/jboss/cache/search/SearchableCacheFa=
ctory.java	2009-01-29 15:36:59 UTC (rev 7612)
@@ -86,7 +86,7 @@
 =

       if (classes.length =3D=3D 0)
       {
-         if (log.isWarnEnabled()) log.warn("You haven't passed in any clas=
ses to index.  Is this an error?");
+         throw new IllegalArgumentException("You haven't passed in any cla=
sses to index.");
       }
 =

       // step 1: create hibernate search searchFactory
@@ -132,7 +132,7 @@
 =

       if (classes.length =3D=3D 0)
       {
-         if (log.isWarnEnabled()) log.warn("You haven't passed in any clas=
ses to index.  Is this an error?");
+         throw new IllegalArgumentException("You haven't passed in any cla=
sses to index.");
       }
 =

       // step 1: create hibernate search searchFactory

Added: searchable/trunk/src/test/java/org/jboss/cache/search/SearchableCach=
eFactoryTest.java
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- searchable/trunk/src/test/java/org/jboss/cache/search/SearchableCacheFa=
ctoryTest.java	                        (rev 0)
+++ searchable/trunk/src/test/java/org/jboss/cache/search/SearchableCacheFa=
ctoryTest.java	2009-01-29 15:36:59 UTC (rev 7612)
@@ -0,0 +1,44 @@
+package org.jboss.cache.search;
+
+import org.testng.annotations.Test;
+import org.jboss.cache.Cache;
+import org.jboss.cache.DefaultCacheFactory;
+import org.jboss.cache.config.Configuration;
+import org.jboss.cache.pojo.PojoCacheFactory;
+import org.jboss.cache.pojo.PojoCache;
+
+/**
+ * @author Navin Surtani (<a href=3D"mailto:nsurtani(a)redhat.com">nsurtan=
i(a)redhat.com</a>)
+ *
+ * Test class for the SearchableCacheFactory.
+ */
+
+(a)Test (groups =3D "functional")
+public class SearchableCacheFactoryTest
+{
+
+   @Test (expectedExceptions =3D IllegalArgumentException.class)
+   public void testCreateSearchableCacheWithZeroArray()
+   {
+      Class[] fakeClasses =3D new Class[0];
+      =

+      Cache coreCache =3D new DefaultCacheFactory().createCache();
+      SearchableCache searchableCache =3D new SearchableCacheFactory().cre=
ateSearchableCache(coreCache, null, fakeClasses);
+      =

+   }
+
+   @Test (expectedExceptions =3D IllegalArgumentException.class)
+   public void testCreateSearchableCacheWithZeroArrayPojo()
+   {
+      Class[] fakeClasses =3D new Class[0];
+      boolean toStart =3D false;
+      PojoCache pojo =3D PojoCacheFactory.createCache(new Configuration(),=
 toStart);
+      pojo.start(); // if toStart above is true, it will starts the cache =
automatically.
+
+      SearchableCache searchableCache =3D new SearchableCacheFactory().cre=
ateSearchableCache(pojo, null, fakeClasses);
+
+   }
+
+
+
+}


--===============3387993897006527724==--