From jbosscache-commits at lists.jboss.org Tue Jan  1 17:27:18 2008
Content-Type: multipart/mixed; boundary="===============2085663237836697435=="
MIME-Version: 1.0
From: jbosscache-commits at lists.jboss.org
To: jbosscache-commits at lists.jboss.org
Subject: [jbosscache-commits] JBoss Cache SVN: r4928 - in core/trunk/src:
 test/java/org/jboss/cache/transaction/isolationlevels and 1 other directory.
Date: Tue, 01 Jan 2008 17:27:17 -0500
Message-ID: <E1J9pZt-00013T-Ri@committer01.frg.pub.inap.atl.jboss.com>

--===============2085663237836697435==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

Author: manik.surtani(a)jboss.com
Date: 2008-01-01 17:27:17 -0500 (Tue, 01 Jan 2008)
New Revision: 4928

Modified:
   core/trunk/src/main/java/org/jboss/cache/interceptors/PessimisticLockInt=
erceptor.java
   core/trunk/src/test/java/org/jboss/cache/transaction/isolationlevels/Non=
eTest.java
Log:
Fixed PLI not creating nonexistent nodes when isolation level is none

Modified: core/trunk/src/main/java/org/jboss/cache/interceptors/Pessimistic=
LockInterceptor.java
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- core/trunk/src/main/java/org/jboss/cache/interceptors/PessimisticLockIn=
terceptor.java	2007-12-30 21:45:04 UTC (rev 4927)
+++ core/trunk/src/main/java/org/jboss/cache/interceptors/PessimisticLockIn=
terceptor.java	2008-01-01 22:27:17 UTC (rev 4928)
@@ -91,7 +91,7 @@
    private Object handlePutMethod(InvocationContext ctx, Fqn fqn)
          throws Throwable
    {
-      if (ctx.getOptionOverrides() !=3D null && ctx.getOptionOverrides().i=
sSuppressLocking())
+      if ((ctx.getOptionOverrides() !=3D null && ctx.getOptionOverrides().=
isSuppressLocking()) || configuration.getIsolationLevel() =3D=3D IsolationL=
evel.NONE)
       {
          log.trace("Suppressing locking");
          log.trace("Creating nodes if necessary");
@@ -310,10 +310,8 @@
                                            boolean acquireLockOnParent, bo=
olean reverseRemoveCheck)
          throws InterruptedException
    {
-      if (fqn =3D=3D null || configuration.getIsolationLevel() =3D=3D Isol=
ationLevel.NONE)
-      {
-         return false;
-      }
+      if (fqn =3D=3D null) return false;
+
       boolean created;
       long timeout =3D zeroLockTimeout ? 0 : ctx.getContextLockAcquisition=
Timeout(lock_acquisition_timeout);
       // make sure we can bail out of this loop

Modified: core/trunk/src/test/java/org/jboss/cache/transaction/isolationlev=
els/NoneTest.java
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- core/trunk/src/test/java/org/jboss/cache/transaction/isolationlevels/No=
neTest.java	2007-12-30 21:45:04 UTC (rev 4927)
+++ core/trunk/src/test/java/org/jboss/cache/transaction/isolationlevels/No=
neTest.java	2008-01-01 22:27:17 UTC (rev 4928)
@@ -1,11 +1,13 @@
 package org.jboss.cache.transaction.isolationlevels;
 =

 import org.jboss.cache.lock.IsolationLevel;
+import org.testng.annotations.Test;
 =

 /**
  * @author <a href=3D"mailto:manik(a)jboss.org">Manik Surtani</a>
  * @since 2.0.0
  */
+(a)Test(groups =3D {"functional", "transaction"})
 public class NoneTest extends IsolationLevelTestBase
 {
    public NoneTest()


--===============2085663237836697435==--