[jbosscache-issues] [JBoss JIRA] Commented: (JBCACHE-1535) Immutables should be optimised for more set implementations
[
https://jira.jboss.org/jira/browse/JBCACHE-1535?page=com.atlassian.jira.p...
]
Manik Surtani commented on JBCACHE-1535:
----------------------------------------
Partial fix. Since detecting an inner JDK class can be expensive
(class.toString().contains...) since most are private, I am changing all usage of
Immutables wrapper invocations to simply use new HashSet() where we *know* that the
parameter passed in is a JDK inner class (E.g., KeySet, EntrySet, EmptySet, SingletonSet,
etc)
Immutables should be optimised for more set implementations
-----------------------------------------------------------
Key: JBCACHE-1535
URL: https://jira.jboss.org/jira/browse/JBCACHE-1535
Project: JBoss Cache
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Affects Versions: 3.2.0.GA
Reporter: Manik Surtani
Assignee: Manik Surtani
Fix For: 3.2.1.GA
Unknown set types go through a lot of scanning - often involving reflection - before a
simple copy constructor is used. These include the commonly used:
ConcurrentHashMap$KeySet
ConcurrentHashMap$EntrySet
FastCopyHashMap$KeySet
FastCopyHashMap$EntrySet
Collections$EmptySet
Collections$SingletonSet
Collections$EmptyList
Collections$SingletonList
Collections$EmptyMap
Collections$SingletonMap
these should be treated accordingly to avoid reflection calls.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira