Possible typo in MVCCTransactionContext and MVCCInvocationContext ----------------------------------------------------------------- Key: JBCACHE-1520 URL: https://jira.jboss.org/jira/browse/JBCACHE-1520 Project: JBoss Cache Issue Type: Bug Security Level: Public (Everyone can see) Components: Locking Affects Versions: 3.1.0.GA Reporter: Krzysztof Sobolewski Assignee: Manik Surtani While investigating JBCACHE-1519 I spotted two lines that look very suspicious: === src/main/java/org/jboss/cache/transaction/MVCCTransactionContext.java ================================================================== --- src/main/java/org/jboss/cache/transaction/MVCCTransactionContext.java (revision 7145) +++ src/main/java/org/jboss/cache/transaction/MVCCTransactionContext.java (revision 7146) @@ -110,6 +110,6 @@ public void putLookedUpNodes(Map<Fqn, NodeSPI> lookedUpNodes) { - lookedUpNodes.putAll(lookedUpNodes); + this.lookedUpNodes.putAll(lookedUpNodes); } } === src/main/java/org/jboss/cache/invocation/MVCCInvocationContext.java ================================================================== --- src/main/java/org/jboss/cache/invocation/MVCCInvocationContext.java (revision 7145) +++ src/main/java/org/jboss/cache/invocation/MVCCInvocationContext.java (revision 7146) @@ -93,7 +93,7 @@ if (this.lookedUpNodes == null) this.lookedUpNodes = new HashMap<Fqn, NodeSPI>(lookedUpNodes); else - lookedUpNodes.putAll(lookedUpNodes); + this.lookedUpNodes.putAll(lookedUpNodes); } } These two lines are effectively a NOP, and that's why I think it's a typo, or at least something like that :) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira