[ https://jira.jboss.org/browse/JBCACHE-1582?page=com.atlassian.jira.plugin... ] Nicolas Filotto updated JBCACHE-1582: ------------------------------------- Attachment: TestExpirationAlgorithm.java -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBCACHE-1582?page=com.atlassian.jira.plugin... ] Nicolas Filotto updated JBCACHE-1582: ------------------------------------- Attachment: TestExpirationAlgorithm.java The previous versions were incorrect, the pause was not long enough -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBCACHE-1582?page=com.atlassian.jira.plugin... ] Galder Zamarreno commented on JBCACHE-1582: ------------------------------------------- At first glance, there appear to be two issues: - On one side, the LRU test fails cos there's a timeout exception reported when trying to evict a locked node. However, such timeout does not lead to the eviction being put back in the recycle queue, so as a result the eviction is lost. DefaultEvictionActionPolicy shows this: public boolean evict(Fqn fqn) { try { if (log.isTraceEnabled()) log.trace("Evicting Fqn " + fqn); cache.evict(fqn); return true; } catch (Exception e) { if (log.isDebugEnabled()) log.debug("Unable to evict " + fqn, e); return false; } } But BaseEvictionAlgorithm.evictCacheNode does nothing with this result: protected boolean evictCacheNode(Fqn fqn) { if (trace) log.trace("Attempting to evict cache node with fqn of " + fqn); try { evictionActionPolicy.evict(fqn); } catch (TimeoutException e) { log.warn("Eviction of " + fqn + " timed out, retrying later"); log.debug(e, e); return false; } catch (Exception e) { log.error("Eviction of " + fqn + " failed", e); return false; } if (trace) { log.trace("Eviction of cache node with fqn of " + fqn + " successful"); } } The failure is swallowed and hence LRUAlgorithm.evict does not recycle it. - On the other side, the expiration algorithm issue is the one indicated in the initial comment. The first issue could be solved by making recycle queue worked as expected. An option for the second issue would be the following: If there's a transaction going, do not add events for CRUD methods until the prepare phase. This would allow eviction to work on an existing node as long as the commit phase happened before the next eviction run, but this is not a guarantee though. More thinking is needed to solve this. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBCACHE-1582?page=com.atlassian.jira.plugin... ] Nicolas Filotto commented on JBCACHE-1582: ------------------------------------------ Great job Galder !! Your patch works pretty well on my usecase. Viva Espana ! Arriba La Roja ! :-) When could I get an official version of JBC with this patch? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBCACHE-1582?page=com.atlassian.jira.plugin... ] Galder Zamarreno resolved JBCACHE-1582. --------------------------------------- Fix Version/s: 3.3.0.GA Resolution: Done -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBCACHE-1582?page=com.atlassian.jira.plug... ] Sourabh Pareek commented on JBCACHE-1582: ----------------------------------------- Hi All, I am a newbie and trying to work out the problems I am facing with cache. I came across a similar problem. Can someone please guide me on how to apply this patch? Thanks in advace. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBCACHE-1582?page=com.atlassian.jira.plug... ] Nicolas Filotto edited comment on JBCACHE-1582 at 4/28/11 9:43 AM: ------------------------------------------------------------------- Obviously JBC 3.2.6.GA has not been released officially but you can still get it from the maven repo https://repository.jboss.org/nexus/content/groups/public/org/jboss/cache/... was (Author: nfilotto): Obviously there is no official version of JBC 3.2.6.GA but you can still get it from the maven repo https://repository.jboss.org/nexus/content/groups/public/org/jboss/cache/... -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira