Rafael,
I tried it n WFK QS and it works great.
although I have some comments to checker - I generated http://download.eng.brq.redhat.com/scratch/mnovotny/qschecker.html
and it seems there are plenty of the following warnings even it is the Product GAV
Dependency { ... } doesn't comes from Maven Central Repository
Could you eliminate these as they are pulled from injected repositories in pom.xml files?
On 5.11.2014 22:12, Rafael Benevides wrote:
Hi all,
This email is to inform that QSTools 1.5.0.CR2 was released. ( It's at https://repository.jboss.org/nexus/content/groups/public and get synched to Maven Central soon)
It includes a new MavenApprovedRepositoriesChecker that will verify if the quickstart uses the approved maven repositories (ids and urls).
The list of approved maven repositories is defined inside QSTools config file: https://github.com/jboss-developer/maven-qstools-plugin/blob/master/config/qstools_config.yaml#L23-L29
To add/remove repositories in quickstarts' pom.xml files a new goal was created. You can run: mvn org.jboss.maven.plugins:qstools:1.5.0.CR2:repositories
Can you guys try both goals (and checker) for this version before I release 1.5.0.Final ?
- mvn org.jboss.maven.plugins:qstools:1.5.0.CR2:check (Verify MavenApprovedRepositoriesChecker)
- mvn org.jboss.maven.plugins:qstools:1.5.0.CR2:repositories ( add/remove repositories )
Thanks
On 10/31/14 11:56, Rafael Benevides wrote:
Hi all,
I was thinking about the implementation of the repository definition in pom.xml and I want to share my thoughts:
- Create a QSTools CHECKER to mark the lack of <repository /> as a guideline violation if MavenCentralChecker is disabled.
- The violation message will instruct to use the new QSTools GOAL that will be created
- Create another QSTools GOAL to setup the repositories.
- There will be a list of approved repositories and its IDs (redhat techpreview, earlyacess, jboss developer temporary, etc)
- QSTools will remove all previous repositories from pom.xml and prompt which repositories should be added.
- This will help Quickstarts and demos to be easily buildable from development and production branches and will also allow this list to be bulk updated to remove any previous development repository definition.
Please,
If you have any feedback on this, feel free to reply.
--
Rafael Benevides | Senior Software Engineer
JBoss Developer
M: +55-61-9269-6576
Better technology. Faster innovation. Powered by community collaboration.
See how it works at www.redhat.com
_______________________________________________ jbossdeveloper mailing list jbossdeveloper@lists.jboss.org https://lists.jboss.org/mailman/listinfo/jbossdeveloper
-- Marek Novotny -- WFK and Seam Product Lead Red Hat Czech s.r.o. Purkynova 99 612 45 Brno