PMD

From jbosstools-commits at lists.jboss.org Tue Sep 11 10:26:32 2007 Content-Type: multipart/mixed; boundary="===============4792675467208781836==" MIME-Version: 1.0 From: jbosstools-commits at lists.jboss.org To: jbosstools-commits at lists.jboss.org Subject: [jbosstools-commits] JBoss Tools SVN: r3558 - in trunk/struts/plugins/org.jboss.tools.struts.debug: reports and 2 other directories. Date: Tue, 11 Sep 2007 10:26:32 -0400 Message-ID: --===============4792675467208781836== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Author: vrubezhny Date: 2007-09-11 10:26:32 -0400 (Tue, 11 Sep 2007) New Revision: 3558 Added: trunk/struts/plugins/org.jboss.tools.struts.debug/reports/ trunk/struts/plugins/org.jboss.tools.struts.debug/reports/pmd-report.csv trunk/struts/plugins/org.jboss.tools.struts.debug/reports/pmd-report.html trunk/struts/plugins/org.jboss.tools.struts.debug/reports/pmd-report.txt trunk/struts/plugins/org.jboss.tools.struts.debug/reports/pmd-report.vb.= html trunk/struts/plugins/org.jboss.tools.struts.debug/reports/pmd-report.xml Modified: trunk/struts/plugins/org.jboss.tools.struts.debug/src/org/jboss/tools/st= ruts/debug/internal/ActionBreakpoint.java trunk/struts/plugins/org.jboss.tools.struts.debug/src/org/jboss/tools/st= ruts/debug/internal/ActionConditionBreakpoint.java trunk/struts/plugins/org.jboss.tools.struts.debug/src/org/jboss/tools/st= ruts/debug/internal/StrutsDebugPlugin.java trunk/struts/plugins/org.jboss.tools.struts.debug/src/org/jboss/tools/st= ruts/debug/internal/step/ActionExceptionCheckElement.java trunk/struts/plugins/org.jboss.tools.struts.debug/src/org/jboss/tools/st= ruts/debug/internal/step/ActionFormCheckElement.java trunk/struts/plugins/org.jboss.tools.struts.debug/src/org/jboss/tools/st= ruts/debug/internal/step/ActionForwardCheckElement.java trunk/struts/plugins/org.jboss.tools.struts.debug/src/org/jboss/tools/st= ruts/debug/internal/step/GlobalExceptionCheckElement.java trunk/struts/plugins/org.jboss.tools.struts.debug/src/org/jboss/tools/st= ruts/debug/internal/step/GlobalForwardCheckElement.java Log: http://jira.jboss.org/jira/browse/JBIDE-891 Clean out struts component Code clean up is performed Added: trunk/struts/plugins/org.jboss.tools.struts.debug/reports/pmd-report= .csv =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- trunk/struts/plugins/org.jboss.tools.struts.debug/reports/pmd-report.cs= v (rev 0) +++ trunk/struts/plugins/org.jboss.tools.struts.debug/reports/pmd-report.cs= v 2007-09-11 14:26:32 UTC (rev 3558) @@ -0,0 +1 @@ +"Problem","Package","File","Priority","Line","Description","Rule set","Rul= e" Added: trunk/struts/plugins/org.jboss.tools.struts.debug/reports/pmd-report= .html =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- trunk/struts/plugins/org.jboss.tools.struts.debug/reports/pmd-report.ht= ml (rev 0) +++ trunk/struts/plugins/org.jboss.tools.struts.debug/reports/pmd-report.ht= ml 2007-09-11 14:26:32 UTC (rev 3558) @@ -0,0 +1,4 @@ +PMD +

PMD report

Problems found

+ +

#	File	Line	Problem

\ No newline at end of file Property changes on: trunk/struts/plugins/org.jboss.tools.struts.debug/repo= rts/pmd-report.html ___________________________________________________________________ Name: svn:mime-type + text/plain Added: trunk/struts/plugins/org.jboss.tools.struts.debug/reports/pmd-report= .txt =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- trunk/struts/plugins/org.jboss.tools.struts.debug/reports/pmd-report.tx= t (rev 0) +++ trunk/struts/plugins/org.jboss.tools.struts.debug/reports/pmd-report.tx= t 2007-09-11 14:26:32 UTC (rev 3558) @@ -0,0 +1 @@ +No problems found! \ No newline at end of file Property changes on: trunk/struts/plugins/org.jboss.tools.struts.debug/repo= rts/pmd-report.txt ___________________________________________________________________ Name: svn:mime-type + text/plain Added: trunk/struts/plugins/org.jboss.tools.struts.debug/reports/pmd-report= .vb.html =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- trunk/struts/plugins/org.jboss.tools.struts.debug/reports/pmd-report.vb= .html (rev 0) +++ trunk/struts/plugins/org.jboss.tools.struts.debug/reports/pmd-report.vb= .html 2007-09-11 14:26:32 UTC (rev 3558) @@ -0,0 +1,8 @@ +PMD
\ No newline at end of file Property changes on: trunk/struts/plugins/org.jboss.tools.struts.debug/repo= rts/pmd-report.vb.html ___________________________________________________________________ Name: svn:mime-type + text/plain Added: trunk/struts/plugins/org.jboss.tools.struts.debug/reports/pmd-report= .xml =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- trunk/struts/plugins/org.jboss.tools.struts.debug/reports/pmd-report.xm= l (rev 0) +++ trunk/struts/plugins/org.jboss.tools.struts.debug/reports/pmd-report.xm= l 2007-09-11 14:26:32 UTC (rev 3558) @@ -0,0 +1,3 @@ + + + \ No newline at end of file Property changes on: trunk/struts/plugins/org.jboss.tools.struts.debug/repo= rts/pmd-report.xml ___________________________________________________________________ Name: svn:mime-type + text/plain Modified: trunk/struts/plugins/org.jboss.tools.struts.debug/src/org/jboss/t= ools/struts/debug/internal/ActionBreakpoint.java =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- trunk/struts/plugins/org.jboss.tools.struts.debug/src/org/jboss/tools/s= truts/debug/internal/ActionBreakpoint.java 2007-09-11 14:26:02 UTC (rev 355= 7) +++ trunk/struts/plugins/org.jboss.tools.struts.debug/src/org/jboss/tools/s= truts/debug/internal/ActionBreakpoint.java 2007-09-11 14:26:32 UTC (rev 355= 8) @@ -17,8 +17,6 @@ import org.eclipse.core.resources.IResource; import org.eclipse.core.runtime.CoreException; import org.eclipse.debug.core.DebugException; -import org.eclipse.debug.core.ILaunch; -import org.eclipse.debug.core.model.ISourceLocator; import org.eclipse.debug.core.model.IStackFrame; import org.eclipse.jdt.debug.core.IJavaStackFrame; import org.eclipse.jdt.internal.debug.core.breakpoints.JavaMethodBreakpoin= t; @@ -28,7 +26,6 @@ import org.jboss.tools.jst.web.debug.WebDebugPlugin; import org.jboss.tools.jst.web.debug.xpl.DebugSupport; import org.jboss.tools.jst.web.launching.sourcelookup.IBreakpointSourceFin= der; -import org.jboss.tools.jst.web.launching.sourcelookup.xpl.WebSourceLocator; = import com.sun.jdi.event.Event; = Modified: trunk/struts/plugins/org.jboss.tools.struts.debug/src/org/jboss/t= ools/struts/debug/internal/ActionConditionBreakpoint.java =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- trunk/struts/plugins/org.jboss.tools.struts.debug/src/org/jboss/tools/s= truts/debug/internal/ActionConditionBreakpoint.java 2007-09-11 14:26:02 UTC= (rev 3557) +++ trunk/struts/plugins/org.jboss.tools.struts.debug/src/org/jboss/tools/s= truts/debug/internal/ActionConditionBreakpoint.java 2007-09-11 14:26:32 UTC= (rev 3558) @@ -28,7 +28,6 @@ import org.eclipse.jdt.debug.eval.ICompiledExpression; import org.eclipse.jdt.debug.eval.IEvaluationListener; import org.eclipse.jdt.debug.eval.IEvaluationResult; -import org.eclipse.jdt.internal.debug.core.JDIDebugPlugin; import org.eclipse.jdt.internal.debug.core.model.JDIDebugTarget; import org.eclipse.jdt.internal.debug.core.model.JDIStackFrame; import org.eclipse.jdt.internal.debug.core.model.JDIThread; @@ -112,7 +111,7 @@ return handleConditionalBreakpointEvent(event, thread, target); = } catch (CoreException e) { - JDIDebugPlugin.log(e); + StrutsDebugPlugin.log(e); } return true; } @@ -239,7 +238,7 @@ } return; } catch (DebugException e) { - JDIDebugPlugin.log(e); + StrutsDebugPlugin.log(e); } suspendForEvent(event, thread); } Modified: trunk/struts/plugins/org.jboss.tools.struts.debug/src/org/jboss/t= ools/struts/debug/internal/StrutsDebugPlugin.java =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- trunk/struts/plugins/org.jboss.tools.struts.debug/src/org/jboss/tools/s= truts/debug/internal/StrutsDebugPlugin.java 2007-09-11 14:26:02 UTC (rev 35= 57) +++ trunk/struts/plugins/org.jboss.tools.struts.debug/src/org/jboss/tools/s= truts/debug/internal/StrutsDebugPlugin.java 2007-09-11 14:26:32 UTC (rev 35= 58) @@ -10,15 +10,13 @@ *************************************************************************= *****/ = package org.jboss.tools.struts.debug.internal; = -import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IStatus; import org.eclipse.core.runtime.Platform; import org.eclipse.core.runtime.Status; -import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Shell; -import org.eclipse.ui.plugin.AbstractUIPlugin; +import org.jboss.tools.common.log.BaseUIPlugin; = -public class StrutsDebugPlugin extends AbstractUIPlugin { +public class StrutsDebugPlugin extends BaseUIPlugin { = public static final String PLUGIN_ID =3D "org.jboss.tools.struts.debug"; = @@ -27,18 +25,19 @@ StrutsDebugModel.init(); } = - public void startup( ) throws CoreException { - super.startup(); - } - public static void printStackTrace(Throwable throwable) { - if (isDebugEnabled() && throwable !=3D null) throwable.printStackT= race(); + if (isDebugEnabled() && throwable !=3D null) { + throwable.printStackTrace(); + } } = public static void println(String str) { if (isDebugEnabled()) { - if (str !=3D null) System.out.println(str); - else System.out.println(); + if (str !=3D null) { + System.out.println(str); + } else { + System.out.println(); + } } } = @@ -59,11 +58,15 @@ } = public static void log(String msg) { - if(isDebugEnabled()) PluginHolder.INSTANCE.getLog().log(new Status(Statu= s.INFO, PLUGIN_ID, Status.OK, msg, null)); = + if(isDebugEnabled()) { + PluginHolder.INSTANCE.getLog().log(new Status(Status.INFO, PLUGIN_ID, S= tatus.OK, msg, null)); = + } } = public static void log(IStatus status) { - if(isDebugEnabled() || !status.isOK()) PluginHolder.INSTANCE.getLog().lo= g(status); + if(isDebugEnabled() || !status.isOK()) { = + PluginHolder.INSTANCE.getLog().log(status); + } } = public static void log(String message, Throwable exception) { Modified: trunk/struts/plugins/org.jboss.tools.struts.debug/src/org/jboss/t= ools/struts/debug/internal/step/ActionExceptionCheckElement.java =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- trunk/struts/plugins/org.jboss.tools.struts.debug/src/org/jboss/tools/s= truts/debug/internal/step/ActionExceptionCheckElement.java 2007-09-11 14:26= :02 UTC (rev 3557) +++ trunk/struts/plugins/org.jboss.tools.struts.debug/src/org/jboss/tools/s= truts/debug/internal/step/ActionExceptionCheckElement.java 2007-09-11 14:26= :32 UTC (rev 3558) @@ -25,11 +25,8 @@ = String exceptionTypeName =3D getAttributeValue(xObject, StrutsConstants.= ATT_TYPE); = - try { - condition =3D new ActionExceptionCondition(actionTypeName, exceptionTyp= eName); - } catch(Exception e) { - StrutsDebugPlugin.log(e); - } + condition =3D new ActionExceptionCondition(actionTypeName, exceptionType= Name); + StrutsDebugPlugin.log("ActionExceptionCheckElement(" + actionTypeName + = ", " + exceptionTypeName + ")"); } = Modified: trunk/struts/plugins/org.jboss.tools.struts.debug/src/org/jboss/t= ools/struts/debug/internal/step/ActionFormCheckElement.java =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- trunk/struts/plugins/org.jboss.tools.struts.debug/src/org/jboss/tools/s= truts/debug/internal/step/ActionFormCheckElement.java 2007-09-11 14:26:02 U= TC (rev 3557) +++ trunk/struts/plugins/org.jboss.tools.struts.debug/src/org/jboss/tools/s= truts/debug/internal/step/ActionFormCheckElement.java 2007-09-11 14:26:32 U= TC (rev 3558) @@ -29,11 +29,7 @@ public ActionFormCheckElement(XModelObject xObject) { super(xObject); String actionMappingPath =3D getAttributeValue(xObject, StrutsConstants.= ATT_PATH); - try { - condition =3D new ActionFormCondition(actionMappingPath); - } catch(Exception e) { - StrutsDebugPlugin.log(e); - } + condition =3D new ActionFormCondition(actionMappingPath); } = public ICondition getCondition() { Modified: trunk/struts/plugins/org.jboss.tools.struts.debug/src/org/jboss/t= ools/struts/debug/internal/step/ActionForwardCheckElement.java =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- trunk/struts/plugins/org.jboss.tools.struts.debug/src/org/jboss/tools/s= truts/debug/internal/step/ActionForwardCheckElement.java 2007-09-11 14:26:0= 2 UTC (rev 3557) +++ trunk/struts/plugins/org.jboss.tools.struts.debug/src/org/jboss/tools/s= truts/debug/internal/step/ActionForwardCheckElement.java 2007-09-11 14:26:3= 2 UTC (rev 3558) @@ -23,11 +23,7 @@ public ActionForwardCheckElement(XModelObject xObject, String actionTypeN= ame) { super(xObject); String forwardName =3D getAttributeValue(xObject, StrutsConstants.ATT_NA= ME); - try { - condition =3D new ActionForwardCondition(actionTypeName, forwardName); - } catch(Exception e) { - StrutsDebugPlugin.log(e); - } + condition =3D new ActionForwardCondition(actionTypeName, forwardName); } = public ICondition getCondition() { Modified: trunk/struts/plugins/org.jboss.tools.struts.debug/src/org/jboss/t= ools/struts/debug/internal/step/GlobalExceptionCheckElement.java =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- trunk/struts/plugins/org.jboss.tools.struts.debug/src/org/jboss/tools/s= truts/debug/internal/step/GlobalExceptionCheckElement.java 2007-09-11 14:26= :02 UTC (rev 3557) +++ trunk/struts/plugins/org.jboss.tools.struts.debug/src/org/jboss/tools/s= truts/debug/internal/step/GlobalExceptionCheckElement.java 2007-09-11 14:26= :32 UTC (rev 3558) @@ -30,12 +30,7 @@ super(xObject); = String exceptionTypeName =3D getAttributeValue(xObject, StrutsConstants.= ATT_TYPE); - - try { - condition =3D new GlobalExceptionCondition(exceptionTypeName); - } catch(Exception e) { - StrutsDebugPlugin.log(e); - } + condition =3D new GlobalExceptionCondition(exceptionTypeName); } = public ICondition getCondition() { Modified: trunk/struts/plugins/org.jboss.tools.struts.debug/src/org/jboss/t= ools/struts/debug/internal/step/GlobalForwardCheckElement.java =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- trunk/struts/plugins/org.jboss.tools.struts.debug/src/org/jboss/tools/s= truts/debug/internal/step/GlobalForwardCheckElement.java 2007-09-11 14:26:0= 2 UTC (rev 3557) +++ trunk/struts/plugins/org.jboss.tools.struts.debug/src/org/jboss/tools/s= truts/debug/internal/step/GlobalForwardCheckElement.java 2007-09-11 14:26:3= 2 UTC (rev 3558) @@ -29,11 +29,7 @@ public GlobalForwardCheckElement(XModelObject xObject) { super(xObject); String forwardName =3D getAttributeValue(xObject, StrutsConstants.ATT_NA= ME); - try { - condition =3D new GlobalForwardCondition(forwardName); - } catch(Exception e) { - StrutsDebugPlugin.log(e); - } + condition =3D new GlobalForwardCondition(forwardName); } = public ICondition getCondition() { --===============4792675467208781836==--