2014-08-29 13:31 GMT+02:00 Victor Rubezhny <vrubezhny@exadel.com>:
On 08/29/2014 12:11 PM, Angelo zerr wrote:
Hi guys,

I would like to know if you have tested AngularJS 0.5.0 and if it works for you (highlight, completion etc).

If it works, Iwould liek to remove code which create DOM for Angular with custom JFlex. See https://github.com/angelozerr/angularjs-eclipse/issues/84

Many thank's for your answer!

Regard's Angelo



Hi Victor,
 
Angelo,

We've tested AngularJS v. 0.5.0.201408281218 and it works well for us.

Cool! OK I have removed "org.eclipse.angularjs.core.angularsource" content type. See https://github.com/angelozerr/angularjs-eclipse/issues/84
It should continue to work, but if you have time to retry it, it should be very cool.

I have planed to create the 0.5.0 release in September if pascal have time to do that. See https://github.com/angelozerr/angularjs-eclipse/issues/89

For JSP Validator, it should be very cool if we can discuss about that to improve WTP Validator to ignore element/attributes errors with an extension point. 
See   https://github.com/angelozerr/angularjs-eclipse/issues/80#issuecomment-53044063
 

Thanks!

Victor


2014-08-27 11:13 GMT+02:00 Angelo zerr <angelo.zerr@gmail.com>:
Hi Max,

Many thank's for your answer.


2014-08-27 10:17 GMT+02:00 Max Rydahl Andersen <manderse@redhat.com>:

On 25 Aug 2014, at 11:22, Angelo zerr wrote:

Hi all,

I have done a big refactoring for AngularJS Eclipse 0.5.0-SNAPSHOT to
support highlight inside HTML and JSP (or other editor) and custom markup
interpolation by removing my custom DOM Document for Angular. Now I use
standard DOM SSE Document (So I have remove the AngularJS too).

You can see those features at
https://github.com/angelozerr/angularjs-eclipse/wiki/New-and-Noteworthy-0.5.0

This looks fantastic Angelo! Thats what I was taking about initially - happy to see it
seem to be possible.

Glad those features please you!

I'm waiting for that Victor tests 0.5.0 and afler that I will remove "org.eclipse.angularjs.core.angularsource" to clean code . See https://github.com/angelozerr/angularjs-eclipse/issues/84
After that I would like to create a new release (when Pascal will have time).

I have implemented JSP Validator for AngularJS Eclipse but my code is very ugly (I had to copied/pasted the original JSP Validator to ignore angular elements/attributes errors-()
To fix that, WTP Validator should provide an extension point to ignore validation. 


Hope WTP will provide this extension point.

After 0.5.0, I have a lot of idea like managing JS completion, hyperlink, hover, validation inside string for templateUrl (and other thing) : 

------------------------------------------------------------------
app.directive('productTitle',function(){
return {
restrict: 'E',
templateUrl: // here Ctrl+Space shows list of HTML files
};
});
------------------------------------------------------------------

Tern must be improved to support that, there is a guy who is developping tern-closure who does some PR to Tern (that's very cool)

Intellij does that, I would like to support it.



Before cleaning my code by removing the custm DOM Document for Angular (for
the moment I have marked the code as deprecated), I would like to know if
some people could test AngularJS Eclipse 0.5.0-SNAPSHOT (check that
highlight, completion, hover, hyperlink works inside angular expression
inside HTML and JSP).

Victor should be looking at verifying this version with our jboss tools usage today so
I hope he will be able to give some feedback this week.

Great. 

If things pan out we'll try integrate this version for our upcoming CR1 freeze tomorrow.

Have a nice day. 


Many thank's for your help.

Hope you will like this new features.

I definitely do ;)

/max
http://about.me/maxandersen




_______________________________________________
jbosstools-dev mailing list
jbosstools-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jbosstools-dev


_______________________________________________
jbosstools-dev mailing list
jbosstools-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jbosstools-dev