Ahhh ok now I understand =). Currently it will not complain if a <plugin> references something from org.eclipse, but that shouldn't be too hard to do... I already do discovery of what plugins and features are part of
org.eclipse.sdk.
Your other comment basically says if I depend on plugin X I should automatically import the entire feature that includes plugin X? I'm not sure how this would work from an implementation standpoint as it's technically possible to include the same plugin in different features (and then how do we choose which is which?). Basically to include a feature you'll need to either put in the "included features" part of your
feature.xml or as a "required feature" in dependencies.
On 9/5/06, Max Rydahl Andersen <max.andersen@jboss.com
> wrote:> I'm still a little confused by your description, but I have a hunch
> you're
> talking about plugins that are already a part of the standard SDK
> download?
> My ant task already filters out those plugins/features....
and it should then complain loudly if it is a <plugin> reference sine it
is wrong.
the other part is just a sugarcoating thing, that if i refer to a plugin,
e.g.
some WTP XML plugin and that plugin is part of a feature then the
feature.xml should
import the feature...right ?
/max
> On 9/5/06, Max Rydahl Andersen <max.andersen@jboss.com> wrote:
>>
>>
>> > Would be cool if one could automatically run through
>> >> plugin.xml/feature.xml and look for "evil" plugin references.
>> >
>> > I have absolutely no idea what you mean by "evil" ... care to expand a
>> > bit more? (I'm guessing you mean
org.eclipse.emf.*? =)
>>
>> I mean any <plugin ...> that:
>>
>> references eclipse core plugins
>> or
>> something that is in a feature
>>
>
--
--
Max Rydahl Andersen
callto://max.rydahl.andersen
Hibernate
max@hibernate.org
http://hibernate.org
JBoss a division of Red Hat
max.andersen@jboss.com
--
Marshall Culpepper
marshall.culpepper@jboss.com
JBoss Eclipse IDE Lead
JBoss, a division of Red Hat