On 10/21/2014 07:09 PM, Alexey Kazakov wrote:

On 10/21/2014 06:20 AM, Mickael Istria wrote:
On 10/21/2014 03:12 AM, Alexey Kazakov wrote:
base, jst, javaee - done.
So, jbosstools-4.2.x is now open for 4.2.1 development, correct?
Yes, it should be good to go.
But changes on this branch should really be associated to jira entries targeting 4.2.1, use and link pull requests, and get a positive review before merging.
Are you saying I have to get the PR approved by Max, Denis or Fred before I can merge it to 4.2.x for JBT 4.2.1?

I think that the Jira needs to be at least considered as important enough to require a change in 4.2.x.
About the PR, the better seems to be that you get it reviewed by someone else who has good understanding of the code, so that there are more chances reviewer catches actual issues.

--
Mickael Istria
Eclipse developer at JBoss, by Red Hat
My blog - My Tweets