On 04/27/2016 11:01 AM, Nick Boldt wrote:

One PR in Base will not automatically cause the results of that PR to
be picked up by downstream projects (eg., Server, Openshift) or
JBT/JBDS aggregation -- to do that would require passing in a
commandline override for
-Djbosstools-base-site=http://path/to/output/of/the/pull-request/build/repo/
... for all the downstream projects of Base, and ensuring that the
output was published to a /pulls/ folder instead of the usual /builds/
folder.

So if I'm going down this road I wanted to make sure we think a little
about how the future might unfold, and how we might get there. Rather
not be painted into a corner. :D

I think it is beyond overkill to even try for b).  wildfly doesn't rebuild and run the test suite for a given change in jasper, for example. The entire idea that not even an actual change, but a potential change / PR, to base, could end up kicking off the entire product build and their associated test suites.  I think this is beyond overkill:  it's dangerous and will sap computing power and lock up slaves doing what's essentially no-ops.

PR's change frequently.  Imagine a change in base that gets a few different revisions?  Suddenly I can't even update my PR to change some text string without it kicking off a potential entire build chain and test suite.

Not to mention, what if the upstream tests were already failing? You'd have to build all the upstream plugins with the OLD base, then build base, build everything, run all the tests, and somehow compare the new test results to the previous test results.

I think this is folly, and it should not be pursued at all.

Start with a), and finish with a).

On Tue, Apr 26, 2016 at 6:59 PM, Alexey Kazakov <alkazako@redhat.com> wrote:

+100 to start with a)

On 04/26/2016 02:20 PM, Nick Boldt wrote:

https://issues.jboss.org/browse/JBIDE-21657

On Tue, Apr 26, 2016 at 1:13 PM, Mickael Istria <mistria@redhat.com> wrote:

On 04/26/2016 05:50 PM, Max Rydahl Andersen wrote:

in other words, start with a

a) does the PR break my tests / want a green light on the PR page

+1000. Is there a Jira for that?
--
Mickael Istria
Eclipse developer at JBoss, by Red Hat
My blog - My Tweets

_______________________________________________
jbosstools-dev mailing list
jbosstools-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jbosstools-dev

_______________________________________________
jbosstools-dev mailing list
jbosstools-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jbosstools-dev