Reverting the patch was the
correct solution.
It is not always possible to rebuild *all* dependent
components locally and run the test suites. That's what
Jenkins is for. It'd take a very long time. I *did* rebuild
all of base and run its tests though. Reverting the fix is
the best solution there is. It's a smack in the face to the
committer (me), which alerts me to fix my problem, and it
also gets MASTER back in shape as fast as possible.
I take full blame for the issue of course, but I do feel
that asking me to build all of jbt before committing is a
bit much. I should have just taken more time to review the
change.
In the future, also re-open whichever jira was the one that
caused the error. You can see it in the commit log.
Anyway, good work team. ... well, everyone except me ;)
On 04/27/2013 01:05 PM, Alexey Kazakov wrote:
On 04/26/2013 08:07 PM, Max
Andersen wrote:
Alexey,
That sucks and should not happen. In such cases its
ok to revert that commit and reopen the PR. I can't do
it right now since I'm on the road. Feel free to do it.
Done.
/max (sent from my phone)
_______________________________________________
jbosstools-dev mailing list
jbosstools-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jbosstools-dev