Hi, Vitali,

> I want to enhance this editor ("Hibernate Configuration 3.0 XML Editor")

> to make it more useful and I want to integrate it into Hibernate Tools.

> For this it is necessary to separate org.jboss.tools.hibernate.xml

> and org.jboss.tools.hibernate.xml.ui, make it detached from XModel…

 

In my opinion that just means implementing new editor from scratch. In doing so, you will develop components that you may wish to put to common. We have many xml editors, there ui has a lot in common, so why not share new approaches between them? And that is exactly what XModel framework does. Plugins .hibernate.xml and .hibernate.xml.ui include just few lines of code customizing components developed in common. Why 'integrating editor into Hibernate Tools' should mean separating it from common?

 

All enhancements, listed in https://jira.jboss.org/jira/browse/JBIDE-2607 may be implemented within existing editor. I am sorry I did not pay attention to this issue before.

 

Slava

----- Original Message -----
From: Vitali Yemialyanchyk
To: Exadel List
Cc: jbosstools-dev@lists.jboss.org
Sent: Wednesday, September 09, 2009 5:12 PM
Subject: [jbosstools-dev] "Hibernate Configuration 3.0 XML Editor"

Hi,

 

I want to start discussion of "Hibernate Configuration 3.0 XML Editor".

This rather strange editor is situated in

trunk\hibernatetools\plugins\org.jboss.tools.hibernate.xml

trunk\hibernatetools\plugins\org.jboss.tools.hibernate.xml.ui

I call it strange cause it in hibernatetools in svn repository, but really this is Jboss Tools thing and it was nether in Hibernate Tools.

Some users has questions about this and create such bugs in jira:

https://jira.jboss.org/jira/browse/JBIDE-4802

For them and for me (if I think about myself as Hibernate Tools user, not a developer) it is difficult to explain, why I should take a lot of things

from JBoss Tools if I just want to use separate Hibernate Tools. As a developer I see advantages of common things…

To make it more useful I create JIRA issue far time ago:

https://jira.jboss.org/jira/browse/JBIDE-2607

there are no changes since that time.

I want to enhance this editor to make it more useful and I want to integrate it into Hibernate Tools.

For this it is necessary to separate org.jboss.tools.hibernate.xml and org.jboss.tools.hibernate.xml.ui, make it detached from XModel…

So I want to hear some arguments pro/contra this solution and/or may be some advises howto possible make this changes in better manner.

 

Vitali

_______________________________________________
jbosstools-dev mailing list
jbosstools-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jbosstools-dev