On 9 Dec 2014, at 2:19, Alexey Kazakov wrote:Thanks to all component leads who updated their root poms (and I
updated the rest of components: forge, aerogear, central, freemarker).
So all components that have been changed since 4.2.0 are using
4.2.1.Final-SNAPSHOT root pom now.
However, two components, Birt and Portlet don't have any changes
besides updated root poms. As I understand we should change the root
pom versio ONLY if the component has been changed since 4.2.0.Final.
I reopened the corresponding issues for Birt and Portlet for
clarification:
https://issues.jboss.org/browse/JBIDE-18890
https://issues.jboss.org/browse/JBIDE-18896
Should we ignore these changes and not to rebuild Birt & Portlet for
4.2.1?
I would say so - we have the 4.2.0.Final updatesite to get these from so sounds weird why we need to update these.The whole intent we are going for is to *not* burden users with more bits to download AND avoid QE having to test/verify new binaries.
The idea is nice, but I'm not sure this can actually ever work. The target platform was changed anyway (including common/foundation JBT plugins). So theoretically you can never be 100 % sure that JBT 4.2.1.Final will work with the older portlet.
So you can never say that no testing is needed. I'm actually not sure how much difference it makes - if you know that there were no changes but the bits are newly built as opposed to using exactly the same bits - in both cases you need at least some smoke testing.
But I agree from use perspective it's probably nicer if they need to update less bits.
-Martin
Nick - if our build deletes our actual released bits and not allow using the previous bits then that is a problem.Did the check for publish fail to detect there was no change ?We have had and will have this situation for others than just "dormant" modules like birt and portlet so we should be able to handle this by now IMO.What is missing ?/max
On 12/08/2014 12:54 PM, Nick Boldt wrote:
TL;DR: Yes.
I did not create task JIRAs for Hibernate and Livereload, because
neither of those have commits in the 4.2.x branch since 4.2.0.Final
and
therefore need not have their root poms adjusted.
On 12/08/2014 02:01 AM, Max Rydahl Andersen wrote:
On 08 Dec 2014, at 04:19, Nick Boldt <nboldt@redhat.com> wrote:
his week is the "quiet period" in prep for 4.2.1.Final / 8.0.1.GA.
You are required to update your root poms to point at the latest
parent
pom,
I assume you mean "If and only if the build your component is in has
changed since 4.2.0.Final", correct ?
As otherwise we are going to have updates to *everything* which is
what we don't want for our maintanence builds.
Just want to make sure the above is what you meant or to know if you
found something in our build that requires *every* component to
update parent Pom?
_______________________________________________
jbosstools-dev mailing list
jbosstools-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jbosstools-dev
/maxhttp://about.me/maxandersen_______________________________________________jbosstools-dev mailing listjbosstools-dev@lists.jboss.orghttps://lists.jboss.org/mailman/listinfo/jbosstools-dev