On 09/05/2012 12:46 PM, Max Rydahl Andersen wrote:
On 09/05/2012 11:03 AM, Max Rydahl Andersen wrote:
What few classes exactly ? link to github ?
For the example I've just checked, only this one seems necessary: https://github.com/jeeeyul/eclipse-themes/blob/master/net.jeeeyul.eclipse.themes/src/net/jeeeyul/eclipse/themes/rendering/ChromeTabRendering.java
this class seem to depend heavily on HackedCTabRendering and themes* classes ?
Yup.

for me it seriously feels like overkill to start depending on an external project for something like css theming.
It also provides the nice Theme editor in preferences. But I'm not sure that's something we want to provide.
well, I don't find it like something we would want to maintain would we ?
Maintainance effort are probably very low. But we could also ask to split the bundle into several bundles (common, renderers, editor) so we could reuse only common and renderers.

Would it make sense to fork these classes instead ?
Sure we could.
is this class something the css styles would reference as a "alternative rendering" ?
What does this one actually fix ?
Yes it is.
I supports some additional color parameters compared to default one from e4. So you can have different color for text, a gradient, and draw lines more clearly.
--
Mickael Istria
Eclipse developer at JBoss, by Red Hat
My blog - My Tweets