Are you talking about @xxxxxx@ EL like in components.xml or about #{xxxxxxx} like in pages.xml?Hi Denis,I'd not say it is good. First of all I cannot see any reason to put it in common. El is related to Java Server Pages (${}) and JSF (#{}).But what is major purpose of new plug-ins? It is providing replacement for EL expressions to possible values. It should allow to show page in VPE as close to run-time as possible. That functionality is related only to VPE and that means there is no reason to move those plug-ins in nether to common component nor to any other. VPE component is a right place for it, especially org.jboss.tools.vpe plugin.Not true. EL is used in non-JSF scenarios too. e.g. Seam configuration files. I asked Eugene to split out the specific EL replacement setup to be able to use this in non-VPE scenarios.
I objected because it seems that this resulted in two plugins which dependency list is the opposite of what I would expect since I still do not see why EL resolving has a dependency to something related to resource references. Just because there are some ui components in there the EL ui uses does not make it right. In my pov the only parts that would need "extracting" is the EL core and ui and those could make it into org.jboss.tools.common.el.core and org.jboss.tools.common.el.ui and at least be independent plugins which does this basic and simple task of providing configuration for the global, project and folder level EL variables and have a simple core api for resolving a variable in a given context. Then if VPE needs to convert these into resource references that should be done in VPE. /maxThanks Denis Eugene Stherbin wrote:Max Rydahl Andersen пишет:good, but why does the EL variable substitution require resource references ? Why are there VPE packages in it ? Why put it in separate packages when there is still these hard dependencies ? /max ----- "Eugene Stherbin" <estherbin@exadel.com> wrote:Hi, The org.jboss.tools.common.rreferences bundle renamed to the org.jboss.tools.common.resref in svn. -- Best Ragards, Eugene Stherbin Exadel Inc. Mob. phone: +375 (29) 705-52-59 E-mail: estherbin@exadel.com _______________________________________________ jbosstools-dev mailing list jbosstools-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/jbosstools-dev1.org.jboss.tools.common.resref bundle contains of base classes.Theseclasses has all necessary functionality for save/read properties,showpopups, display table with Add/Edit/Delete functionality and e.t.c.org.jboss.tools.common.el - contains of 4 classes that extends basefunctionality and add functionality required for Global El/Vpe El. 2. Because classes in VPE package required only for VPE. 3. See point 1. It separated to two bundles because bundles has difference logical functionality and if we will want add new similarfunctionality only extends from org.jboss.tools.common.resrefbundle.