On Mon, 14 Jul 2008 15:12:49 +0200, Galder Zamarreno <galder.zamarreno(a)redhat.com&gt; wrote: > Hi, > > Couple of suggestions: one of the most likely file filters people might > create for servers is for conf/jboss-log4j.xml, so that they can change > logging...etc. So, couple of suggestions here: > > 1.- The default root directory of a new file filter should be the server > root folder and not the deploy folder: > > No: /home/galder/access/eap-rel/4.3.0.ga.cp01/server/189901/deploy > Yes: /home/galder/access/eap-rel/4.3.0.ga.cp01/server/189901 > > 2.- Ability to define default "File Filters" for new Servers with > *-log4j.xml as example. I guess what you are saying is that you want to be able to set the root folder to something else than the deploy dir since the deploy dir could actually be *outside* the server.

file a jira. -max

On Fri, 18 Jul 2008 10:03:01 +0200, Galder Zamarreno <galder.zamarreno(a)redhat.com&gt; wrote: > Max Rydahl Andersen wrote: >> On Mon, 14 Jul 2008 15:12:49 +0200, Galder Zamarreno <galder.zamarreno(a)redhat.com&gt; wrote: >> >>> Hi, >>> >>> Couple of suggestions: one of the most likely file filters people might >>> create for servers is for conf/jboss-log4j.xml, so that they can change >>> logging...etc. So, couple of suggestions here: >>> >>> 1.- The default root directory of a new file filter should be the server >>> root folder and not the deploy folder: >>> >>> No: /home/galder/access/eap-rel/4.3.0.ga.cp01/server/189901/deploy >>> Yes: /home/galder/access/eap-rel/4.3.0.ga.cp01/server/189901 >>> >>> 2.- Ability to define default "File Filters" for new Servers with >>> *-log4j.xml as example. >> I guess what you are saying is that you want to be able to set the root folder to something >> else than the deploy dir since the deploy dir could actually be *outside* the server. > No, read above, I didn't talk about having the deploy folder somewhere else. Today only the configured deploy folder is possible; if we default it to the server root instead and the users deploy folder is *outside* the server root we loose the ability to look into deployed things.

Hence what is needed as far as i see that we allow you to set the root folder freely; not just to deploy folder.

-max

>> Today only the configured deploy folder is possible; if we default it to the server root instead >> and the users deploy folder is *outside* the server root we loose the ability to look into deployed things. > Hmmm, so you mean that if the root is > /home/galder/access/eap-rel/4.3.0.ga.cp01/server/189901, the filter has > to be something like deploy/*-foobar.xml, rather than just *-foobar.xml > if the root was > /home/galder/access/eap-rel/4.3.0.ga.cp01/server/189901/deploy ? Yes. >> Hence what is needed as far as i see that we allow you to set the root folder freely; not just to deploy folder. > I'm not sure whether we're talking about the same thing here. You want us to use the server root folder by default - i'm saying that won't work if the user want to look into the deployed artifacts if they are located somewhere else. Hence the root setting needs to be free to specify. /max