[ https://jira.jboss.org/jira/browse/JBIDE-4274?page=com.atlassian.jira.plu... ] Alexey Kazakov reassigned JBIDE-4274: ------------------------------------- Assignee: Alexey Kazakov -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4274?page=com.atlassian.jira.plu... ] Alexey Kazakov commented on JBIDE-4274: --------------------------------------- It seems to be an issue of WTP. They added new RefactoringProcessor for context root rename (see https://bugs.eclipse.org/bugs/show_bug.cgi?id=249128) in WTP 3.0.3. This processor initializes Rename Participants with following parameters: element - instance of IProject newName - <new context root> IMO that's not correct. So such paricipants will be affected: <extension point="org.eclipse.ltk.core.refactoring.renameParticipants"> <renameParticipant ... <enablement> <with variable="element"> <or> <instanceof value="org.eclipse.core.resources.IProject"/> </or> </with> </enablement> </renameParticipant> But we can check "processorIdentifier" to avoid it. Now Seam Rename Participans is invoked by org.eclipse.jdt.ui.renameJavaProjectProcessor and org.eclipse.ltk.core.refactoring.renameResourceProcessor only. BTW I see the same problem in Eclipse ant tools and in our Hibernate tools. If user changes Context Root then ANT and Hibernate launching configurations will be changed and become broken. It's easy to reproduce. I will report it to bugzilla but may be we should check "processorIdentifier" parameter in Hibernate tools too? Max? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4274?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-4274: -------------------------------------------- Definitely report this since it has bad sideeffects, remember to mention the ant launch configs which is part of Eclipse (ours are relevant too - but secondary from their POV). But what should they pass in alternatively ? What is the processorIdentifier check you say we could add ? (yes, it should be done for hibernate launch configs) But in short, yes - lets get this reported ASAP. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4274?page=com.atlassian.jira.plu... ] Alexey Kazakov commented on JBIDE-4274: --------------------------------------- Or even they should create new object for Context Root if they want to use Rename Processor to rename it. Rename processor is supposed to rename something so it has parameters "element" - what object is going to be renamed and "newName" - the new name of this object. So I thing correct way is to introduce new Context Root object and then rename it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4274?page=com.atlassian.jira.plu... ] Alexey Kazakov updated JBIDE-4274: ---------------------------------- Attachment: plugin.xml.patch The patch for Hibernate Tools -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4274?page=com.atlassian.jira.plu... ] Alexey Kazakov updated JBIDE-4274: ---------------------------------- Component/s: Hibernate -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4274?page=com.atlassian.jira.plu... ] Aliaksey Nis closed JBIDE-4274. ------------------------------- Verified in jbdevstudio-eap-win32-2.1.0.M1-N200905190437-H189 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira