7:12 a.m.
Potential connection leak
-------------------------
Key: JBTM-789
URL: https://jira.jboss.org/browse/JBTM-789
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: JTA
Environment: JBoss Transactions 4.11, Tomcat, Spring
Reporter: Mauro Molinari
I recently upgraded JBossTS from 4.6.1 GA to 4.11 Final. I see that bug JBTM-532 that I
opened against 4.5 and 4.6 should have been fixed in 4.8.0. However, I have a doubt on the
current (4.11) implementation of com.arjuna.ats.internal.jdbc.ConnectionImple.close().
I mean, if _theModifier is null, a comment says: "no indication about connections, so
assume close immediately". However in this case only _theConnection is closed and set
to null, while _recoveryConnection.closeCloseCurrentConnection() is not called. I think
this may lead to connection leaks.
What I would expect is that if _theModifier is null, a log entry were added but nothing
else were done; in particular I would expect not to return and let the following "if
(!delayClose)" (towards the end of the method) close the connections immediately
(both _theConnection and _recoveryConnection).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:12 a.m.
New subject: [JBoss JIRA] Updated: (JBTM-789) Potential connection leak
[
https://jira.jboss.org/browse/JBTM-789?page=com.atlassian.jira.plugin.sys...
]
Mauro Molinari updated JBTM-789:
--------------------------------
Affects Version/s: 4.11.0
Potential connection leak
-------------------------
Key: JBTM-789
URL: https://jira.jboss.org/browse/JBTM-789
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: JTA
Affects Versions: 4.11.0
Environment: JBoss Transactions 4.11, Tomcat, Spring
Reporter: Mauro Molinari
I recently upgraded JBossTS from 4.6.1 GA to 4.11 Final. I see that bug JBTM-532 that I
opened against 4.5 and 4.6 should have been fixed in 4.8.0. However, I have a doubt on the
current (4.11) implementation of com.arjuna.ats.internal.jdbc.ConnectionImple.close().
I mean, if _theModifier is null, a comment says: "no indication about connections,
so assume close immediately". However in this case only _theConnection is closed and
set to null, while _recoveryConnection.closeCloseCurrentConnection() is not called. I
think this may lead to connection leaks.
What I would expect is that if _theModifier is null, a log entry were added but nothing
else were done; in particular I would expect not to return and let the following "if
(!delayClose)" (towards the end of the method) close the connections immediately
(both _theConnection and _recoveryConnection).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:55 a.m.
New subject: [JBoss JIRA] Updated: (JBTM-789) XA connections leak when no modifier available
[
https://jira.jboss.org/browse/JBTM-789?page=com.atlassian.jira.plugin.sys...
]
Mauro Molinari updated JBTM-789:
--------------------------------
Summary: XA connections leak when no modifier available (was: Potential
connection leak)
Description:
I recently upgraded JBossTS from 4.6.1 GA to 4.11 Final. I see that bug JBTM-532 that I
opened against 4.5 and 4.6 should have been fixed in 4.8.0. However, besides still having
a null _theModifier when using PostgreSQL, the current (4.11) implementation of
com.arjuna.ats.internal.jdbc.ConnectionImple.close() has a problem.
I mean, if _theModifier is null, a comment says: "no indication about connections, so
assume close immediately". However in this case only _theConnection
(java.sql.Connection) is closed and set to null, while
_recoveryConnection.closeCloseCurrentConnection() is not called, leading to an
XAConnection leak.
What I would expect is that if _theModifier is null, a log entry were added but nothing
else were done; in particular I would expect not to return and let the following "if
(!delayClose)" (towards the end of the method) close both the connections
immediately.
was:
I recently upgraded JBossTS from 4.6.1 GA to 4.11 Final. I see that bug JBTM-532 that I
opened against 4.5 and 4.6 should have been fixed in 4.8.0. However, I have a doubt on the
current (4.11) implementation of com.arjuna.ats.internal.jdbc.ConnectionImple.close().
I mean, if _theModifier is null, a comment says: "no indication about connections, so
assume close immediately". However in this case only _theConnection is closed and set
to null, while _recoveryConnection.closeCloseCurrentConnection() is not called. I think
this may lead to connection leaks.
What I would expect is that if _theModifier is null, a log entry were added but nothing
else were done; in particular I would expect not to return and let the following "if
(!delayClose)" (towards the end of the method) close the connections immediately
(both _theConnection and _recoveryConnection).
XA connections leak when no modifier available
----------------------------------------------
Key: JBTM-789
URL: https://jira.jboss.org/browse/JBTM-789
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: JTA
Affects Versions: 4.11.0
Environment: JBoss Transactions 4.11, Tomcat, Spring
Reporter: Mauro Molinari
I recently upgraded JBossTS from 4.6.1 GA to 4.11 Final. I see that bug JBTM-532 that I
opened against 4.5 and 4.6 should have been fixed in 4.8.0. However, besides still having
a null _theModifier when using PostgreSQL, the current (4.11) implementation of
com.arjuna.ats.internal.jdbc.ConnectionImple.close() has a problem.
I mean, if _theModifier is null, a comment says: "no indication about connections,
so assume close immediately". However in this case only _theConnection
(java.sql.Connection) is closed and set to null, while
_recoveryConnection.closeCloseCurrentConnection() is not called, leading to an
XAConnection leak.
What I would expect is that if _theModifier is null, a log entry were added but nothing
else were done; in particular I would expect not to return and let the following "if
(!delayClose)" (towards the end of the method) close both the connections
immediately.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:03 a.m.
New subject: [JBoss JIRA] Commented: (JBTM-789) XA connections leak when no modifier available
[
https://jira.jboss.org/browse/JBTM-789?page=com.atlassian.jira.plugin.sys...
]
Mauro Molinari commented on JBTM-789:
-------------------------------------
Anyway, my own experience (working with Oracle, SQL Server and PostgreSQL) is that the
right decision is to always delay the connection closing after the transaction
termination. Closing the connection immediately can lead to problems if the connection is
actually a pooled connection: in fact, closing it immediately means returning it to the
pool, so that it could be borrowed by some other transaction while the first one (to which
it is still bound) is still in progress.
XA connections leak when no modifier available
----------------------------------------------
Key: JBTM-789
URL: https://jira.jboss.org/browse/JBTM-789
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: JTA
Affects Versions: 4.11.0
Environment: JBoss Transactions 4.11, Tomcat, Spring
Reporter: Mauro Molinari
I recently upgraded JBossTS from 4.6.1 GA to 4.11 Final. I see that bug JBTM-532 that I
opened against 4.5 and 4.6 should have been fixed in 4.8.0. However, besides still having
a null _theModifier when using PostgreSQL, the current (4.11) implementation of
com.arjuna.ats.internal.jdbc.ConnectionImple.close() has a problem.
I mean, if _theModifier is null, a comment says: "no indication about connections,
so assume close immediately". However in this case only _theConnection
(java.sql.Connection) is closed and set to null, while
_recoveryConnection.closeCloseCurrentConnection() is not called, leading to an
XAConnection leak.
What I would expect is that if _theModifier is null, a log entry were added but nothing
else were done; in particular I would expect not to return and let the following "if
(!delayClose)" (towards the end of the method) close both the connections
immediately.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:51 a.m.
New subject: [JBoss JIRA] Updated: (JBTM-789) XA connections leak when no modifier available
[
https://jira.jboss.org/browse/JBTM-789?page=com.atlassian.jira.plugin.sys...
]
Mauro Molinari updated JBTM-789:
--------------------------------
Priority: Critical (was: Major)
XA connections leak when no modifier available
----------------------------------------------
Key: JBTM-789
URL: https://jira.jboss.org/browse/JBTM-789
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: JTA
Affects Versions: 4.11.0
Environment: JBoss Transactions 4.11, Tomcat, Spring
Reporter: Mauro Molinari
Priority: Critical
I recently upgraded JBossTS from 4.6.1 GA to 4.11 Final. I see that bug JBTM-532 that I
opened against 4.5 and 4.6 should have been fixed in 4.8.0. However, besides still having
a null _theModifier when using PostgreSQL, the current (4.11) implementation of
com.arjuna.ats.internal.jdbc.ConnectionImple.close() has a problem.
I mean, if _theModifier is null, a comment says: "no indication about connections,
so assume close immediately". However in this case only _theConnection
(java.sql.Connection) is closed and set to null, while
_recoveryConnection.closeCloseCurrentConnection() is not called, leading to an
XAConnection leak.
What I would expect is that if _theModifier is null, a log entry were added but nothing
else were done; in particular I would expect not to return and let the following "if
(!delayClose)" (towards the end of the method) close both the connections
immediately.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:53 a.m.
New subject: [JBoss JIRA] Commented: (JBTM-789) XA connections leak when no modifier available
[
https://jira.jboss.org/browse/JBTM-789?page=com.atlassian.jira.plugin.sys...
]
Mauro Molinari commented on JBTM-789:
-------------------------------------
This is critical for us. I would appreciate some feedback. Thank you!
XA connections leak when no modifier available
----------------------------------------------
Key: JBTM-789
URL: https://jira.jboss.org/browse/JBTM-789
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: JTA
Affects Versions: 4.11.0
Environment: JBoss Transactions 4.11, Tomcat, Spring
Reporter: Mauro Molinari
Priority: Critical
I recently upgraded JBossTS from 4.6.1 GA to 4.11 Final. I see that bug JBTM-532 that I
opened against 4.5 and 4.6 should have been fixed in 4.8.0. However, besides still having
a null _theModifier when using PostgreSQL, the current (4.11) implementation of
com.arjuna.ats.internal.jdbc.ConnectionImple.close() has a problem.
I mean, if _theModifier is null, a comment says: "no indication about connections,
so assume close immediately". However in this case only _theConnection
(java.sql.Connection) is closed and set to null, while
_recoveryConnection.closeCloseCurrentConnection() is not called, leading to an
XAConnection leak.
What I would expect is that if _theModifier is null, a log entry were added but nothing
else were done; in particular I would expect not to return and let the following "if
(!delayClose)" (towards the end of the method) close both the connections
immediately.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:37 p.m.
New subject: [JBoss JIRA] Assigned: (JBTM-789) XA connections leak when no modifier available
[
https://jira.jboss.org/browse/JBTM-789?page=com.atlassian.jira.plugin.sys...
]
Mark Little reassigned JBTM-789:
--------------------------------
Assignee: Mark Little
XA connections leak when no modifier available
----------------------------------------------
Key: JBTM-789
URL: https://jira.jboss.org/browse/JBTM-789
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: JTA
Affects Versions: 4.11.0
Environment: JBoss Transactions 4.11, Tomcat, Spring
Reporter: Mauro Molinari
Assignee: Mark Little
Priority: Critical
I recently upgraded JBossTS from 4.6.1 GA to 4.11 Final. I see that bug JBTM-532 that I
opened against 4.5 and 4.6 should have been fixed in 4.8.0. However, besides still having
a null _theModifier when using PostgreSQL, the current (4.11) implementation of
com.arjuna.ats.internal.jdbc.ConnectionImple.close() has a problem.
I mean, if _theModifier is null, a comment says: "no indication about connections,
so assume close immediately". However in this case only _theConnection
(java.sql.Connection) is closed and set to null, while
_recoveryConnection.closeCloseCurrentConnection() is not called, leading to an
XAConnection leak.
What I would expect is that if _theModifier is null, a log entry were added but nothing
else were done; in particular I would expect not to return and let the following "if
(!delayClose)" (towards the end of the method) close both the connections
immediately.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:45 a.m.
New subject: [JBoss JIRA] Updated: (JBTM-789) XA connections leak when no modifier available
[
https://jira.jboss.org/browse/JBTM-789?page=com.atlassian.jira.plugin.sys...
]
Mauro Molinari updated JBTM-789:
--------------------------------
Attachment: Patch JBTM-789.txt
This is my proposed patch, based on the discussion in the forum topic.
The patch applies to com.arjuna.ats.internal.jdbc.ConnectionImple.close() and the semantic
is the following.
First of all, both connections (the physical one and the recovery one) are always closed
together. To ensure this, I created a private closeConnectionsImmediately() method which
is called wherever needed.
If the transaction is not active, close the connections immediately.
Otherwise, check if the transaction is valid. If it is not, close the connections
immediately and launch an "invalid transaction" exception.
Otherwise (so, there's a valid transaction), try to delist the resource. In case of
errors launch an exception. However, in any case, a finally block is executed in which the
following check is performed. If we DO have a ConnectionModifier AND it says that the JDBC
driver does not support multiple connections, then close immediately. In all the other
cases, just register a transaction synchronization to close the connections after
transaction termination. This is all done in a finally block, otherwise a connection leak
may occur if something goes wrong (i.e.: if the delist of resources fails).
I hope this can help in some way.
XA connections leak when no modifier available
----------------------------------------------
Key: JBTM-789
URL: https://jira.jboss.org/browse/JBTM-789
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: JTA
Affects Versions: 4.11.0
Environment: JBoss Transactions 4.11, Tomcat, Spring
Reporter: Mauro Molinari
Assignee: Mark Little
Priority: Critical
Attachments: Patch JBTM-789.txt
I recently upgraded JBossTS from 4.6.1 GA to 4.11 Final. I see that bug JBTM-532 that I
opened against 4.5 and 4.6 should have been fixed in 4.8.0. However, besides still having
a null _theModifier when using PostgreSQL, the current (4.11) implementation of
com.arjuna.ats.internal.jdbc.ConnectionImple.close() has a problem.
I mean, if _theModifier is null, a comment says: "no indication about connections,
so assume close immediately". However in this case only _theConnection
(java.sql.Connection) is closed and set to null, while
_recoveryConnection.closeCloseCurrentConnection() is not called, leading to an
XAConnection leak.
What I would expect is that if _theModifier is null, a log entry were added but nothing
else were done; in particular I would expect not to return and let the following "if
(!delayClose)" (towards the end of the method) close both the connections
immediately.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:23 a.m.
New subject: [JBoss JIRA] Updated: (JBTM-789) XA connections leak when no modifier available
[
https://issues.jboss.org/browse/JBTM-789?page=com.atlassian.jira.plugin.s...
]
Tom Jenkinson updated JBTM-789:
-------------------------------
Fix Version/s: 5.0.0.M2
XA connections leak when no modifier available
----------------------------------------------
Key: JBTM-789
URL: https://issues.jboss.org/browse/JBTM-789
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: JTA
Affects Versions: 4.11.0
Environment: JBoss Transactions 4.11, Tomcat, Spring
Reporter: Mauro Molinari
Assignee: Mark Little
Priority: Critical
Fix For: 5.0.0.M2
Attachments: Patch JBTM-789.txt
I recently upgraded JBossTS from 4.6.1 GA to 4.11 Final. I see that bug JBTM-532 that I
opened against 4.5 and 4.6 should have been fixed in 4.8.0. However, besides still having
a null _theModifier when using PostgreSQL, the current (4.11) implementation of
com.arjuna.ats.internal.jdbc.ConnectionImple.close() has a problem.
I mean, if _theModifier is null, a comment says: "no indication about connections,
so assume close immediately". However in this case only _theConnection
(java.sql.Connection) is closed and set to null, while
_recoveryConnection.closeCloseCurrentConnection() is not called, leading to an
XAConnection leak.
What I would expect is that if _theModifier is null, a log entry were added but nothing
else were done; in particular I would expect not to return and let the following "if
(!delayClose)" (towards the end of the method) close both the connections
immediately.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:58 a.m.
New subject: [JBoss JIRA] Updated: (JBTM-789) XA connections leak when no modifier available
[
https://issues.jboss.org/browse/JBTM-789?page=com.atlassian.jira.plugin.s...
]
Tom Jenkinson updated JBTM-789:
-------------------------------
Fix Version/s: 5.0.0.Final
(was: 5.0.0.M2)
XA connections leak when no modifier available
----------------------------------------------
Key: JBTM-789
URL: https://issues.jboss.org/browse/JBTM-789
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: JTA
Affects Versions: 4.11.0
Environment: JBoss Transactions 4.11, Tomcat, Spring
Reporter: Mauro Molinari
Assignee: Mark Little
Priority: Critical
Fix For: 5.0.0.Final
Attachments: Patch JBTM-789.txt
I recently upgraded JBossTS from 4.6.1 GA to 4.11 Final. I see that bug JBTM-532 that I
opened against 4.5 and 4.6 should have been fixed in 4.8.0. However, besides still having
a null _theModifier when using PostgreSQL, the current (4.11) implementation of
com.arjuna.ats.internal.jdbc.ConnectionImple.close() has a problem.
I mean, if _theModifier is null, a comment says: "no indication about connections,
so assume close immediately". However in this case only _theConnection
(java.sql.Connection) is closed and set to null, while
_recoveryConnection.closeCloseCurrentConnection() is not called, leading to an
XAConnection leak.
What I would expect is that if _theModifier is null, a log entry were added but nothing
else were done; in particular I would expect not to return and let the following "if
(!delayClose)" (towards the end of the method) close both the connections
immediately.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:20 a.m.
New subject: [JBoss JIRA] (JBTM-789) XA connections leak when no modifier available
[
https://issues.jboss.org/browse/JBTM-789?page=com.atlassian.jira.plugin.s...
]
Tom Jenkinson reassigned JBTM-789:
----------------------------------
Assignee: Tom Jenkinson (was: Mark Little)
XA connections leak when no modifier available
----------------------------------------------
Key: JBTM-789
URL: https://issues.jboss.org/browse/JBTM-789
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: JTA
Affects Versions: 4.11.0
Environment: JBoss Transactions 4.11, Tomcat, Spring
Reporter: Mauro Molinari
Assignee: Tom Jenkinson
Priority: Critical
Fix For: 5.0.1.Final
Attachments: Patch JBTM-789.txt
I recently upgraded JBossTS from 4.6.1 GA to 4.11 Final. I see that bug JBTM-532 that I
opened against 4.5 and 4.6 should have been fixed in 4.8.0. However, besides still having
a null _theModifier when using PostgreSQL, the current (4.11) implementation of
com.arjuna.ats.internal.jdbc.ConnectionImple.close() has a problem.
I mean, if _theModifier is null, a comment says: "no indication about connections,
so assume close immediately". However in this case only _theConnection
(java.sql.Connection) is closed and set to null, while
_recoveryConnection.closeCloseCurrentConnection() is not called, leading to an
XAConnection leak.
What I would expect is that if _theModifier is null, a log entry were added but nothing
else were done; in particular I would expect not to return and let the following "if
(!delayClose)" (towards the end of the method) close both the connections
immediately.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4313
days inactive
4969
days old
jbossts-issues@lists.jboss.org
11 comments
3 participants
participants (3)
-
Mark Little (JIRA) -
Mauro Molinari (JIRA)
-
Tom Jenkinson (JIRA)