[
https://issues.jboss.org/browse/JBTM-3162?page=com.atlassian.jira.plugin....
]
Ariel Carrera edited comment on JBTM-3162 at 7/24/19 10:31 AM:
---------------------------------------------------------------
I committed the changes in a fork. Tell me if you need a junit test for these little lines
removed that doesn't change any function.
was (Author: arielcarrera):
I created the ticket and committed changes in a fork. Tell me if you need a junit test for
these little lines removed that doesn't change any function.
Remove superfluous double check at validTransaction method
----------------------------------------------------------
Key: JBTM-3162
URL:
https://issues.jboss.org/browse/JBTM-3162
Project: JBoss Transaction Manager
Issue Type: Enhancement
Components: Transactional Driver
Affects Versions: 5.9.5.Final
Reporter: Ariel Carrera
Priority: Trivial
There is a superfluous check at BaseTransactionalDriverXAConnection.validTransaction
method.
{code:java}
public final boolean validTransaction(javax.transaction.Transaction tx) {
boolean valid = true;
if (_theTransaction != null) {
valid = _theTransaction.equals(tx);
* if (!valid) {
valid = _theTransaction.equals(tx);
} *
}
return valid;
}
{code}
link:
[
github|https://github.com/jbosstm/narayana/blob/9f42d45b664483c9f0e17cb20...]
--
This message was sent by Atlassian Jira
(v7.12.1#712002)