Author: remy.maucherat(a)jboss.com
Date: 2008-07-29 11:41:07 -0400 (Tue, 29 Jul 2008)
New Revision: 732
Modified:
trunk/java/org/apache/catalina/realm/JDBCRealm.java
trunk/webapps/docs/changelog.xml
Log:
- Port patch: sync getPrincipal.
Modified: trunk/java/org/apache/catalina/realm/JDBCRealm.java
===================================================================
--- trunk/java/org/apache/catalina/realm/JDBCRealm.java 2008-07-25 16:29:30 UTC (rev 731)
+++ trunk/java/org/apache/catalina/realm/JDBCRealm.java 2008-07-29 15:41:07 UTC (rev 732)
@@ -38,10 +38,9 @@
* See the JDBCRealm.howto for more details on how to set up the database and
* for configuration options.
*
-* <p><strong>TODO</strong> - Support connection pooling (including
message
-* format objects) so that <code>authenticate()</code>,
-* <code>getPassword()</code> and <code>authenticate()</code> do
not have to be
-* synchronized and would fix the ugly connection logic. </p>
+* <p><strong>NOTE</strong>: This realm features simple configuration,
but
+* uses a single connection to the database. In cases where authentication
+* becomes a bottleneck, the DataSource realm must be used instead.</p>
*
* @author Craig R. McClanahan
* @author Carson McDonald
@@ -591,7 +590,7 @@
/**
* Return the Principal associated with the given user name.
*/
- protected Principal getPrincipal(String username) {
+ protected synchronized Principal getPrincipal(String username) {
return (new GenericPrincipal(this,
username,
Modified: trunk/webapps/docs/changelog.xml
===================================================================
--- trunk/webapps/docs/changelog.xml 2008-07-25 16:29:30 UTC (rev 731)
+++ trunk/webapps/docs/changelog.xml 2008-07-29 15:41:07 UTC (rev 732)
@@ -16,6 +16,16 @@
<body>
+<section name="JBoss Web 2.1.1.CR6 (remm)">
+ <subsection name="Catalina">
+ <changelog>
+ <fix>
+ <bug>45453</bug>: Sync getPrincipal in JDBCRealm. (markt)
+ </fix>
+ </changelog>
+ </subsection>
+</section>
+
<section name="JBoss Web 2.1.1.CR5 (remm)">
<subsection name="General">
<changelog>
Show replies by date