JBoss JBPM SVN: r6460 - in jbpm4/trunk: qa and 1 other directory.
by do-not-reply＠jboss.org
Author: alex.guizar(a)jboss.com
Date: 2010-07-05 17:06:27 -0400 (Mon, 05 Jul 2010)
New Revision: 6460
Removed:
jbpm4/trunk/modules/test-upgrade/.settings/
Modified:
jbpm4/trunk/modules/test-upgrade/pom.xml
jbpm4/trunk/qa/hudson-jbpm4-upgrade.sh
Log:
JBPM-2893: fix hudson upgrade job
Modified: jbpm4/trunk/modules/test-upgrade/pom.xml
===================================================================
--- jbpm4/trunk/modules/test-upgrade/pom.xml 2010-07-04 19:19:51 UTC (rev 6459)
+++ jbpm4/trunk/modules/test-upgrade/pom.xml 2010-07-05 21:06:27 UTC (rev 6460)
@@ -1,15 +1,14 @@
<?xml version="1.0" encoding="UTF-8"?>
<!-- ====================================================================== -->
+<!-- jBPM: Workflow in Java -->
<!-- -->
-<!-- JBoss, the OpenSource J2EE webOS -->
-<!-- -->
<!-- Distributable under LGPL license. -->
<!-- See terms of license at http://www.gnu.org. -->
-<!-- -->
<!-- ====================================================================== -->
-<!-- $Id: pom.xml 3010 2008-11-20 08:30:16Z tom.baeyens(a)jboss.com $ -->
+<!-- $Id$ -->
+
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
@@ -29,7 +28,7 @@
</parent>
<dependencies>
- <dependency>
+ <dependency>
<groupId>org.jbpm.jbpm4</groupId>
<artifactId>jbpm-jpdl</artifactId>
</dependency>
@@ -38,12 +37,12 @@
<artifactId>jbpm-bpmn</artifactId>
</dependency>
<dependency>
- <groupId>hsqldb</groupId>
- <artifactId>hsqldb</artifactId>
- <version>${hsqldb.version}</version>
+ <groupId>org.jbpm.jbpm4</groupId>
+ <artifactId>jbpm-test-base</artifactId>
+ <scope>test</scope>
</dependency>
</dependencies>
-
+
<profiles>
<!-- -Ddatabase= -->
@@ -76,13 +75,12 @@
<copy todir="target/jdbc.properties" overwrite="true" failonerror="false">
<fileset dir="${user.home}/.jbpm4/jdbc" />
</copy>
-
<replace dir="target/jdbc.properties">
<include name="*.properties" />
<replacefilter token="PVM1" value="PVM2" />
<replacefilter token="pvm1" value="pvm2" />
</replace>
-
+
<ant antfile="../distro/src/main/files/install/build.xml" target="create.cfg">
<property name="tx" value="standalone.testsuite" />
<property name="mail.cfg" value="testsuite" />
@@ -91,7 +89,7 @@
<property name="install.src.dir" value="../distro/src/main/files/install/src" />
<property name="jdbc.properties.dir" value="target/jdbc.properties" />
<property name="logging" value="none" /> <!-- then the original logging.properties in the resources of this project will be used -->
- </ant>
+ </ant>
</tasks>
</configuration>
</execution>
@@ -100,8 +98,5 @@
</plugins>
</build>
</profile>
-
</profiles>
-
-
</project>
Property changes on: jbpm4/trunk/modules/test-upgrade/pom.xml
___________________________________________________________________
Name: svn:keywords
+ Id
Modified: jbpm4/trunk/qa/hudson-jbpm4-upgrade.sh
===================================================================
--- jbpm4/trunk/qa/hudson-jbpm4-upgrade.sh 2010-07-04 19:19:51 UTC (rev 6459)
+++ jbpm4/trunk/qa/hudson-jbpm4-upgrade.sh 2010-07-05 21:06:27 UTC (rev 6460)
@@ -2,18 +2,17 @@
#
# runs the upgrade tests
-MAVEN_OPTS="-Xmx512M"
-ANT_OPTS="-Dold.jbpm.version=$OLD_JBPM_VERSION -Ddatabase=$DATABASE -Djbpm.parent.dir=$WORKSPACE"
+export ANT_OPTS="-Dold.jbpm.version=$OLD_JBPM_VERSION -Ddatabase=$DATABASE \
+ -Djbpm.parent.dir=$WORKSPACE"
-cd qa/upgrade
-mvn $ANT_OPTS dependency:copy
-cd ../..
+export MAVEN_OPTS=$ANT_OPTS
+# build distribution
+mvn -f qa/upgrade/pom.xml dependency:copy
mvn -U -Pdistro,integration clean install
+# set up
ant -f qa/build.xml testsuite.upgrade.setup
-
-cd modules/test-upgrade
-mvn $ANT_OPTS clean test
-cd ../..
-
+# run test suite
+mvn -f modules/test-upgrade/pom.xml clean test
+# tear down
ant -f qa/build.xml testsuite.upgrade.teardown
13 years, 12 months
- 1
- 0
JBoss JBPM SVN: r6459 - in projects/migration_tool/trunk: use_cases and 1 other directory.
by do-not-reply＠jboss.org
Author: eschabell
Date: 2010-07-04 15:19:51 -0400 (Sun, 04 Jul 2010)
New Revision: 6459
Added:
projects/migration_tool/trunk/use_cases/
projects/migration_tool/trunk/use_cases/readme.txt
Log:
Adding use case dir to hold our tooling cases.
Added: projects/migration_tool/trunk/use_cases/readme.txt
===================================================================
--- projects/migration_tool/trunk/use_cases/readme.txt (rev 0)
+++ projects/migration_tool/trunk/use_cases/readme.txt 2010-07-04 19:19:51 UTC (rev 6459)
@@ -0,0 +1,5 @@
+This directory will hold use cases of jpdl3 process designs that will convert
+with this tool to the matching (provided) bpmn2 process design.
+
+Eric D. Schabell
+
13 years, 12 months
- 1
- 0
JBoss JBPM SVN: r6458 - in jbpm4/trunk/modules/test-cfg/src/test: java/org/jbpm/test/slashinactivity and 2 other directories.
by do-not-reply＠jboss.org
Author: rebody
Date: 2010-07-04 00:36:00 -0400 (Sun, 04 Jul 2010)
New Revision: 6458
Added:
jbpm4/trunk/modules/test-cfg/src/test/java/org/jbpm/test/slashinactivity/
jbpm4/trunk/modules/test-cfg/src/test/java/org/jbpm/test/slashinactivity/SlashInActivityTest.java
jbpm4/trunk/modules/test-cfg/src/test/resources/org/jbpm/test/slashinactivity/
jbpm4/trunk/modules/test-cfg/src/test/resources/org/jbpm/test/slashinactivity/jbpm.cfg.xml
Log:
JBPM-2904 testcase for Slash(/) in activity name.
Added: jbpm4/trunk/modules/test-cfg/src/test/java/org/jbpm/test/slashinactivity/SlashInActivityTest.java
===================================================================
--- jbpm4/trunk/modules/test-cfg/src/test/java/org/jbpm/test/slashinactivity/SlashInActivityTest.java (rev 0)
+++ jbpm4/trunk/modules/test-cfg/src/test/java/org/jbpm/test/slashinactivity/SlashInActivityTest.java 2010-07-04 04:36:00 UTC (rev 6458)
@@ -0,0 +1,52 @@
+/*
+ * JBoss, Home of Professional Open Source
+ * Copyright 2005, JBoss Inc., and individual contributors as indicated
+ * by the @authors tag. See the copyright.txt in the distribution for a
+ * full listing of individual contributors.
+ *
+ * This is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU Lesser General Public License as
+ * published by the Free Software Foundation; either version 2.1 of
+ * the License, or (at your option) any later version.
+ *
+ * This software is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this software; if not, write to the Free
+ * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
+ * 02110-1301 USA, or see the FSF site: http://www.fsf.org.
+ */
+/**
+ *
+ */
+package org.jbpm.test.slashinactivity;
+
+import org.jbpm.api.Configuration;
+import org.jbpm.api.Execution;
+import org.jbpm.api.ExecutionService;
+import org.jbpm.api.JbpmException;
+import org.jbpm.api.ProcessEngine;
+import org.jbpm.api.ProcessInstance;
+import org.jbpm.test.JbpmCustomCfgTestCase;
+import org.jbpm.test.JbpmTestCase;
+
+
+public class SlashInActivityTest extends JbpmCustomCfgTestCase {
+
+ private static final String PROCESS_KEY = "test_process";
+
+ private static final String TEST_PROCESS =
+ "<process name='" + PROCESS_KEY + "'>" +
+ " <start name='1/2'>" +
+ " <transition to='theEnd' />" +
+ " </start>" +
+ " <end name='theEnd' />" +
+ "</process>";
+
+ public void testSlashInActivity() {
+ deployJpdlXmlString(TEST_PROCESS);
+ }
+}
Added: jbpm4/trunk/modules/test-cfg/src/test/resources/org/jbpm/test/slashinactivity/jbpm.cfg.xml
===================================================================
--- jbpm4/trunk/modules/test-cfg/src/test/resources/org/jbpm/test/slashinactivity/jbpm.cfg.xml (rev 0)
+++ jbpm4/trunk/modules/test-cfg/src/test/resources/org/jbpm/test/slashinactivity/jbpm.cfg.xml 2010-07-04 04:36:00 UTC (rev 6458)
@@ -0,0 +1,13 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<jbpm-configuration>
+
+ <import resource="jbpm.default.cfg.xml" />
+ <import resource="jbpm.tx.hibernate.cfg.xml" />
+ <import resource="jbpm.jpdl.cfg.xml" />
+
+ <process-engine-context>
+ <true name='jbpm.activity.allow.slash'/>
+ </process-engine-context>
+
+</jbpm-configuration>
13 years, 12 months
- 1
- 0
JBoss JBPM SVN: r6457 - jbpm4/trunk/modules/userguide/src/main/docbook/en/modules.
by do-not-reply＠jboss.org
Author: rebody
Date: 2010-07-03 21:20:54 -0400 (Sat, 03 Jul 2010)
New Revision: 6457
Modified:
jbpm4/trunk/modules/userguide/src/main/docbook/en/modules/ch09-Configuration.xml
Log:
format userguide
Modified: jbpm4/trunk/modules/userguide/src/main/docbook/en/modules/ch09-Configuration.xml
===================================================================
--- jbpm4/trunk/modules/userguide/src/main/docbook/en/modules/ch09-Configuration.xml 2010-07-04 01:07:22 UTC (rev 6456)
+++ jbpm4/trunk/modules/userguide/src/main/docbook/en/modules/ch09-Configuration.xml 2010-07-04 01:20:54 UTC (rev 6457)
@@ -97,10 +97,16 @@
By default, the rule of validation as followed:
<itemizedlist>
<listitem>
- <para>If the activity has a name, the name shouldnot be empty. The <literal>""</literal> isnot allowed to be used by the name of activity.</para>
+ <para>If the activity has a name, the name shouldnot be empty.
+ The <literal>""</literal> isnot allowed to be used by the name of activity.</para>
</listitem>
<listitem>
- <para>The name of activity cannot contain slash(/). It comes from jBPM 3.x. Because jBPM 3.x supported <literal>hierarchical names</literal>, it allowed an execution could jump from a super-state to the other level of activities. But in jBPM 4.x, there would be no chance to achieve this feature. So if someone want to use slash(/) in the name of activity. He could add this configuration parameter into jbpm.cfg.xml.</para>
+ <para>The name of activity cannot contain slash(/). It comes from jBPM 3.x.
+ Because jBPM 3.x supported <literal>hierarchical names</literal>,
+ it allowed an execution could jump from a super-state to the other level of activities.
+ But in jBPM 4.x, there would be no chance to achieve this feature.
+ So if someone want to use slash(/) in the name of activity.
+ He could add this configuration parameter into jbpm.cfg.xml.</para>
<programlisting>
<jbpm-configuration>
<import resource="jbpm.default.cfg.xml" />
13 years, 12 months
- 1
- 0
JBoss JBPM SVN: r6456 - in jbpm4/trunk/modules: userguide/src/main/docbook/en/modules and 1 other directory.
by do-not-reply＠jboss.org
Author: rebody
Date: 2010-07-03 21:07:22 -0400 (Sat, 03 Jul 2010)
New Revision: 6456
Modified:
jbpm4/trunk/modules/jpdl/src/main/java/org/jbpm/jpdl/internal/activity/JpdlBinding.java
jbpm4/trunk/modules/userguide/src/main/docbook/en/modules/ch09-Configuration.xml
Log:
JBPM-2904 add a parameter to decide whether we allow Slash(/) in activity name.
Modified: jbpm4/trunk/modules/jpdl/src/main/java/org/jbpm/jpdl/internal/activity/JpdlBinding.java
===================================================================
--- jbpm4/trunk/modules/jpdl/src/main/java/org/jbpm/jpdl/internal/activity/JpdlBinding.java 2010-07-04 00:43:32 UTC (rev 6455)
+++ jbpm4/trunk/modules/jpdl/src/main/java/org/jbpm/jpdl/internal/activity/JpdlBinding.java 2010-07-04 01:07:22 UTC (rev 6456)
@@ -24,6 +24,7 @@
import org.w3c.dom.Element;
import org.jbpm.jpdl.internal.xml.JpdlParser;
+import org.jbpm.pvm.internal.env.EnvironmentImpl;
import org.jbpm.pvm.internal.model.ActivityImpl;
import org.jbpm.pvm.internal.util.TagBinding;
import org.jbpm.pvm.internal.util.XmlUtil;
@@ -32,9 +33,10 @@
/**
* @author Tom Baeyens
+ * @author Huisheng Xu
*/
public abstract class JpdlBinding extends TagBinding {
-
+
public JpdlBinding(String tagName) {
super(tagName, null, null);
}
@@ -47,12 +49,19 @@
public void parseName(Element element, ActivityImpl activity, Parse parse) {
String name = XmlUtil.attribute(element, "name", isNameRequired() ? parse : null);
-
- if (name!=null) {
+
+ if (name != null) {
// basic name validation
if ("".equals(name)) {
parse.addProblem(XmlUtil.errorMessageAttribute(element, "name", name, "is empty"), element);
- } else if (name.indexOf('/')!=-1) {
+ }
+
+ boolean isActivityAllowSlash = false;
+ Boolean candidateCondition = (Boolean) EnvironmentImpl.getFromCurrent("jbpm.activity.allow.slash", false);
+ if (candidateCondition != null) {
+ isActivityAllowSlash = candidateCondition.booleanValue();
+ }
+ if (!isActivityAllowSlash && name.indexOf('/') != -1) {
parse.addProblem(XmlUtil.errorMessageAttribute(element, "name", name, "contains slash (/)"), element);
}
activity.setName(name);
@@ -85,7 +94,7 @@
// transition.setName(transitionName);
//
// unresolvedTransitions.add(transition, transitionElement);
-//
+//
// jpdlParser.parseOnEvent(transitionElement, parse, transition, Event.TAKE);
// }
// }
Modified: jbpm4/trunk/modules/userguide/src/main/docbook/en/modules/ch09-Configuration.xml
===================================================================
--- jbpm4/trunk/modules/userguide/src/main/docbook/en/modules/ch09-Configuration.xml 2010-07-04 00:43:32 UTC (rev 6455)
+++ jbpm4/trunk/modules/userguide/src/main/docbook/en/modules/ch09-Configuration.xml 2010-07-04 01:07:22 UTC (rev 6456)
@@ -8,7 +8,7 @@
and replace it with the custom values.
</para>
<programlisting><jbpm-configuration>
-
+
<import resource="jbpm.businesscalendar.cfg.xml" />
...
@@ -25,20 +25,20 @@
</jbpm-configuration></programlisting>
</section>
-
+
<section>
<title>Console</title>
<para>By default the server host and port of the console
web app are respectively <literal>localhost</literal>
- and <literal>8080</literal>. It is not hard to imagine
+ and <literal>8080</literal>. It is not hard to imagine
situations where it is needed to change those defaults.
Hence they are made configurable. To customize,
- change the values of the default configuration
- (e.g. in the file "jbpm.console.cfg.xml")
+ change the values of the default configuration
+ (e.g. in the file "jbpm.console.cfg.xml")
and replace them with the values you want.</para>
<programlisting><jbpm-configuration>
-
+
<process-engine-context>
<string name="jbpm.console.server.host" value="myNewHost">
<string name="jbpm.console.server.port" value="9191">
@@ -46,13 +46,13 @@
</jbpm-configuration></programlisting>
</section>
-
+
<section>
<title>Email</title>
<para>The default configuration looks for a <literal>jbpm.mail.properties</literal>
- classpath resource containing <ulink
+ classpath resource containing <ulink
url="http://java.sun.com/products/javamail/javadocs/">JavaMail properties</ulink>.
- To send mail through a server other than local host, set the
+ To send mail through a server other than local host, set the
<literal>mail.smtp.host</literal> property in the mail properties file.</para>
<programlisting><![CDATA[mail.smtp.host=localhost
@@ -87,5 +87,34 @@
<para>Refer to the <ulink
url="http://docs.jboss.com/jbpm/v4/devguide/html_single/#mailsupport">Developer
Guide</ulink> for advanced, yet unsupported, email settings.</para>
- </section>
+ </section>
+
+ <section id="configuration-jpdl">
+ <title>Validate activity name</title>
+
+ <para>When we try to deploy a jpdl process definition,
+ the <literal>JpdlBinding</literal> will validate the name of activities contained by this process definition.
+ By default, the rule of validation as followed:
+ <itemizedlist>
+ <listitem>
+ <para>If the activity has a name, the name shouldnot be empty. The <literal>""</literal> isnot allowed to be used by the name of activity.</para>
+ </listitem>
+ <listitem>
+ <para>The name of activity cannot contain slash(/). It comes from jBPM 3.x. Because jBPM 3.x supported <literal>hierarchical names</literal>, it allowed an execution could jump from a super-state to the other level of activities. But in jBPM 4.x, there would be no chance to achieve this feature. So if someone want to use slash(/) in the name of activity. He could add this configuration parameter into jbpm.cfg.xml.</para>
+ <programlisting>
+<jbpm-configuration>
+ <import resource="jbpm.default.cfg.xml" />
+ <import resource="jbpm.tx.hibernate.cfg.xml" />
+ <import resource="jbpm.jpdl.cfg.xml" />
+
+ <process-engine-context>
+ <emphasis role="bold"><true name='jbpm.activity.allow.slash'/></emphasis>
+ </process-engine-context>
+</jbpm-configuration>
+ </programlisting>
+ <para>By using this, JpdlBinding will skip validation for slash(/) in activity name.</para>
+ </listitem>
+ </itemizedlist>
+ </para>
+ </section>
</chapter>
13 years, 12 months
- 1
- 0
JBoss JBPM SVN: r6455 - in jbpm4/trunk/modules: test-db/src/test/java/org/jbpm/test/timer and 1 other directory.
by do-not-reply＠jboss.org
Author: rebody
Date: 2010-07-03 20:43:32 -0400 (Sat, 03 Jul 2010)
New Revision: 6455
Modified:
jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/cal/Duration.java
jbpm4/trunk/modules/test-db/src/test/java/org/jbpm/test/timer/TimerTest.java
Log:
JBPM-2900 let duedate support String type EL
Modified: jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/cal/Duration.java
===================================================================
--- jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/cal/Duration.java 2010-07-03 13:07:34 UTC (rev 6454)
+++ jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/cal/Duration.java 2010-07-04 00:43:32 UTC (rev 6455)
@@ -30,6 +30,7 @@
import java.util.Map;
import java.util.regex.Pattern;
+import org.jbpm.api.Execution;
import org.jbpm.api.JbpmException;
import org.jbpm.pvm.internal.el.Expression;
import org.jbpm.pvm.internal.env.EnvironmentImpl;
@@ -125,19 +126,28 @@
baseDate = (Date) result;
} else if (result instanceof Calendar) {
baseDate = ((Calendar) result).getTime();
+ } else if (result instanceof String) {
+ baseDate = Clock.getTime();
+ int endOfELIndex = durationExpression.indexOf("}");
+ if (endOfELIndex < (durationExpression.length() - 1)) {
+ throw new JbpmException("Invalid duedate, didnot support + or - in String type EL.");
+ }
+ durationString = (String) Expression.create(durationExpression, null).evaluate((Execution) null);
} else {
throw new JbpmException("Invalid basedate type: " + baseDateEL + " is of type "
+ result.getClass().getName()
+ ". Only Date and Calendar are supported");
}
- int endOfELIndex = durationExpression.indexOf("}");
- if (endOfELIndex < (durationExpression.length() - 1)) {
- durationSeparator = durationExpression.substring(endOfELIndex + 1).trim().charAt(0);
- if (durationSeparator != '+' && durationSeparator != '-') {
- throw new JbpmException("Invalid duedate, + or - missing after EL");
+ if (durationString == null) {
+ int endOfELIndex = durationExpression.indexOf("}");
+ if (endOfELIndex < (durationExpression.length() - 1)) {
+ durationSeparator = durationExpression.substring(endOfELIndex + 1).trim().charAt(0);
+ if (durationSeparator != '+' && durationSeparator != '-') {
+ throw new JbpmException("Invalid duedate, + or - missing after EL");
+ }
+ durationString = durationExpression.substring(endOfELIndex + 1).substring(2).trim();
}
- durationString = durationExpression.substring(endOfELIndex + 1).substring(2).trim();
}
} else {
Modified: jbpm4/trunk/modules/test-db/src/test/java/org/jbpm/test/timer/TimerTest.java
===================================================================
--- jbpm4/trunk/modules/test-db/src/test/java/org/jbpm/test/timer/TimerTest.java 2010-07-03 13:07:34 UTC (rev 6454)
+++ jbpm4/trunk/modules/test-db/src/test/java/org/jbpm/test/timer/TimerTest.java 2010-07-04 00:43:32 UTC (rev 6455)
@@ -23,6 +23,7 @@
import java.util.Calendar;
import java.util.Collections;
+import java.util.Date;
import java.util.HashMap;
import java.util.Map;
@@ -40,9 +41,10 @@
* @author Tom Baeyens
* @author Ronald Van Kuijk
* @author Joram Barrez
+ * @author Huisheng Xu
*/
public class TimerTest extends JbpmTestCase {
-
+
private static final String TEST_PROCESS_CUSTOM =
"<process name='Insurance claim' key='ICL'>" +
" <start>" +
@@ -81,14 +83,14 @@
Job job = managementService.createJobQuery()
.processInstanceId(processInstance.getId())
.uniqueResult();
-
+
managementService.executeJob(job.getId());
assertProcessInstanceEnded(processInstance);
}
-
+
/**
* Test case for https://jira.jboss.org/jira/browse/JBPM-2517
- *
+ *
* In this issue, it is stated that the calculations for the timer
* will overflow if larger than 4 weeks due to integer limitations.
*/
@@ -110,20 +112,20 @@
);
ProcessInstance processInstance = executionService.startProcessInstanceByKey("theProcess");
-
+
Calendar now = Calendar.getInstance();
int currentYear = now.get(Calendar.YEAR);
Job job = managementService.createJobQuery()
.processInstanceId(processInstance.getId())
.uniqueResult();
-
+
Calendar jobDate = Calendar.getInstance();
jobDate.setTime(job.getDuedate());
-
+
assertEquals(currentYear + 10, jobDate.get(Calendar.YEAR));
}
-
+
public void testTimerELDate() {
deployJpdlXmlString(
"<process name='Insurance claim' key='ICL'>" +
@@ -140,22 +142,22 @@
" <end name='escalate' />" +
"</process>"
);
-
+
Map<String, Object> proc_vars = new HashMap<String, Object>();
Calendar cal = Calendar.getInstance();
cal.add(Calendar.DAY_OF_MONTH, 6);
proc_vars.put("proc_var", cal.getTime());
ProcessInstance processInstance = executionService.startProcessInstanceByKey("ICL", proc_vars, "82436");
-
+
Job job = managementService.createJobQuery()
.processInstanceId(processInstance.getId())
.uniqueResult();
-
+
Calendar jobDate = Calendar.getInstance();
jobDate.setTime(job.getDuedate());
-
+
assertEquals(cal.get(Calendar.DAY_OF_MONTH), jobDate.get(Calendar.DAY_OF_MONTH));
-
+
managementService.executeJob(job.getId());
assertProcessInstanceEnded(processInstance);
}
@@ -176,26 +178,59 @@
" <end name='escalate' />" +
"</process>"
);
-
+
Map<String, Object> proc_vars = new HashMap<String, Object>();
Calendar cal = Calendar.getInstance();
cal.add(Calendar.DAY_OF_MONTH, 6);
proc_vars.put("proc_var", cal);
ProcessInstance processInstance = executionService.startProcessInstanceByKey("ICL", proc_vars, "82436");
-
+
Job job = managementService.createJobQuery()
.processInstanceId(processInstance.getId())
.uniqueResult();
-
+
Calendar jobDate = Calendar.getInstance();
jobDate.setTime(job.getDuedate());
-
+
assertEquals(cal.get(Calendar.DAY_OF_MONTH), jobDate.get(Calendar.DAY_OF_MONTH));
-
+
managementService.executeJob(job.getId());
assertProcessInstanceEnded(processInstance);
}
-
+
+ public void testTimerELString() {
+ deployJpdlXmlString(
+ "<process name='Insurance claim' key='ICL'>" +
+ " <start>" +
+ " <transition to='a' />" +
+ " </start>" +
+ " <state name='a'>" +
+ " <transition to='b' />" +
+ " <transition name='timeout' to='escalate'>" +
+ " <timer duedate='#{proc_var}' />" +
+ " </transition>" +
+ " </state>" +
+ " <state name='b' />" +
+ " <end name='escalate' />" +
+ "</process>"
+ );
+
+ Map<String, Object> proc_vars = new HashMap<String, Object>();
+ proc_vars.put("proc_var", "2 minutes");
+
+ ProcessInstance processInstance = executionService.startProcessInstanceByKey("ICL", proc_vars, "82436");
+
+ Job job = managementService.createJobQuery()
+ .processInstanceId(processInstance.getId())
+ .uniqueResult();
+
+ Date jobDate = job.getDuedate();
+ assertTrue("should less than 2 minutes", jobDate.getTime() - new Date().getTime() <= 2 * 60 * 1000);
+
+ managementService.executeJob(job.getId());
+ assertProcessInstanceEnded(processInstance);
+ }
+
public void testTimerELCalendarAdd() {
deployJpdlXmlString(
"<process name='Insurance claim' key='ICL'>" +
@@ -253,7 +288,7 @@
Map<String, Object> proc_vars = new HashMap<String, Object>();
Calendar cal = Calendar.getInstance();
cal.add(Calendar.DAY_OF_MONTH, 6);
-
+
proc_vars.put("proc_var", cal);
ProcessInstance processInstance = executionService.startProcessInstanceByKey("ICL", proc_vars, "82436");
@@ -325,7 +360,7 @@
" <end name='escalate' />" +
"</process>"
);
-
+
Map<String, Object> proc_vars = new HashMap<String, Object>();
proc_vars.put("proc_var", new Long(0));
try {
@@ -360,7 +395,7 @@
fail("Should not happen, exception expected");
} catch (Exception e) {}
}
-
+
public void testTimerELSubtractPastFail() {
deployJpdlXmlString(
"<process name='Insurance claim' key='ICL'>" +
@@ -417,19 +452,19 @@
public void testTimerSignalCustom() {
deployJpdlXmlString(TEST_PROCESS_CUSTOM);
ProcessInstance processInstance = executionService.startProcessInstanceByKey("ICL");
-
+
Job async = managementService.createJobQuery().messages().processInstanceId(processInstance.getId()).uniqueResult();
managementService.executeJob(async.getId());
-
+
int beforeTimer = MyCustomWait.nrOfTimesCalled;
Job timer = managementService.createJobQuery().timers().processInstanceId(processInstance.getId()).uniqueResult();
managementService.executeJob(timer.getId());
int afterTimer = MyCustomWait.nrOfTimesCalled;
assertEquals(beforeTimer + 1, afterTimer);
-
+
assertProcessInstanceEnded(processInstance);
}
-
+
public void testTimerRepeat() {
deployJpdlXmlString(
"<process name='Insurance claim' key='ICL'>" +
@@ -455,26 +490,26 @@
Job job = managementService.createJobQuery()
.processInstanceId(processInstance.getId())
.uniqueResult();
-
+
managementService.executeJob(job.getId());
-
-
+
+
job = managementService.createJobQuery()
.processInstanceId(processInstance.getId())
.uniqueResult();
-
+
managementService.executeJob(job.getId());
-
+
processInstance = executionService.findProcessInstanceById(processInstance.getId());
String processInstanceId = processInstance.findActiveExecutionIn("a").getId();
-
+
processInstance = executionService.signalExecutionById(processInstanceId);
-
+
processInstance = executionService.signalExecutionById(processInstance.getId());
-
+
assertProcessInstanceEnded(processInstance);
}
-
+
public void testTimerELRepeat() {
deployJpdlXmlString(
"<process name='Insurance claim' key='ICL'>" +
@@ -501,30 +536,30 @@
Job job = managementService.createJobQuery()
.processInstanceId(processInstance.getId())
.uniqueResult();
-
+
managementService.executeJob(job.getId());
-
-
+
+
job = managementService.createJobQuery()
.processInstanceId(processInstance.getId())
.uniqueResult();
-
+
managementService.executeJob(job.getId());
-
+
processInstance = executionService.findProcessInstanceById(processInstance.getId());
String processInstanceId = processInstance.findActiveExecutionIn("a").getId();
-
+
processInstance = executionService.signalExecutionById(processInstanceId);
-
+
processInstance = executionService.signalExecutionById(processInstance.getId());
-
+
assertProcessInstanceEnded(processInstance);
}
public static class MyCustomWait implements ExternalActivityBehaviour, EventListener {
private static final long serialVersionUID = 1L;
-
+
static int nrOfTimesCalled;
public void execute(ActivityExecution execution) throws Exception {
13 years, 12 months
- 1
- 0
JBoss JBPM SVN: r6454 - in jbpm4/trunk/modules: test-db/src/test/java/org/jbpm/test/timer and 1 other directory.
by do-not-reply＠jboss.org
Author: swiderski.maciej
Date: 2010-07-03 09:07:34 -0400 (Sat, 03 Jul 2010)
New Revision: 6454
Modified:
jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/model/ScopeInstanceImpl.java
jbpm4/trunk/modules/test-db/src/test/java/org/jbpm/test/timer/TimerTest.java
Log:
JBPM-2890: support for expression in timer repeat attribute, applies as well to reminder
Modified: jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/model/ScopeInstanceImpl.java
===================================================================
--- jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/model/ScopeInstanceImpl.java 2010-07-03 03:49:45 UTC (rev 6453)
+++ jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/model/ScopeInstanceImpl.java 2010-07-03 13:07:34 UTC (rev 6454)
@@ -34,6 +34,7 @@
import org.jbpm.api.JbpmException;
import org.jbpm.internal.log.Log;
import org.jbpm.pvm.internal.cal.CronExpression;
+import org.jbpm.pvm.internal.el.Expression;
import org.jbpm.pvm.internal.env.EnvironmentImpl;
import org.jbpm.pvm.internal.history.HistoryEvent;
import org.jbpm.pvm.internal.history.events.VariableCreate;
@@ -318,7 +319,14 @@
if (retries!=null) {
timer.setRetries(retries);
}
- timer.setRepeat(timerDefinition.getRepeat());
+ // support for repeat attribute given as expression
+ // only if repeat is specified
+ if (timerDefinition.getRepeat() != null) {
+ Object repeatEl = Expression.create(timerDefinition.getRepeat(), Expression.LANGUAGE_UEL_VALUE).evaluate();
+ timer.setRepeat(repeatEl.toString());
+ } else {
+ timer.setRepeat(timerDefinition.getRepeat());
+ }
}
return timer;
Modified: jbpm4/trunk/modules/test-db/src/test/java/org/jbpm/test/timer/TimerTest.java
===================================================================
--- jbpm4/trunk/modules/test-db/src/test/java/org/jbpm/test/timer/TimerTest.java 2010-07-03 03:49:45 UTC (rev 6453)
+++ jbpm4/trunk/modules/test-db/src/test/java/org/jbpm/test/timer/TimerTest.java 2010-07-03 13:07:34 UTC (rev 6454)
@@ -22,6 +22,7 @@
package org.jbpm.test.timer;
import java.util.Calendar;
+import java.util.Collections;
import java.util.HashMap;
import java.util.Map;
@@ -428,7 +429,98 @@
assertProcessInstanceEnded(processInstance);
}
+
+ public void testTimerRepeat() {
+ deployJpdlXmlString(
+ "<process name='Insurance claim' key='ICL'>" +
+ " <start>" +
+ " <transition to='a' />" +
+ " </start>" +
+ " <state name='a'>" +
+ " <on event='timeout'>" +
+ " <timer duedate='20 minutes' repeat='10 seconds' />" +
+ " <event-listener class='" + MyCustomWait.class.getName() + "' />" +
+ " </on>" +
+ " <transition to='b' />" +
+ " </state>" +
+ " <state name='b' >" +
+ " <transition to='escalate' />" +
+ " </state>" +
+ " <end name='escalate' />" +
+ "</process>"
+ );
+ ProcessInstance processInstance = executionService.startProcessInstanceByKey("ICL", "82436");
+
+ Job job = managementService.createJobQuery()
+ .processInstanceId(processInstance.getId())
+ .uniqueResult();
+
+ managementService.executeJob(job.getId());
+
+
+ job = managementService.createJobQuery()
+ .processInstanceId(processInstance.getId())
+ .uniqueResult();
+
+ managementService.executeJob(job.getId());
+
+ processInstance = executionService.findProcessInstanceById(processInstance.getId());
+ String processInstanceId = processInstance.findActiveExecutionIn("a").getId();
+
+ processInstance = executionService.signalExecutionById(processInstanceId);
+
+ processInstance = executionService.signalExecutionById(processInstance.getId());
+
+ assertProcessInstanceEnded(processInstance);
+ }
+
+ public void testTimerELRepeat() {
+ deployJpdlXmlString(
+ "<process name='Insurance claim' key='ICL'>" +
+ " <start>" +
+ " <transition to='a' />" +
+ " </start>" +
+ " <state name='a'>" +
+ " <on event='timeout'>" +
+ " <timer duedate='20 minutes' repeat='#{repeat}' />" +
+ " <event-listener class='" + MyCustomWait.class.getName() + "' />" +
+ " </on>" +
+ " <transition to='b' />" +
+ " </state>" +
+ " <state name='b' >" +
+ " <transition to='escalate' />" +
+ " </state>" +
+ " <end name='escalate' />" +
+ "</process>"
+ );
+
+ Map<String, String> variables = Collections.singletonMap("repeat", "20 seconds");
+ ProcessInstance processInstance = executionService.startProcessInstanceByKey("ICL", variables, "82436");
+
+ Job job = managementService.createJobQuery()
+ .processInstanceId(processInstance.getId())
+ .uniqueResult();
+
+ managementService.executeJob(job.getId());
+
+
+ job = managementService.createJobQuery()
+ .processInstanceId(processInstance.getId())
+ .uniqueResult();
+
+ managementService.executeJob(job.getId());
+
+ processInstance = executionService.findProcessInstanceById(processInstance.getId());
+ String processInstanceId = processInstance.findActiveExecutionIn("a").getId();
+
+ processInstance = executionService.signalExecutionById(processInstanceId);
+
+ processInstance = executionService.signalExecutionById(processInstance.getId());
+
+ assertProcessInstanceEnded(processInstance);
+ }
+
public static class MyCustomWait implements ExternalActivityBehaviour, EventListener {
private static final long serialVersionUID = 1L;
13 years, 12 months
- 1
- 0
JBoss JBPM SVN: r6453 - in jbpm4/trunk/modules/pvm/src: test/java/org/jbpm/pvm/internal and 1 other directories.
by do-not-reply＠jboss.org
Author: rebody
Date: 2010-07-02 23:49:45 -0400 (Fri, 02 Jul 2010)
New Revision: 6453
Added:
jbpm4/trunk/modules/pvm/src/test/java/org/jbpm/pvm/internal/el/
jbpm4/trunk/modules/pvm/src/test/java/org/jbpm/pvm/internal/el/ResourceBundleELResovlerTest.java
Modified:
jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/el/JbpmElFactoryImpl.java
Log:
JBPM-2892 support i18n in el
Modified: jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/el/JbpmElFactoryImpl.java
===================================================================
--- jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/el/JbpmElFactoryImpl.java 2010-07-03 03:29:40 UTC (rev 6452)
+++ jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/el/JbpmElFactoryImpl.java 2010-07-03 03:49:45 UTC (rev 6453)
@@ -30,6 +30,7 @@
import javax.el.FunctionMapper;
import javax.el.ListELResolver;
import javax.el.MapELResolver;
+import javax.el.ResourceBundleELResolver;
import javax.enterprise.inject.spi.BeanManager;
import javax.naming.InitialContext;
import javax.naming.NamingException;
@@ -42,24 +43,24 @@
* @author Tom Baeyens
*/
public class JbpmElFactoryImpl extends JbpmElFactory {
-
+
private static Log log = Log.getLog(JbpmElFactoryImpl.class.getName());
-
+
Class<?> functionClass = JstlFunction.class;
-
+
/** create ElContext used during parsing time */
public ELContext createElContext() {
return createCompositeResolver(null);
}
-
+
/** create ElContext used during evaluation time related to an execution */
public ELContext createElContext(ScopeInstanceImpl scopeInstance) {
return createCompositeResolver(scopeInstance);
}
-
+
protected ELContext createCompositeResolver(ScopeInstanceImpl scopeInstance) {
CompositeELResolver compositeELResolver = new CompositeELResolver();
-
+
if (scopeInstance!=null) {
compositeELResolver.add(new JbpmConstantsElResolver(scopeInstance));
compositeELResolver.add(new JbpmVariableElResolver(scopeInstance));
@@ -69,13 +70,13 @@
if (environment!=null) {
compositeELResolver.add(new JbpmEnvironmentElResolver(environment));
}
-
+
addCdiResolver(compositeELResolver);
addBasicResolvers(compositeELResolver);
-
+
FunctionMapper functionMapper = createFunctionMapper();
-
+
return createElContext(compositeELResolver, functionMapper);
}
@@ -106,7 +107,7 @@
try {
expressionFactory = ExpressionFactory.newInstance();
} catch (NoSuchMethodError e) {
- // to support previous version of el-api
+ // to support previous version of el-api
expressionFactory = (ExpressionFactory) FactoryFinder.find(ExpressionFactory.class
.getName(),"de.odysseus.el.ExpressionFactoryImpl", null, "el.properties");
}
@@ -120,6 +121,7 @@
}
protected void addBasicResolvers(CompositeELResolver compositeELResolver) {
+ compositeELResolver.add(new ResourceBundleELResolver());
compositeELResolver.add(new MapELResolver());
compositeELResolver.add(new ListELResolver());
compositeELResolver.add(new ArrayELResolver());
Added: jbpm4/trunk/modules/pvm/src/test/java/org/jbpm/pvm/internal/el/ResourceBundleELResovlerTest.java
===================================================================
--- jbpm4/trunk/modules/pvm/src/test/java/org/jbpm/pvm/internal/el/ResourceBundleELResovlerTest.java (rev 0)
+++ jbpm4/trunk/modules/pvm/src/test/java/org/jbpm/pvm/internal/el/ResourceBundleELResovlerTest.java 2010-07-03 03:49:45 UTC (rev 6453)
@@ -0,0 +1,28 @@
+
+package org.jbpm.pvm.internal.el;
+
+import java.util.*;
+import junit.framework.*;
+import org.jbpm.pvm.internal.model.*;
+
+public class ResourceBundleELResovlerTest extends TestCase {
+ public void testResourceBundleELResovler() {
+ MyResources myResources = new MyResources();
+ ExecutionImpl execution = new ExecutionImpl();
+ execution.setVariable("resourceBundle", myResources);
+
+ Expression expr = Expression.create("#{resourceBundle['text.title']}", Expression.LANGUAGE_UEL_VALUE);
+ Object result = expr.evaluate(execution);
+
+ assertEquals("Title", result);
+ }
+
+ public static class MyResources extends ListResourceBundle {
+ public Object[][] getContents() {
+ return contents;
+ }
+ static final Object[][] contents = {
+ {"text.title", "Title"}
+ };
+ }
+}
13 years, 12 months
- 1
- 0
JBoss JBPM SVN: r6452 - in jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal: jobexecutor and 1 other directory.
by do-not-reply＠jboss.org
Author: rebody
Date: 2010-07-02 23:29:40 -0400 (Fri, 02 Jul 2010)
New Revision: 6452
Modified:
jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/cmd/ExecuteJobCmd.java
jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/jobexecutor/JobExceptionHandler.java
Log:
JBPM-2886 register jobExceptionHandler before the transaction been set as Callback only.
Modified: jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/cmd/ExecuteJobCmd.java
===================================================================
--- jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/cmd/ExecuteJobCmd.java 2010-07-03 02:42:45 UTC (rev 6451)
+++ jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/cmd/ExecuteJobCmd.java 2010-07-03 03:29:40 UTC (rev 6452)
@@ -36,15 +36,18 @@
/**
* @author Tom Baeyens
+ * @author Huisheng Xu
*/
public class ExecuteJobCmd extends AbstractCommand<Job> {
private static final long serialVersionUID = 1L;
private static final Log log = Log.getLog(ExecuteJobCmd.class.getName());
-
+
protected Long jobDbid;
+ protected JobExceptionHandler jobExceptionHandler;
+
public ExecuteJobCmd(String jobId) {
if (jobId==null) {
throw new JbpmException("jobId is null");
@@ -58,62 +61,80 @@
public Job execute(Environment environmentInterface) throws Exception {
EnvironmentImpl environment = (EnvironmentImpl) environmentInterface;
- DbSession dbSession = environment.get(DbSession.class);
- if (dbSession==null) {
- throw new JbpmException("no db-session configured");
- }
+ DbSession dbSession = environment.get(DbSession.class);
+ if (dbSession == null) {
+ throw new JbpmException("no db-session configured");
+ }
JobImpl job = dbSession.get(JobImpl.class, jobDbid);
- // in case of decision jobs, the job might have been deleted
- // before we execute it (they are in a list)
- if (job != null) {
- JobContext jobContext = new JobContext(job);
+ // in case of decision jobs, the job might have been deleted
+ // before we execute it (they are in a list)
+ if (job != null) {
+ this.registerJobExceptionHandler(environment, job);
+
+ JobContext jobContext = new JobContext(job);
environment.setContext(jobContext);
- try {
- log.debug("executing job "+job+"...");
- Boolean deleteJob = job.execute(environment);
- log.debug("executed job "+job);
- if (deleteJob) {
- dbSession.delete(job);
- }
+ try {
+ log.debug("executing job " + job + "...");
+ Boolean deleteJob = job.execute(environment);
+ log.debug("executed job " + job);
+ if (deleteJob) {
+ dbSession.delete(job);
+ }
- // if this job is locked too long, it could be unlocked by the lockmonitor and
- // executed by another thread.
- Date lockExpirationDate = job.getLockExpirationTime();
- // can be null if it was rescheduled
- if (lockExpirationDate != null) {
- long lockExpiration = lockExpirationDate.getTime();
- long currentTime = System.currentTimeMillis();
- if (currentTime>lockExpiration) {
- throw new JbpmException("job took too long: lock expired "+(currentTime-lockExpiration)+"ms ago");
- }
- }
- } catch (Exception exception) {
- log.error("exception while executing '"+job+"'", exception);
- handleJobExecutionException(environment, job, exception);
- } finally {
- environment.removeContext(jobContext);
- }
+ // if this job is locked too long, it could be unlocked by the lockmonitor and
+ // executed by another thread.
+ Date lockExpirationDate = job.getLockExpirationTime();
+ // can be null if it was rescheduled
+ if (lockExpirationDate != null) {
+ long lockExpiration = lockExpirationDate.getTime();
+ long currentTime = System.currentTimeMillis();
+ if (currentTime>lockExpiration) {
+ throw new JbpmException("job took too long: lock expired "
+ + (currentTime - lockExpiration) + "ms ago");
+ }
+ }
+ } catch (Exception exception) {
+ log.error("exception while executing '" + job + "'", exception);
+ handleJobExecutionException(exception);
+ } finally {
+ environment.removeContext(jobContext);
+ }
- } else {
- log.debug("job " + jobDbid + " no longer exists");
- }
+ } else {
+ log.debug("job " + jobDbid + " no longer exists");
+ }
return job;
}
- /** This transaction will be marked for rollback. A command will be associated with the
- * Transaction.EVENT_AFTERCOMPLETION (after the job locks of the current transaction are
- * released). Then the command will update the job with the exception details in a separate
+ /** This transaction will be marked for rollback. A command will be associated with the
+ * Transaction.EVENT_AFTERCOMPLETION (after the job locks of the current transaction are
+ * released). Then the command will update the job with the exception details in a separate
* transaction. */
- protected void handleJobExecutionException(Environment environment, JobImpl job, Exception exception) {
- Transaction transaction = environment.get(Transaction.class);
- CommandService commandService = (CommandService) environment.get(CommandService.NAME_NEW_TX_REQUIRED_COMMAND_SERVICE);
- JobExceptionHandler jobExceptionHandler = new JobExceptionHandler(job.getDbid(), exception, commandService);
- transaction.registerSynchronization(jobExceptionHandler);
-
+ protected void handleJobExecutionException(Exception exception) {
+ if (jobExceptionHandler != null) {
+ jobExceptionHandler.setException(exception);
+ } else {
+ log.warn("jobExceptionHandler hasnot initialized for exception : " + exception.getMessage());
+ }
+
if (exception instanceof RuntimeException) {
throw (RuntimeException) exception;
}
- throw new JbpmException("job failed: "+exception.getMessage(), exception);
+ throw new JbpmException("job failed: " + exception.getMessage(), exception);
}
+
+ protected void registerJobExceptionHandler(Environment environment, JobImpl job) {
+ Transaction transaction = environment.get(Transaction.class);
+ CommandService commandService = (CommandService) environment
+ .get(CommandService.NAME_NEW_TX_REQUIRED_COMMAND_SERVICE);
+
+ jobExceptionHandler = new JobExceptionHandler(job.getDbid(), commandService);
+ try {
+ transaction.registerSynchronization(jobExceptionHandler);
+ } catch(Exception ex) {
+ log.warn("cannot register synchronization on current transaction : " + ex.getMessage()
+ + " job : " + job.getDbid());
+ }
+ }
}
Modified: jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/jobexecutor/JobExceptionHandler.java
===================================================================
--- jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/jobexecutor/JobExceptionHandler.java 2010-07-03 02:42:45 UTC (rev 6451)
+++ jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/jobexecutor/JobExceptionHandler.java 2010-07-03 03:29:40 UTC (rev 6452)
@@ -35,32 +35,37 @@
import org.jbpm.pvm.internal.session.DbSession;
import org.jbpm.pvm.internal.tx.Transaction;
-/**
+/**
* @author Tom Baeyens
*/
public class JobExceptionHandler implements Synchronization, Command<Object> {
-
+
private static final Log log = Log.getLog(JobExceptionHandler.class.getName());
private static final long serialVersionUID = 1L;
-
+
protected CommandService commandService;
protected long jobDbid;
protected Throwable exception;
-
- public JobExceptionHandler(long jobDbid, Throwable exception, CommandService commandService) {
+
+ public JobExceptionHandler(long jobDbid, CommandService commandService) {
this.commandService = commandService;
this.jobDbid = jobDbid;
- this.exception = exception;
}
-
+ public void setException(Throwable exception) {
+ this.exception = exception;
+ }
+
public void beforeCompletion() {
}
public void afterCompletion(int status) {
- // after the transaction rolled back,
- // execute this job exception handler object as a command with
- // the command service so that this gets done in a separate
+ if (exception == null) {
+ return;
+ }
+ // after the transaction rolled back,
+ // execute this job exception handler object as a command with
+ // the command service so that this gets done in a separate
// transaction
log.debug("starting new transaction for handling job exception");
commandService.execute(this);
@@ -69,7 +74,7 @@
public Object execute(Environment environment) throws Exception {
log.debug("handling job "+jobDbid+" exception: "+exception.getMessage());
-
+
// load the job from the db
DbSession dbSession = environment.get(DbSession.class);
if (dbSession==null) {
@@ -85,8 +90,8 @@
log.debug("decrementing retries to "+decrementedRetries+" for "+job);
job.release();
job.setRetries(decrementedRetries);
- job.setException(sw.toString());
-
+ job.setException(sw.toString());
+
// notify the job executor after the transaction is completed
Transaction transaction = environment.get(Transaction.class);
JobExecutor jobExecutor = environment.get(JobExecutor.class);
13 years, 12 months
- 1
- 0
JBoss JBPM SVN: r6451 - in jbpm4/trunk/modules: jpdl/src/main/java/org/jbpm/jpdl/internal/activity and 7 other directories.
by do-not-reply＠jboss.org
Author: rebody
Date: 2010-07-02 22:42:45 -0400 (Fri, 02 Jul 2010)
New Revision: 6451
Modified:
jbpm4/trunk/modules/bpmn/src/main/java/org/jbpm/bpmn/flownodes/ScriptTaskActivity.java
jbpm4/trunk/modules/jpdl/src/main/java/org/jbpm/jpdl/internal/activity/JmsActivity.java
jbpm4/trunk/modules/jpdl/src/main/java/org/jbpm/jpdl/internal/activity/ScriptActivity.java
jbpm4/trunk/modules/jpdl/src/test/java/org/jbpm/jpdl/parsing/TaskParsingTest.java
jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/cal/Duration.java
jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/el/Expression.java
jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/el/ScriptExpression.java
jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/el/StaticTextExpression.java
jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/el/UelMethodExpression.java
jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/el/UelValueExpression.java
jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/email/impl/MailProducerImpl.java
jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/model/ExecutionImpl.java
jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/model/ExpressionCondition.java
jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/model/VariableOutDefinitionSet.java
jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/wire/descriptor/ExpressionDescriptor.java
jbpm4/trunk/modules/test-db/src/test/java/org/jbpm/test/variables/VariableExpressionTest.java
Log:
JBPM-1209 refactor el
Modified: jbpm4/trunk/modules/bpmn/src/main/java/org/jbpm/bpmn/flownodes/ScriptTaskActivity.java
===================================================================
--- jbpm4/trunk/modules/bpmn/src/main/java/org/jbpm/bpmn/flownodes/ScriptTaskActivity.java 2010-07-02 22:39:17 UTC (rev 6450)
+++ jbpm4/trunk/modules/bpmn/src/main/java/org/jbpm/bpmn/flownodes/ScriptTaskActivity.java 2010-07-03 02:42:45 UTC (rev 6451)
@@ -24,41 +24,41 @@
import org.jbpm.api.JbpmException;
import org.jbpm.api.model.OpenExecution;
import org.jbpm.pvm.internal.env.EnvironmentImpl;
-import org.jbpm.pvm.internal.script.ScriptManager;
+import org.jbpm.pvm.internal.el.Expression;
+/**
+ * @author Huisheng Xu
+ */
public class ScriptTaskActivity extends BpmnAutomaticActivity {
- private static final long serialVersionUID = 1L;
+ private static final long serialVersionUID = 1L;
- private String language;
+ private String language;
- private String script;
+ private String script;
- public void perform(OpenExecution execution) {
- try {
+ public void perform(OpenExecution execution) {
+ try {
+ Expression.create(script, language).evaluate(execution);
+ } catch (Exception e) {
+ throw new JbpmException("couldn't run script: " + e.getMessage(), e);
+ }
+ }
- ScriptManager scriptManager = EnvironmentImpl.getFromCurrent(ScriptManager.class);
- scriptManager.evaluateScript(script, language);
+ public String getLanguage() {
+ return language;
+ }
- } catch (Exception e) {
- throw new JbpmException("couldn't run script: " + e.getMessage(), e);
- }
- }
+ public void setLanguage(String language) {
+ this.language = language;
+ }
- public String getLanguage() {
- return language;
- }
+ public String getScript() {
+ return script;
+ }
- public void setLanguage(String language) {
- this.language = language;
- }
+ public void setScript(String script) {
+ this.script = script;
+ }
- public String getScript() {
- return script;
- }
-
- public void setScript(String script) {
- this.script = script;
- }
-
}
Modified: jbpm4/trunk/modules/jpdl/src/main/java/org/jbpm/jpdl/internal/activity/JmsActivity.java
===================================================================
--- jbpm4/trunk/modules/jpdl/src/main/java/org/jbpm/jpdl/internal/activity/JmsActivity.java 2010-07-02 22:39:17 UTC (rev 6450)
+++ jbpm4/trunk/modules/jpdl/src/main/java/org/jbpm/jpdl/internal/activity/JmsActivity.java 2010-07-03 02:42:45 UTC (rev 6451)
@@ -55,7 +55,6 @@
import org.jbpm.internal.log.Log;
import org.jbpm.pvm.internal.el.Expression;
import org.jbpm.pvm.internal.model.ExecutionImpl;
-import org.jbpm.pvm.internal.script.ScriptManager;
import org.jbpm.pvm.internal.wire.Descriptor;
import org.jbpm.pvm.internal.wire.WireContext;
import org.jbpm.pvm.internal.wire.descriptor.MapDescriptor;
Modified: jbpm4/trunk/modules/jpdl/src/main/java/org/jbpm/jpdl/internal/activity/ScriptActivity.java
===================================================================
--- jbpm4/trunk/modules/jpdl/src/main/java/org/jbpm/jpdl/internal/activity/ScriptActivity.java 2010-07-02 22:39:17 UTC (rev 6450)
+++ jbpm4/trunk/modules/jpdl/src/main/java/org/jbpm/jpdl/internal/activity/ScriptActivity.java 2010-07-03 02:42:45 UTC (rev 6451)
@@ -23,24 +23,24 @@
import org.jbpm.api.model.OpenExecution;
import org.jbpm.pvm.internal.env.EnvironmentImpl;
-import org.jbpm.pvm.internal.script.ScriptManager;
+import org.jbpm.pvm.internal.el.Expression;
/**
* @author Tom Baeyens
+ * @author Huisheng Xu
*/
public class ScriptActivity extends JpdlAutomaticActivity {
private static final long serialVersionUID = 1L;
-
+
protected String script;
protected String language;
protected String variableName;
public void perform(OpenExecution execution) {
- ScriptManager scriptManager = EnvironmentImpl.getFromCurrent(ScriptManager.class);
- Object returnValue = scriptManager.evaluateScript(script, language);
-
- if (variableName!=null) {
+ Object returnValue = Expression.create(script, language).evaluate(execution);
+
+ if (variableName != null) {
execution.setVariable(variableName, returnValue);
}
}
Modified: jbpm4/trunk/modules/jpdl/src/test/java/org/jbpm/jpdl/parsing/TaskParsingTest.java
===================================================================
--- jbpm4/trunk/modules/jpdl/src/test/java/org/jbpm/jpdl/parsing/TaskParsingTest.java 2010-07-02 22:39:17 UTC (rev 6450)
+++ jbpm4/trunk/modules/jpdl/src/test/java/org/jbpm/jpdl/parsing/TaskParsingTest.java 2010-07-03 02:42:45 UTC (rev 6451)
@@ -5,10 +5,12 @@
import org.jbpm.jpdl.internal.activity.TaskActivity;
import org.jbpm.pvm.internal.client.ClientProcessDefinition;
import org.jbpm.pvm.internal.el.Expression;
-import org.jbpm.pvm.internal.el.StaticTextExpression;
import org.jbpm.pvm.internal.model.ActivityImpl;
import org.jbpm.pvm.internal.task.TaskDefinitionImpl;
+/**
+ * @author Huisheng Xu
+ */
public class TaskParsingTest extends JpdlParseTestCase {
public void testTaskParse() {
@@ -33,8 +35,8 @@
TaskDefinitionImpl taskDefinition = taskActivity.getTaskDefinition();
// check for properties not previously parsed
- StaticTextExpression descriptionExpression = (StaticTextExpression) taskDefinition.getDescription();
- assertEquals("first task", descriptionExpression.getText());
+ Expression descriptionExpression = taskDefinition.getDescription();
+ assertEquals("first task", descriptionExpression.getExpressionString());
assertEquals(3, taskDefinition.getPriority());
assertEquals("aForm", taskDefinition.getFormResourceName());
assertEquals("1 day", taskDefinition.getDueDateDescription());
Modified: jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/cal/Duration.java
===================================================================
--- jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/cal/Duration.java 2010-07-02 22:39:17 UTC (rev 6450)
+++ jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/cal/Duration.java 2010-07-03 02:42:45 UTC (rev 6451)
@@ -31,26 +31,28 @@
import java.util.regex.Pattern;
import org.jbpm.api.JbpmException;
+import org.jbpm.pvm.internal.el.Expression;
import org.jbpm.pvm.internal.env.EnvironmentImpl;
-import org.jbpm.pvm.internal.script.ScriptManager;
import org.jbpm.pvm.internal.util.Clock;
/**
* represents a time duration.
- *
- * <p>With the constructor {link {@link #Duration(String)} you can create a
+ *
+ * <p>With the constructor {link {@link #Duration(String)} you can create a
* Duration from a text representation. The syntax is as follows
* </p>
- *
+ *
* <pre>
* duration = part [',' part | 'and' part]*
* part = number ['business'] unit
* number = (0..9)+
* unit = (y|year|years|month|months|w|week|weeks|d|day|days|h|hour|hours|min|minute|minutes|s|sec|second|seconds|milli|millis|millisecond|milliseconds)
* </pre>
- *
+ *
* <p>Duration is immutable.
* </p>
+ *
+ * @author Huisheng Xu
*/
public class Duration implements Serializable {
@@ -65,12 +67,12 @@
protected int weeks;
protected int months;
protected int years;
-
+
private final static String dateFormat = "yyyy-MM-dd HH:mm:ss";
-
+
private static final Pattern dateDurationPattern = Pattern.compile("\\s*(#\\{.+\\})\\s*"
+ "(?:(\\+|-)\\s*(\\d+\\s+(?:business\\s+)?\\w+))?\\s*");
-
+
private static final Pattern durationPattern = Pattern.compile("\\s*(\\d+\\s+(?:business\\s+)?"
+ "\\w+)\\s*");
@@ -78,13 +80,13 @@
protected Duration() {
}
- /** parses the duration from a text
- *
+ /** parses the duration from a text
+ *
* duration = part [',' part | 'and' part]*
* part = number ['business'] unit
* number = (0..9)+
* unit = (y|year|years|month|months|w|week|weeks|d|day|days|h|hour|hours|min|minute|minutes|s|sec|second|seconds|milli|millis|millisecond|milliseconds)
- *
+ *
* @throws JbpmException if the parsing is unsuccessful
*/
public Duration(String text) {
@@ -93,23 +95,22 @@
for (String part: splitInParts(text)) {
parsePart(part);
}
-
+
isBusinessTime = text.indexOf("business")!=-1;
}
-
+
public static boolean isValidExpression(String durationExpression) {
try {
- new Duration(durationExpression);
+ new Duration(durationExpression);
} catch (JbpmException e) {
return false;
}
return true;
}
-
+
public static Date calculateDueDate(String durationExpression) {
Date duedate = null;
if (durationExpression != null) {
- ScriptManager scriptManager = ScriptManager.getScriptManager();
Date baseDate;
String durationString = null;
@@ -118,14 +119,15 @@
if (durationExpression.startsWith("#")) {
String baseDateEL = durationExpression.substring(0, durationExpression.indexOf("}") + 1);
- Object result = scriptManager.evaluateExpression(baseDateEL, null);
+ Object result = Expression.create(baseDateEL).evaluate();
if (result instanceof Date) {
baseDate = (Date) result;
} else if (result instanceof Calendar) {
baseDate = ((Calendar) result).getTime();
} else {
- throw new JbpmException("Invalid basedate type: " + baseDateEL + " is of type " + result.getClass().getName()
+ throw new JbpmException("Invalid basedate type: " + baseDateEL + " is of type "
+ + result.getClass().getName()
+ ". Only Date and Calendar are supported");
}
@@ -173,40 +175,40 @@
this.months = months;
this.years = years;
}
-
+
private List<String> splitInParts(String text) {
List<String> parts = new ArrayList<String>(2);
while (text!=null) {
int commaIndex = text.indexOf(',');
int andIndex = text.indexOf(" and ");
- if ( ( (commaIndex==-1)
+ if ( ( (commaIndex==-1)
&& (andIndex!=-1)
- )
- ||
- ( ( (commaIndex!=-1)
+ )
+ ||
+ ( ( (commaIndex!=-1)
&& (andIndex!=-1)
- )
+ )
&& (andIndex<commaIndex)
)
) {
String part = text.substring(0, andIndex).trim();
parts.add(part);
text = text.substring(andIndex+5);
-
- } else if ( ( (commaIndex!=-1)
+
+ } else if ( ( (commaIndex!=-1)
&& (andIndex==-1)
- )
- ||
- ( ( (commaIndex!=-1)
+ )
+ ||
+ ( ( (commaIndex!=-1)
&& (andIndex!=-1)
- )
+ )
&& (andIndex>commaIndex)
)
) {
String part = text.substring(0, commaIndex).trim();
parts.add(part);
text = text.substring(commaIndex+1);
-
+
} else {
parts.add(text.trim());
text = null;
@@ -224,7 +226,7 @@
String quantityText = part.substring(0, spaceIndex).trim();
spaceIndex = part.lastIndexOf(' ');
String unitText = part.substring(spaceIndex+1).trim().toLowerCase();
-
+
int quantity;
try {
quantity = Integer.parseInt(quantityText);
@@ -237,7 +239,7 @@
}
fieldSetter.set(this, quantity);
}
-
+
interface FieldSetter {
void set(Duration duration, int quantity);
}
@@ -325,7 +327,7 @@
fieldSetters.put("year", fieldSetter);
fieldSetters.put("years", fieldSetter);
}
-
+
public int getDays() {
return days;
}
@@ -353,7 +355,7 @@
public int getSeconds() {
return seconds;
}
-
+
public int getWeeks() {
return weeks;
}
Modified: jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/el/Expression.java
===================================================================
--- jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/el/Expression.java 2010-07-02 22:39:17 UTC (rev 6450)
+++ jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/el/Expression.java 2010-07-03 02:42:45 UTC (rev 6451)
@@ -35,8 +35,9 @@
import org.jbpm.pvm.internal.model.ScopeInstanceImpl;
/** handles all expression resolving
- *
+ *
* @author Tom Baeyens
+ * @author Huisheng Xu
*/
public abstract class Expression implements Serializable {
@@ -49,12 +50,16 @@
private static ExpressionFactory expressionFactory;
private static ELContext elContext;
+ public static Expression create(String expressionText) {
+ return create(expressionText, null);
+ }
+
public static Expression create(String expressionText, String language) {
// if there is an expr specified
if (expressionText==null) {
throw new JbpmException("expressionText is null");
}
-
+
if (language==null || language.startsWith(LANGUAGE_UEL)) {
if (expressionText.indexOf('{')==-1) {
return new StaticTextExpression(expressionText);
@@ -64,26 +69,28 @@
// by default, expr is interpreted as a value expression
if (language==null || LANGUAGE_UEL_VALUE.equals(language)) {
try {
- ValueExpression valueExpression = expressionFactory.createValueExpression(elContext, expressionText, Object.class);
-
+ ValueExpression valueExpression = expressionFactory
+ .createValueExpression(elContext, expressionText, Object.class);
+
return new UelValueExpression(valueExpression);
-
+
// if the expr is not a valid value expr...
} catch (ELException e) {
- // ... and the expr-type was not specified
+ // ... and the expr-type was not specified
if (language==null) {
// then try to parse it as a method expression
language = LANGUAGE_UEL_METHOD;
}
- }
- }
+ }
+ }
if (LANGUAGE_UEL_METHOD.equals(language)) {
- MethodExpression methodExpression = expressionFactory.createMethodExpression(elContext, expressionText, null, new Class<?>[]{});
+ MethodExpression methodExpression = expressionFactory
+ .createMethodExpression(elContext, expressionText, null, new Class<?>[]{});
return new UelMethodExpression(methodExpression);
}
- }
+ }
return new ScriptExpression(expressionText, language);
}
@@ -96,7 +103,11 @@
}
// runtime evaluation ///////////////////////////////////////////////////////
-
+
+ public Object evaluate() {
+ return evaluateInScope(null);
+ }
+
public Object evaluate(Execution execution) {
return evaluateInScope((ScopeInstanceImpl)execution);
}
@@ -104,7 +115,7 @@
public Object evaluate(Task task) {
return evaluateInScope((ScopeInstanceImpl)task);
}
-
+
public abstract Object evaluateInScope(ScopeInstanceImpl scopeInstance);
protected ELContext getElContext(ScopeInstanceImpl scopeInstance) {
@@ -119,4 +130,8 @@
}
return elContext;
}
+
+ public abstract String getExpressionString();
+
+ public abstract boolean isLiteralText();
}
Modified: jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/el/ScriptExpression.java
===================================================================
--- jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/el/ScriptExpression.java 2010-07-02 22:39:17 UTC (rev 6450)
+++ jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/el/ScriptExpression.java 2010-07-03 02:42:45 UTC (rev 6451)
@@ -26,15 +26,18 @@
/**
+ * This is script expression, it will use ScriptManager to evaluate the expr by specified language.
+ *
* @author Tom Baeyens
+ * @author Huisheng Xu
*/
public class ScriptExpression extends Expression {
private static final long serialVersionUID = 1L;
-
+
protected String expressionText;
protected String language;
-
+
public ScriptExpression(String expressionText, String language) {
this.expressionText = expressionText;
this.language = language;
@@ -44,4 +47,12 @@
ScriptManager scriptManager = ScriptManager.getScriptManager();
return scriptManager.evaluateExpression(expressionText, language);
}
+
+ public String getExpressionString() {
+ return expressionText;
+ }
+
+ public boolean isLiteralText() {
+ return false;
+ }
}
Modified: jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/el/StaticTextExpression.java
===================================================================
--- jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/el/StaticTextExpression.java 2010-07-02 22:39:17 UTC (rev 6450)
+++ jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/el/StaticTextExpression.java 2010-07-03 02:42:45 UTC (rev 6451)
@@ -25,14 +25,17 @@
/**
+ * This is a static text expression, didn't contains any script expression.
+ *
* @author Tom Baeyens
+ * @author Huiheng Xu
*/
public class StaticTextExpression extends Expression {
private static final long serialVersionUID = 1L;
String text;
-
+
public StaticTextExpression(String text) {
this.text = text;
}
@@ -41,7 +44,11 @@
return text;
}
- public String getText() {
+ public String getExpressionString() {
return text;
}
+
+ public boolean isLiteralText() {
+ return true;
+ }
}
Modified: jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/el/UelMethodExpression.java
===================================================================
--- jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/el/UelMethodExpression.java 2010-07-02 22:39:17 UTC (rev 6450)
+++ jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/el/UelMethodExpression.java 2010-07-03 02:42:45 UTC (rev 6451)
@@ -29,11 +29,12 @@
/**
* @author Tom Baeyens
+ * @author Huisheng Xu
*/
public class UelMethodExpression extends Expression {
private static final long serialVersionUID = 1L;
-
+
protected MethodExpression methodExpression;
public UelMethodExpression(MethodExpression methodExpression) {
@@ -44,4 +45,12 @@
ELContext elContext = getElContext(scopeInstance);
return methodExpression.invoke(elContext, null);
}
+
+ public String getExpressionString() {
+ return methodExpression.getExpressionString();
+ }
+
+ public boolean isLiteralText() {
+ return false;
+ }
}
Modified: jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/el/UelValueExpression.java
===================================================================
--- jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/el/UelValueExpression.java 2010-07-02 22:39:17 UTC (rev 6450)
+++ jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/el/UelValueExpression.java 2010-07-03 02:42:45 UTC (rev 6451)
@@ -32,11 +32,12 @@
/**
* @author Tom Baeyens
+ * @author Huisheng Xu
*/
public class UelValueExpression extends Expression {
private static final long serialVersionUID = 1L;
-
+
protected ValueExpression valueExpression;
public UelValueExpression(ValueExpression valueExpression) {
@@ -54,14 +55,22 @@
public void setValue(Task task, Object value) {
setValue((ScopeInstanceImpl)task, value);
}
-
+
public void setValue(Execution execution, Object value) {
setValue((ScopeInstanceImpl)execution, value);
}
-
+
public void setValue(ScopeInstanceImpl scopeInstance, Object value) {
ELContext elContext = getElContext(scopeInstance);
valueExpression.setValue(elContext, value);
}
+ public String getExpressionString() {
+ return valueExpression.getExpressionString();
+ }
+
+ public boolean isLiteralText() {
+ return false;
+ }
+
}
Modified: jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/email/impl/MailProducerImpl.java
===================================================================
--- jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/email/impl/MailProducerImpl.java 2010-07-02 22:39:17 UTC (rev 6450)
+++ jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/email/impl/MailProducerImpl.java 2010-07-03 02:42:45 UTC (rev 6451)
@@ -49,16 +49,17 @@
import org.jbpm.api.JbpmException;
import org.jbpm.api.identity.Group;
import org.jbpm.api.identity.User;
+import org.jbpm.pvm.internal.el.Expression;
import org.jbpm.pvm.internal.email.spi.AddressResolver;
import org.jbpm.pvm.internal.email.spi.MailProducer;
import org.jbpm.pvm.internal.env.EnvironmentImpl;
import org.jbpm.pvm.internal.identity.spi.IdentitySession;
-import org.jbpm.pvm.internal.script.ScriptManager;
/**
* Default mail producer.
- *
+ *
* @author Alejandro Guizar
+ * @author Huisheng Xu
*/
public class MailProducerImpl implements MailProducer, Serializable {
@@ -96,7 +97,7 @@
* Fills the <code>from</code> attribute of the given email. The sender addresses are an
* optional element in the mail template. If absent, each mail server supplies the current
* user's email address.
- *
+ *
* @see {@link InternetAddress#getLocalAddress(Session)}
*/
protected void fillFrom(Execution execution, Message email) throws MessagingException {
@@ -138,8 +139,7 @@
}
private <T> T evaluateExpression(String expression, Class<T> type) {
- ScriptManager scriptManager = ScriptManager.getScriptManager();
- Object value = scriptManager.evaluateExpression(expression, template.getLanguage());
+ Object value = Expression.create(expression, template.getLanguage()).evaluate();
return type.cast(value);
}
@@ -265,7 +265,7 @@
// obtain interface to data
DataHandler dataHandler = createDataHandler(attachmentTemplate);
attachmentPart.setDataHandler(dataHandler);
-
+
// resolve file name
String name = attachmentTemplate.getName();
if (name != null) {
Modified: jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/model/ExecutionImpl.java
===================================================================
--- jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/model/ExecutionImpl.java 2010-07-02 22:39:17 UTC (rev 6450)
+++ jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/model/ExecutionImpl.java 2010-07-03 02:42:45 UTC (rev 6451)
@@ -66,7 +66,6 @@
import org.jbpm.pvm.internal.model.op.AtomicOperation;
import org.jbpm.pvm.internal.model.op.MoveToChildActivity;
import org.jbpm.pvm.internal.model.op.Signal;
-import org.jbpm.pvm.internal.script.ScriptManager;
import org.jbpm.pvm.internal.session.DbSession;
import org.jbpm.pvm.internal.session.MessageSession;
import org.jbpm.pvm.internal.session.RepositorySession;
@@ -82,6 +81,7 @@
/**
* @author Tom Baeyens
+ * @author Huisheng Xu
*/
public class ExecutionImpl extends ScopeInstanceImpl implements ClientProcessInstance,
ActivityExecution, EventListenerExecution {
@@ -89,13 +89,13 @@
private static final long serialVersionUID = 1L;
private static final Log log = Log.getLog(ExecutionImpl.class.getName());
-
- /** an optional name for this execution. can be used to
- * differentiate concurrent paths of execution like e.g.
+
+ /** an optional name for this execution. can be used to
+ * differentiate concurrent paths of execution like e.g.
* the 'shipping' and 'billing' paths. */
protected String name;
- /** a key for this execution. typically this is an externally provided reference
+ /** a key for this execution. typically this is an externally provided reference
* that is unique within the scope of the process definition. */
protected String key;
@@ -109,10 +109,10 @@
* concurrency. */
protected ExecutionImpl parent;
protected ExecutionImpl processInstance;
-
- /** the super process link in case this is a sub process execution */
+
+ /** the super process link in case this is a sub process execution */
protected ExecutionImpl superProcessExecution;
-
+
/** the sub process link in case of sub process execution */
protected ExecutionImpl subProcessInstance;
@@ -121,7 +121,7 @@
/** reference to the current activity instance history record */
protected Long historyActivityInstanceDbid;
-
+
/** start time of the activity for history purposes (not persisted) */
protected Date historyActivityStart;
@@ -130,10 +130,10 @@
protected Map<String, Variable> systemVariables = new HashMap<String, Variable>();
// persistent indicators of the current position ////////////////////////////
-
+
/** persistent process definition reference */
protected String processDefinitionId;
-
+
/** persistent activity reference */
protected String activityName;
@@ -141,7 +141,7 @@
/** transient cached process definition. persistence is managed in {@link #processDefinitionId} */
protected ProcessDefinitionImpl processDefinition;
-
+
/** transient cached current activity pointer. persistence is managed in {@link #activityName} */
private ActivityImpl activity;
@@ -157,7 +157,7 @@
protected ObservableElementImpl eventSource;
// cached named executions //////////////////////////////////////////////////
-
+
/** caches the child executions by execution name. This member might be
* null and is only created from the executions in case its needed. Note
* that not all executions are forced to have a name and duplicates are allowed.
@@ -175,7 +175,7 @@
protected Propagation propagation;
// construction /////////////////////////////////////////////////////////////
-
+
public void initializeProcessInstance(ProcessDefinitionImpl processDefinition, String key) {
setProcessDefinition(processDefinition);
setActivity(processDefinition.getInitial());
@@ -184,7 +184,7 @@
this.key = key;
save();
-
+
HistoryEvent.fire(new ProcessInstanceCreate(), this);
}
@@ -211,7 +211,7 @@
}
this.state = STATE_ACTIVE_ROOT;
ExecutionImpl scopedExecution = initializeScopes();
-
+
fire(Event.START, getProcessDefinition());
if (getActivity()!=null) {
scopedExecution.performAtomicOperation(AtomicOperation.EXECUTE_ACTIVITY);
@@ -223,7 +223,7 @@
ActivityImpl initial = getProcessDefinition().getInitial();
ExecutionImpl scopedExecution = null;
-
+
if (initial!=null) {
enteredActivities.add(initial);
ActivityImpl parentActivity = initial.getParentActivity();
@@ -231,19 +231,19 @@
enteredActivities.addFirst(parentActivity);
parentActivity = parentActivity.getParentActivity();
}
-
+
scopedExecution = this;
initializeVariables(getProcessDefinition(), this);
initializeTimers(getProcessDefinition());
-
+
for (ActivityImpl enteredActivity: enteredActivities) {
if (enteredActivity.isLocalScope()) {
scopedExecution.setActivity(enteredActivity);
scopedExecution = scopedExecution.createScope(enteredActivity);
}
}
-
+
scopedExecution.setActivity(initial);
}
return scopedExecution;
@@ -251,29 +251,29 @@
public ExecutionImpl createScope(ScopeElementImpl scope) {
ExecutionImpl child = createExecution(scope.getName());
-
+
setState(STATE_INACTIVE_SCOPE);
child.setState(STATE_ACTIVE_ROOT);
-
+
// copy the current state from the child execution to the parent execution
child.setActivity(getActivity());
child.setTransition(getTransition());
child.setPropagation(getPropagation());
-
+
child.initializeVariables(scope, this);
child.initializeTimers(scope);
-
+
return child;
}
-
+
public ExecutionImpl destroyScope(CompositeElementImpl scope) {
destroyTimers(scope);
-
+
// copy the current state from the child execution to the parent execution
parent.setActivity(getActivity());
parent.setTransition(getTransition());
parent.setPropagation(getPropagation());
-
+
ExecutionImpl parentsParent = parent.getParent();
if (parentsParent!=null
&& STATE_INACTIVE_CONCURRENT_ROOT.equals(parentsParent.getState())) {
@@ -282,16 +282,16 @@
else {
parent.setState(STATE_ACTIVE_ROOT);
}
-
- // capture the parent execution cause the
+
+ // capture the parent execution cause the
// subsequent invocation of end() will set the parent to null
ExecutionImpl parent = this.parent;
-
+
end();
return parent;
}
-
+
@Override
protected void destroyTimers(CompositeElementImpl scope) {
TimerSession timerSession = EnvironmentImpl.getFromCurrent(TimerSession.class, false);
@@ -319,7 +319,7 @@
}
return "execution";
}
-
+
// execution method : end ///////////////////////////////////////////////////
public void end() {
@@ -341,7 +341,7 @@
|| state.equals(STATE_ASYNC)) {
throw new JbpmException("invalid end state: "+state);
}
-
+
if (log.isDebugEnabled()) {
if (state==STATE_ENDED) {
log.debug(toString()+" ends");
@@ -350,32 +350,32 @@
log.debug(toString()+" ends with state "+state);
}
}
-
+
// end all child executions
// making a copy of the executions to prevent ConcurrentMoidificationException
List<ExecutionImpl> executionsToEnd = new ArrayList<ExecutionImpl>(executions);
for (ExecutionImpl child: executionsToEnd) {
child.end(state);
}
-
+
setState(state);
this.propagation = Propagation.EXPLICIT;
-
+
DbSession dbSession = EnvironmentImpl.getFromCurrent(DbSession.class, false);
-
-
+
+
if (parent!=null) {
-
+
if (dbSession!=null) {
-
+
// make sure task attached to this execution are completed or skipped
TaskImpl task = dbSession.findTaskByExecution(this);
if (task != null && !task.isCompleted()) {
task.skip(null);
}
-
+
dbSession.delete(this);
}
parent.removeExecution(this);
@@ -397,7 +397,7 @@
}
}
}
-
+
public void end(OpenExecution executionToEnd) {
((ExecutionImpl)executionToEnd).end();
}
@@ -415,7 +415,7 @@
public void signal(String signal) {
signal(signal, (Map<String,?>)null);
}
-
+
public void signal(Map<String, ?> parameters) {
signal(null, parameters);
}
@@ -436,7 +436,7 @@
throw new JbpmException("execution is not in a activity or in a transition");
}
}
-
+
public void signal(Execution execution) {
((ExecutionImpl)execution).signal(null, (Map<String,?>)null);
}
@@ -454,7 +454,7 @@
}
// execution method : take ////////////////////////////////////////////////
-
+
/** @see Execution#takeDefaultTransition() */
public void takeDefaultTransition() {
TransitionImpl defaultTransition = getActivity().getDefaultOutgoingTransition();
@@ -483,7 +483,7 @@
setPropagation(Propagation.EXPLICIT);
setTransition((TransitionImpl) transition);
-
+
fire(Event.END, getActivity(), AtomicOperation.TRANSITION_END_ACTIVITY);
}
@@ -504,24 +504,24 @@
}
execute(nestedActivity);
}
-
+
/** @see Execution#execute(Activity) */
public void execute(Activity activity) {
if (activity==null) {
throw new JbpmException("activity is null");
}
checkActive();
-
+
this.propagation = Propagation.EXPLICIT;
performAtomicOperation(new MoveToChildActivity((ActivityImpl) activity));
}
-
+
// execution method : waitForSignal /////////////////////////////////////////
-
+
public void waitForSignal() {
propagation = Propagation.WAIT;
}
-
+
// execution method : proceed ///////////////////////////////////////////////
public void proceed() {
@@ -533,8 +533,8 @@
if (defaultTransition!=null) {
take(defaultTransition);
}
- // in block structured processDefinition languages we assume that
- // there is no default transition and that there is a
+ // in block structured processDefinition languages we assume that
+ // there is no default transition and that there is a
// parent activity of the current activity
else {
ActivityImpl parentActivity = getActivity().getParentActivity();
@@ -545,9 +545,9 @@
performAtomicOperation(AtomicOperation.PROPAGATE_TO_PARENT);
}
else {
- // When we don't know how to proceed, i don't know if it's best to
+ // When we don't know how to proceed, i don't know if it's best to
// throw new PvmException("don't know how to proceed");
- // or to end the execution. Because of convenience for testing,
+ // or to end the execution. Because of convenience for testing,
// I opted to end the execution.
end();
}
@@ -563,7 +563,7 @@
}
// events ///////////////////////////////////////////////////////////////////
-
+
public void fire(String eventName, ObservableElement eventSource) {
fire(eventName, (ObservableElementImpl) eventSource, null);
}
@@ -582,17 +582,17 @@
performAtomicOperationSync(eventCompletedOperation);
}
}
-
+
public static EventImpl findEvent(ObservableElementImpl observableElement, String eventName) {
if (observableElement==null) {
return null;
}
-
+
EventImpl event = observableElement.getEvent(eventName);
if (event!=null) {
return event;
}
-
+
return findEvent(observableElement.getParent(), eventName);
}
@@ -622,7 +622,7 @@
return propagatingExecution;
}
- // asynchronous continuations ////////////////////////////////////////////////
+ // asynchronous continuations ////////////////////////////////////////////////
public synchronized void performAtomicOperation(AtomicOperation operation) {
if (operation.isAsync(this)) {
@@ -632,7 +632,7 @@
performAtomicOperationSync(operation);
}
}
-
+
public void sendContinuationMessage(AtomicOperation operation) {
EnvironmentImpl environment = EnvironmentImpl.getCurrent();
MessageSession messageSession = environment.get(MessageSession.class);
@@ -649,8 +649,8 @@
// initialise the fifo queue of atomic operations
atomicOperations = new LinkedList<AtomicOperation>();
atomicOperations.offer(operation);
-
- ExecutionContext originalExecutionContext = null;
+
+ ExecutionContext originalExecutionContext = null;
ExecutionContext executionContext = null;
EnvironmentImpl environment = EnvironmentImpl.getCurrent();
if (environment!=null) {
@@ -665,7 +665,7 @@
environment.setContext(executionContext);
}
}
-
+
try {
while (! atomicOperations.isEmpty()) {
AtomicOperation atomicOperation = atomicOperations.poll();
@@ -674,7 +674,7 @@
}
finally {
atomicOperations = null;
-
+
if (executionContext!=null) {
environment.removeContext(executionContext);
}
@@ -688,13 +688,13 @@
}
}
- /**
+ /**
* Important: Only use this if resolving an expression on another execution then the current execution
- *
+ *
* TODO: remove this operation once the environment/executionContext is refactored
*/
public Object resolveExpression(String expression, String language) {
- ExecutionContext originalExecutionContext = null;
+ ExecutionContext originalExecutionContext = null;
ExecutionContext executionContext = null;
EnvironmentImpl environment = EnvironmentImpl.getCurrent();
if (environment!=null) {
@@ -709,10 +709,9 @@
environment.setContext(executionContext);
}
}
-
+
try {
- ScriptManager scriptManager = ScriptManager.getScriptManager();
- return scriptManager.evaluateScript(expression, language);
+ return Expression.create(expression, language).evaluate();
}
catch (RuntimeException e) {
log.error("Error while evaluation script " + expression, e);
@@ -730,7 +729,7 @@
public void handleException(ObservableElementImpl observableElement, EventImpl event,
EventListenerReference eventListenerReference, Exception exception, String rethrowMessage) {
-
+
List<ProcessElementImpl> processElements = new ArrayList<ProcessElementImpl>();
if (eventListenerReference!=null) {
processElements.add(eventListenerReference);
@@ -742,7 +741,7 @@
processElements.add(observableElement);
observableElement = observableElement.getParent();
}
-
+
for (ProcessElementImpl processElement: processElements) {
List<ExceptionHandlerImpl> exceptionHandlers = processElement.getExceptionHandlers();
if (exceptionHandlers!=null) {
@@ -766,7 +765,7 @@
log.trace("rethrowing exception cause no exception handler for "+exception);
ExceptionHandlerImpl.rethrow(exception, rethrowMessage+": "+exception.getMessage());
}
-
+
// tasks ////////////////////////////////////////////////////////////////////
/** tasks and swimlane assignment.
@@ -778,10 +777,10 @@
if (assigneeExpression!=null) {
String assignee = (String) assigneeExpression.evaluate(this);
assignable.setAssignee(assignee);
-
+
if (log.isTraceEnabled()) log.trace("task "+name+" assigned to "+assignee+" using expression "+assigneeExpression);
}
-
+
Expression candidateUsersExpression = assignableDefinition.getCandidateUsersExpression();
if (candidateUsersExpression!=null) {
String candidateUsers = (String) candidateUsersExpression.evaluate(this);
@@ -792,7 +791,7 @@
assignable.addCandidateUser(candidateUser);
}
}
-
+
Expression candidateGroupsExpression = assignableDefinition.getCandidateGroupsExpression();
if (candidateGroupsExpression!=null) {
String candidateGroups = (String) candidateGroupsExpression.evaluate(this);
@@ -802,11 +801,11 @@
assignable.addCandidateGroup(candidateGroup);
}
}
-
+
UserCodeReference assignmentHandlerReference = assignableDefinition
.getAssignmentHandlerReference();
if (assignmentHandlerReference!=null) {
- // JBPM-2758
+ // JBPM-2758
// TODO Find out why processdefinition is null in at this time....
if (processDefinition == null) {
processDefinition = getProcessDefinition();
@@ -825,25 +824,25 @@
}
protected String resolveAssignmentExpression(String expression, String expressionLanguage) {
- ScriptManager scriptManager = EnvironmentImpl.getFromCurrent(ScriptManager.class);
- Object result = scriptManager.evaluateExpression(expression, expressionLanguage);
+ Object result = Expression.create(expression, expressionLanguage).evaluate();
if (result == null || result instanceof String) {
return (String) result;
}
- throw new JbpmException("result of assignment expression "+expression+" is "+result+" ("+result.getClass().getName()+") instead of String");
+ throw new JbpmException("result of assignment expression " + expression
+ + " is " + result + " (" + result.getClass().getName() + ") instead of String");
}
-
+
// swimlanes ////////////////////////////////////////////////////////////////
-
+
public void addSwimlane(SwimlaneImpl swimlane) {
swimlanes.put(swimlane.getName(), swimlane);
swimlane.setExecution(this);
}
-
+
public SwimlaneImpl getSwimlane(String swimlaneName) {
return swimlanes.get(swimlaneName);
}
-
+
public void removeSwimlane(SwimlaneImpl swimlane) {
swimlanes.remove(swimlane.getName());
swimlane.setExecution(null);
@@ -875,7 +874,7 @@
swimlanes.put(swimlaneName, swimlane);
return swimlane;
}
-
+
// child executions /////////////////////////////////////////////////////////
public ExecutionImpl createExecution() {
@@ -884,22 +883,22 @@
public ExecutionImpl createExecution(String name) {
// when an activity calls createExecution, propagation is explicit.
- // this means that the default propagation (proceed()) will not be called
+ // this means that the default propagation (proceed()) will not be called
propagation = Propagation.EXPLICIT;
// create new execution
ExecutionImpl childExecution = newChildExecution();
- // initialize child execution
+ // initialize child execution
childExecution.setProcessDefinition(getProcessDefinition());
childExecution.processInstance = this.processInstance;
childExecution.name = name;
-
+
// composeIds uses the parent so the childExecution has to be added before the ids are composed
- childExecution.setParent(this);
+ childExecution.setParent(this);
childExecution.save();
// make sure that child execution are saved before added to a persistent collection
- // cause of the 'assigned' id strategy, adding the childExecution to the persistent collection
+ // cause of the 'assigned' id strategy, adding the childExecution to the persistent collection
// before the dbid is assigned will result in identifier of an instance of ExecutionImpl altered from 0 to x
addExecution(childExecution);
@@ -953,7 +952,7 @@
}
return executionsMap;
}
-
+
public boolean hasExecution(String name) {
return getExecutionsMap() != null && executionsMap.containsKey(name);
}
@@ -971,11 +970,11 @@
&& activityName != null) {
activityNames.add(activityName);
}
-
+
for (ExecutionImpl childExecution: executions) {
childExecution.addActiveActivityNames(activityNames);
}
-
+
return activityNames;
}
@@ -993,9 +992,9 @@
return null;
}
-
+
// system variables /////////////////////////////////////////////////////////
-
+
public void createSystemVariable(String key, Object value) {
createSystemVariable(key, value, null);
}
@@ -1016,7 +1015,7 @@
createSystemVariable(key, value, null);
}
}
-
+
public Object getSystemVariable(String key) {
Variable variable = systemVariables.get(key);
if (variable!=null) {
@@ -1024,7 +1023,7 @@
}
return null;
}
-
+
public boolean removeSystemVariable(String key) {
if (systemVariables.containsKey(key)) {
return systemVariables.remove(key) != null;
@@ -1037,7 +1036,7 @@
public ClientProcessInstance createSubProcessInstance(ClientProcessDefinition processDefinition) {
return createSubProcessInstance(processDefinition, null);
}
-
+
public ClientProcessInstance createSubProcessInstance(ClientProcessDefinition processDefinition, String key) {
if (subProcessInstance!=null) {
throw new JbpmException(toString()+" already has a sub process instance: "+subProcessInstance);
@@ -1046,11 +1045,11 @@
subProcessInstance.setSuperProcessExecution(this);
return subProcessInstance;
}
-
+
public ClientProcessInstance startSubProcessInstance(ClientProcessDefinition processDefinition) {
return startSubProcessInstance(processDefinition, null);
}
-
+
public ClientProcessInstance startSubProcessInstance(ClientProcessDefinition processDefinition, String key) {
createSubProcessInstance(processDefinition, key);
subProcessInstance.start();
@@ -1084,11 +1083,11 @@
if (!isActive()) {
throw new JbpmException(toString()+" is not active: "+state);
} else if (this.subProcessInstance != null && !Execution.STATE_ENDED.equals(this.subProcessInstance.getState())) {
- throw new JbpmException(toString() + " has running subprocess: "
+ throw new JbpmException(toString() + " has running subprocess: "
+ this.subProcessInstance.toString() + " in state " + this.subProcessInstance.getState());
}
}
-
+
public boolean isEnded() {
if (Execution.STATE_ENDED.equals(state)) {
return true;
@@ -1120,7 +1119,7 @@
////////////////////////////////////////////////////////////////////////////////
// overriding the ScopeInstanceImpl methods /////////////////////////////////
-
+
public ScopeInstanceImpl getParentVariableScope() {
return parent;
}
@@ -1130,10 +1129,10 @@
}
// overridable by process languages /////////////////////////////////////////
-
- /** by default this will use {@link ActivityImpl#findOutgoingTransition(String)} to
- * search for the outgoing transition, which includes a search over the parent chain
- * of the current activity. This method allows process languages to overwrite this default
+
+ /** by default this will use {@link ActivityImpl#findOutgoingTransition(String)} to
+ * search for the outgoing transition, which includes a search over the parent chain
+ * of the current activity. This method allows process languages to overwrite this default
* implementation of the transition lookup by transitionName.*/
protected TransitionImpl findTransition(String transitionName) {
return getActivity().findOutgoingTransition(transitionName);
@@ -1142,7 +1141,7 @@
protected TransitionImpl findDefaultTransition() {
return getActivity().findDefaultTransition();
}
-
+
// history //////////////////////////////////////////////////////////////////
public void historyAutomatic() {
@@ -1152,7 +1151,7 @@
public void historyDecision(String transitionName) {
HistoryEvent.fire(new DecisionEnd(transitionName), this);
}
-
+
public void historyActivityStart() {
HistoryEvent.fire(new ActivityStart(), this);
}
@@ -1172,12 +1171,12 @@
public boolean equals(Object o) {
return EqualsUtil.equals(this, o);
}
-
+
// process definition getter and setter /////////////////////////////////////
- // this getter and setter is special because persistence is based on the //
+ // this getter and setter is special because persistence is based on the //
// process definition id. //
/////////////////////////////////////////////////////////////////////////////
-
+
public ProcessDefinitionImpl getProcessDefinition() {
if (processDefinition == null && processDefinitionId != null) {
RepositorySession repositorySession = EnvironmentImpl
@@ -1193,19 +1192,19 @@
this.processDefinition = processDefinition;
this.processDefinitionId = processDefinition.getId();
}
-
+
// activity getter and setter ///////////////////////////////////////////////
- // this getter and setter is special because persistence is based on the //
+ // this getter and setter is special because persistence is based on the //
// activity name. //
/////////////////////////////////////////////////////////////////////////////
-
+
public ActivityImpl getActivity() {
if (activity == null && activityName != null) {
activity = getProcessDefinition().findActivity(activityName);
}
return activity;
}
-
+
public void setActivity(ActivityImpl activity) {
this.activity = activity;
if (activity!=null) {
@@ -1237,14 +1236,14 @@
}
// getters and setters for scope instance //////////////////////////////////////
-
+
@Override
public ExecutionImpl getExecution() {
return this;
}
// getters and setters /////////////////////////////////////////////////////////
-
+
public TransitionImpl getTransition() {
return transition;
}
Modified: jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/model/ExpressionCondition.java
===================================================================
--- jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/model/ExpressionCondition.java 2010-07-02 22:39:17 UTC (rev 6450)
+++ jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/model/ExpressionCondition.java 2010-07-03 02:42:45 UTC (rev 6451)
@@ -23,34 +23,34 @@
import org.jbpm.api.JbpmException;
import org.jbpm.api.model.OpenExecution;
-import org.jbpm.pvm.internal.script.ScriptManager;
+import org.jbpm.pvm.internal.el.Expression;
/**
* @author Tom Baeyens
+ * @author Huisheng Xu
*/
public class ExpressionCondition implements Condition {
private static final long serialVersionUID = 1L;
-
+
protected String expression;
protected String language;
-
+
public boolean evaluate(OpenExecution execution) {
- ScriptManager scriptManager = ScriptManager.getScriptManager();
- Object result = scriptManager.evaluateExpression(expression, language);
+ Object result = Expression.create(expression, language).evaluate();
if (result instanceof Boolean) {
return ((Boolean) result).booleanValue();
}
- throw new JbpmException("expression condition '"+expression+"' did not return a boolean: "+result);
+ throw new JbpmException("expression condition '" + expression + "' did not return a boolean: "+result);
}
public void setExpression(String expression) {
this.expression = expression;
}
-
+
public void setLanguage(String language) {
this.language = language;
}
-
+
}
Modified: jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/model/VariableOutDefinitionSet.java
===================================================================
--- jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/model/VariableOutDefinitionSet.java 2010-07-02 22:39:17 UTC (rev 6450)
+++ jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/model/VariableOutDefinitionSet.java 2010-07-03 02:42:45 UTC (rev 6451)
@@ -26,16 +26,17 @@
import java.util.Collections;
import java.util.List;
+import org.jbpm.pvm.internal.el.Expression;
import org.jbpm.pvm.internal.env.EnvironmentImpl;
-import org.jbpm.pvm.internal.script.ScriptManager;
/**
* @author Tom Baeyens
+ * @author Huisheng Xu
*/
public class VariableOutDefinitionSet implements Serializable {
-
+
private static final long serialVersionUID = 1L;
-
+
protected List<VariableOutDefinitionImpl> variableOutDefinitions;
public void processOutVariables(ExecutionImpl outerExecution, ScopeInstanceImpl innerScopeInstance) {
@@ -44,13 +45,11 @@
for (VariableOutDefinitionImpl variableOutDefinition: variableOutDefinitions) {
String variableName = variableOutDefinition.getName();
if (variableName!=null) {
- ScriptManager scriptManager = EnvironmentImpl.getFromCurrent(ScriptManager.class);
-
// TODO update evaluateExpression so that scopeInstance can be passed in directly
String expression = variableOutDefinition.getExpression();
String language = variableOutDefinition.getLanguage();
- Object value = scriptManager.evaluateExpression(expression, language);
+ Object value = Expression.create(expression, language).evaluateInScope(innerScopeInstance);
outerExecution.setVariable(variableName, value);
}
}
@@ -62,7 +61,7 @@
&& (!variableOutDefinitions.isEmpty())
);
}
-
+
public List<VariableOutDefinitionImpl> getVariableOutDefinitions() {
if (variableOutDefinitions==null) {
return Collections.emptyList();
Modified: jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/wire/descriptor/ExpressionDescriptor.java
===================================================================
--- jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/wire/descriptor/ExpressionDescriptor.java 2010-07-02 22:39:17 UTC (rev 6450)
+++ jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/wire/descriptor/ExpressionDescriptor.java 2010-07-03 02:42:45 UTC (rev 6451)
@@ -21,23 +21,23 @@
*/
package org.jbpm.pvm.internal.wire.descriptor;
-import org.jbpm.pvm.internal.script.ScriptManager;
+import org.jbpm.pvm.internal.el.Expression;
import org.jbpm.pvm.internal.wire.WireContext;
/**
* @author Tom Baeyens
+ * @author Huisheng Xu
*/
public class ExpressionDescriptor extends AbstractDescriptor {
private static final long serialVersionUID = 1L;
-
+
protected String expression;
protected String language;
-
+
public Object construct(WireContext wireContext) {
- ScriptManager scriptManager = ScriptManager.getScriptManager();
- Object result = scriptManager.evaluateExpression(expression, language);
+ Object result = Expression.create(expression, language).evaluate();
return result;
}
Modified: jbpm4/trunk/modules/test-db/src/test/java/org/jbpm/test/variables/VariableExpressionTest.java
===================================================================
--- jbpm4/trunk/modules/test-db/src/test/java/org/jbpm/test/variables/VariableExpressionTest.java 2010-07-02 22:39:17 UTC (rev 6450)
+++ jbpm4/trunk/modules/test-db/src/test/java/org/jbpm/test/variables/VariableExpressionTest.java 2010-07-03 02:42:45 UTC (rev 6451)
@@ -20,7 +20,7 @@
* 02110-1301 USA, or see the FSF site: http://www.fsf.org.
*/
/**
- *
+ *
*/
package org.jbpm.test.variables;
@@ -39,7 +39,7 @@
* @author Maciej Swiderski
*/
public class VariableExpressionTest extends JbpmTestCase {
-
+
public void testExpression() {
deployJpdlXmlString(
"<process name='theProcess'>" +
@@ -51,7 +51,7 @@
" </custom>" +
" <decision name='decideToGoFurther'>" +
" <transition to='waitHere'>" +
- " <condition expr='#{counter == 10}' />" +
+ " <condition expr='#{counter == 10}' />" +
" </transition>" +
" <transition to='incrementCounter'>" +
" <condition expr='#{counter < 10}' />" +
@@ -63,17 +63,17 @@
" <end name='theEnd' />" +
"</process>"
);
-
+
Map<String, Integer> vars = new HashMap<String, Integer>();
vars.put("counter", 0);
-
+
ProcessInstance processInstance = executionService.startProcessInstanceByKey("theProcess", vars);
assertActivityActive(processInstance.getId(), "waitHere");
-
+
Integer counter = (Integer) executionService.getVariable(processInstance.getId(), "counter");
assertEquals(new Integer(10), counter);
}
-
+
public void testNullValueExpression() {
deployJpdlXmlString(
"<process name='theProcess'>" +
@@ -85,7 +85,7 @@
" </custom>" +
" <decision name='decideToGoFurther'>" +
" <transition to='waitHere'>" +
- " <condition expr='#{counter==null}' />" +
+ " <condition expr='#{counter==null}' />" +
" </transition>" +
" <transition to='incrementCounter'>" +
" <condition expr='#{counter < 10}' />" +
@@ -97,17 +97,17 @@
" <end name='theEnd' />" +
"</process>"
);
-
+
Map<String, Object> vars = new HashMap<String, Object>();
vars.put("counter", null);
-
+
ProcessInstance processInstance = executionService.startProcessInstanceByKey("theProcess", vars);
assertActivityActive(processInstance.getId(), "waitHere");
-
+
Object value = executionService.getVariable(processInstance.getId(), "counter");
assertEquals(null, value);
}
-
+
public void testMissingVariableExpression() {
deployJpdlXmlString(
"<process name='theProcess'>" +
@@ -119,7 +119,7 @@
" </custom>" +
" <decision name='decideToGoFurther'>" +
" <transition to='waitHere'>" +
- " <condition expr='#{counter==null}' />" +
+ " <condition expr='#{counter==null}' />" +
" </transition>" +
" <transition to='incrementCounter'>" +
" <condition expr='#{counter < 10}' />" +
@@ -131,20 +131,21 @@
" <end name='theEnd' />" +
"</process>"
);
-
+
Map<String, Object> vars = new HashMap<String, Object>();
try {
ProcessInstance processInstance = executionService.startProcessInstanceByKey("theProcess", vars);
fail("Variable counter is not set, should fail");
- } catch (JbpmException e) {
+ } catch (Exception e) {
- assertTrue(e.getMessage().indexOf("Cannot find property counter") != -1);
+ assertEquals("Cannot resolve identifier 'counter'",
+ e.getMessage());
}
}
-
-
+
+
public static class MyJavaActivity implements ActivityBehaviour {
private static final long serialVersionUID = 1L;
@@ -154,7 +155,7 @@
counter++;
execution.setVariable("counter", counter);
}
-
+
}
}
13 years, 12 months
- 1
- 0