JBoss JBPM SVN: r2092 - jbpm4/pvm/trunk/modules/core/src/main/java/org/jbpm/pvm/internal/deploy.
by do-not-reply@jboss.org
Author: tom.baeyens(a)jboss.com
Date: 2008-09-03 10:45:38 -0400 (Wed, 03 Sep 2008)
New Revision: 2092
Modified:
jbpm4/pvm/trunk/modules/core/src/main/java/org/jbpm/pvm/internal/deploy/CreateId.java
Log:
added exception on empty string key
Modified: jbpm4/pvm/trunk/modules/core/src/main/java/org/jbpm/pvm/internal/deploy/CreateId.java
===================================================================
--- jbpm4/pvm/trunk/modules/core/src/main/java/org/jbpm/pvm/internal/deploy/CreateId.java 2008-09-03 14:45:01 UTC (rev 2091)
+++ jbpm4/pvm/trunk/modules/core/src/main/java/org/jbpm/pvm/internal/deploy/CreateId.java 2008-09-03 14:45:38 UTC (rev 2092)
@@ -22,6 +22,7 @@
package org.jbpm.pvm.internal.deploy;
import org.jbpm.pvm.Deployment;
+import org.jbpm.pvm.PvmException;
import org.jbpm.pvm.internal.log.Log;
import org.jbpm.pvm.internal.model.ProcessDefinitionImpl;
@@ -42,6 +43,10 @@
key = processDefinition.getName();
}
+ if ("".equals(key)) {
+ throw new PvmException("empty string is not a valid key");
+ }
+
// replace any non-word character with an underscore
key = key.replaceAll("\\W", "_");
17 years, 7 months
JBoss JBPM SVN: r2091 - jbpm4/pvm/trunk/modules/core/src/main/java/org/jbpm/pvm/internal/deploy.
by do-not-reply@jboss.org
Author: tom.baeyens(a)jboss.com
Date: 2008-09-03 10:45:01 -0400 (Wed, 03 Sep 2008)
New Revision: 2091
Modified:
jbpm4/pvm/trunk/modules/core/src/main/java/org/jbpm/pvm/internal/deploy/CheckVersion.java
Log:
removed clover import, added log
Modified: jbpm4/pvm/trunk/modules/core/src/main/java/org/jbpm/pvm/internal/deploy/CheckVersion.java
===================================================================
--- jbpm4/pvm/trunk/modules/core/src/main/java/org/jbpm/pvm/internal/deploy/CheckVersion.java 2008-09-03 14:44:34 UTC (rev 2090)
+++ jbpm4/pvm/trunk/modules/core/src/main/java/org/jbpm/pvm/internal/deploy/CheckVersion.java 2008-09-03 14:45:01 UTC (rev 2091)
@@ -25,15 +25,16 @@
import org.jbpm.pvm.PvmException;
import org.jbpm.pvm.client.ClientProcessDefinition;
import org.jbpm.pvm.env.Environment;
+import org.jbpm.pvm.internal.log.Log;
import org.jbpm.pvm.internal.model.ProcessDefinitionImpl;
import org.jbpm.pvm.session.PvmDbSession;
-import clover.org.jfree.util.Log;
-
/**
* @author Tom Baeyens
*/
public class CheckVersion implements Deployer {
+
+ private static final Log log = Log.getLog(CheckVersion.class.getName());
protected boolean assign = true;
@@ -71,7 +72,7 @@
} else {
version = 1;
}
- Log.debug("assigning version "+version+" to process definition "+name);
+ log.debug("assigning version "+version+" to process definition "+name);
processDefinition.setVersion(version);
} else {
17 years, 7 months
JBoss JBPM SVN: r2090 - jbpm4/pvm/trunk/modules/core/src/main/java/org/jbpm/pvm/internal/cmd.
by do-not-reply@jboss.org
Author: tom.baeyens(a)jboss.com
Date: 2008-09-03 10:44:34 -0400 (Wed, 03 Sep 2008)
New Revision: 2090
Modified:
jbpm4/pvm/trunk/modules/core/src/main/java/org/jbpm/pvm/internal/cmd/StartExecutionCmd.java
Log:
changed key with id in exception message
Modified: jbpm4/pvm/trunk/modules/core/src/main/java/org/jbpm/pvm/internal/cmd/StartExecutionCmd.java
===================================================================
--- jbpm4/pvm/trunk/modules/core/src/main/java/org/jbpm/pvm/internal/cmd/StartExecutionCmd.java 2008-09-03 14:44:01 UTC (rev 2089)
+++ jbpm4/pvm/trunk/modules/core/src/main/java/org/jbpm/pvm/internal/cmd/StartExecutionCmd.java 2008-09-03 14:44:34 UTC (rev 2090)
@@ -54,7 +54,7 @@
processDefinition = pvmDbSession.findProcessDefinitionById(processDefinitionId);
if (processDefinition==null) {
- throw new PvmException("no process definition with key '"+processDefinitionId+"'");
+ throw new PvmException("no process definition with id '"+processDefinitionId+"'");
}
ClientProcessInstance processInstance = processDefinition.createProcessInstance(executionKey);
17 years, 7 months
JBoss JBPM SVN: r2089 - jbpm4/pvm/trunk/modules/core/src/main/java/org/jbpm/pvm/env.
by do-not-reply@jboss.org
Author: tom.baeyens(a)jboss.com
Date: 2008-09-03 10:44:01 -0400 (Wed, 03 Sep 2008)
New Revision: 2089
Modified:
jbpm4/pvm/trunk/modules/core/src/main/java/org/jbpm/pvm/env/EnvironmentHelper.java
Log:
added cause to exception
Modified: jbpm4/pvm/trunk/modules/core/src/main/java/org/jbpm/pvm/env/EnvironmentHelper.java
===================================================================
--- jbpm4/pvm/trunk/modules/core/src/main/java/org/jbpm/pvm/env/EnvironmentHelper.java 2008-09-03 14:36:03 UTC (rev 2088)
+++ jbpm4/pvm/trunk/modules/core/src/main/java/org/jbpm/pvm/env/EnvironmentHelper.java 2008-09-03 14:44:01 UTC (rev 2089)
@@ -53,7 +53,7 @@
return (T) defaultObject;
}
} catch (Exception e) {
- throw new PvmException("couldn't create default "+type.getName());
+ throw new PvmException("couldn't create default "+type.getName(), e);
}
return null;
}
17 years, 7 months
JBoss JBPM SVN: r2088 - jbpm4/pvm/trunk/modules/core/src/test/java/org/jbpm/pvm/api/db/basicfeatures.
by do-not-reply@jboss.org
Author: tom.baeyens(a)jboss.com
Date: 2008-09-03 10:36:03 -0400 (Wed, 03 Sep 2008)
New Revision: 2088
Modified:
jbpm4/pvm/trunk/modules/core/src/test/java/org/jbpm/pvm/api/db/basicfeatures/BasicExecutionFlowDbTest.java
Log:
updated process definition key to id
Modified: jbpm4/pvm/trunk/modules/core/src/test/java/org/jbpm/pvm/api/db/basicfeatures/BasicExecutionFlowDbTest.java
===================================================================
--- jbpm4/pvm/trunk/modules/core/src/test/java/org/jbpm/pvm/api/db/basicfeatures/BasicExecutionFlowDbTest.java 2008-09-03 14:34:48 UTC (rev 2087)
+++ jbpm4/pvm/trunk/modules/core/src/test/java/org/jbpm/pvm/api/db/basicfeatures/BasicExecutionFlowDbTest.java 2008-09-03 14:36:03 UTC (rev 2088)
@@ -78,7 +78,7 @@
Deployment deployment = new Deployment(processDefinition);
processService.deploy(deployment);
- Execution processInstance = executionService.startExecution("myProcess");
+ Execution processInstance = executionService.startExecution("myProcess:1", "one");
List<String> expectedEvents = new ArrayList<String>();
17 years, 7 months
JBoss JBPM SVN: r2087 - jbpm4/pvm/trunk/modules/core/src/test/java/org/jbpm/pvm/internal/expr.
by do-not-reply@jboss.org
Author: tom.baeyens(a)jboss.com
Date: 2008-09-03 10:34:48 -0400 (Wed, 03 Sep 2008)
New Revision: 2087
Modified:
jbpm4/pvm/trunk/modules/core/src/test/java/org/jbpm/pvm/internal/expr/GroovyExpressionTest.java
jbpm4/pvm/trunk/modules/core/src/test/java/org/jbpm/pvm/internal/expr/JuelExpressionTest.java
Log:
renamed initial node
Modified: jbpm4/pvm/trunk/modules/core/src/test/java/org/jbpm/pvm/internal/expr/GroovyExpressionTest.java
===================================================================
--- jbpm4/pvm/trunk/modules/core/src/test/java/org/jbpm/pvm/internal/expr/GroovyExpressionTest.java 2008-09-03 14:34:24 UTC (rev 2086)
+++ jbpm4/pvm/trunk/modules/core/src/test/java/org/jbpm/pvm/internal/expr/GroovyExpressionTest.java 2008-09-03 14:34:48 UTC (rev 2087)
@@ -53,7 +53,7 @@
ScriptManager scriptManager = environmentFactory.get(ScriptManager.class);
ClientProcessInstance execution = ProcessFactory.build()
- .node("unused").initial().behaviour(WaitState.class)
+ .node("initial").initial().behaviour(WaitState.class)
.done().beginProcessInstance();
execution.setVariable("pv", "hello");
Modified: jbpm4/pvm/trunk/modules/core/src/test/java/org/jbpm/pvm/internal/expr/JuelExpressionTest.java
===================================================================
--- jbpm4/pvm/trunk/modules/core/src/test/java/org/jbpm/pvm/internal/expr/JuelExpressionTest.java 2008-09-03 14:34:24 UTC (rev 2086)
+++ jbpm4/pvm/trunk/modules/core/src/test/java/org/jbpm/pvm/internal/expr/JuelExpressionTest.java 2008-09-03 14:34:48 UTC (rev 2087)
@@ -53,7 +53,7 @@
ScriptManager scriptManager = environmentFactory.get(ScriptManager.class);
ClientProcessInstance execution = ProcessFactory.build()
- .node("unused").initial().behaviour(WaitState.class)
+ .node("initial").initial().behaviour(WaitState.class)
.done().beginProcessInstance();
execution.setVariable("pv", "hello");
17 years, 7 months
JBoss JBPM SVN: r2086 - jbpm4/pvm/trunk.
by do-not-reply@jboss.org
Author: tom.baeyens(a)jboss.com
Date: 2008-09-03 10:34:24 -0400 (Wed, 03 Sep 2008)
New Revision: 2086
Modified:
jbpm4/pvm/trunk/.classpath
Log:
fixed really important indentation :-)
Modified: jbpm4/pvm/trunk/.classpath
===================================================================
--- jbpm4/pvm/trunk/.classpath 2008-09-03 14:29:46 UTC (rev 2085)
+++ jbpm4/pvm/trunk/.classpath 2008-09-03 14:34:24 UTC (rev 2086)
@@ -1,10 +1,10 @@
<?xml version="1.0" encoding="UTF-8"?>
<classpath>
- <classpathentry kind="src" output="modules/core/target/classes" path="modules/core/src/main/java"/>
- <classpathentry kind="src" output="modules/core/target/classes" path="modules/core/src/main/resources"/>
- <classpathentry kind="src" output="modules/core/target/test-classes" path="modules/core/src/test/java"/>
- <classpathentry kind="src" output="modules/core/target/test-classes" path="modules/core/src/test/resources"/>
- <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"/>
- <classpathentry kind="con" path="org.maven.ide.eclipse.MAVEN2_CLASSPATH_CONTAINER/modules"/>
- <classpathentry kind="output" path="target/classes"/>
+ <classpathentry kind="src" output="modules/core/target/classes" path="modules/core/src/main/java"/>
+ <classpathentry kind="src" output="modules/core/target/classes" path="modules/core/src/main/resources"/>
+ <classpathentry kind="src" output="modules/core/target/test-classes" path="modules/core/src/test/java"/>
+ <classpathentry kind="src" output="modules/core/target/test-classes" path="modules/core/src/test/resources"/>
+ <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"/>
+ <classpathentry kind="con" path="org.maven.ide.eclipse.MAVEN2_CLASSPATH_CONTAINER/modules"/>
+ <classpathentry kind="output" path="target/classes"/>
</classpath>
17 years, 7 months
JBoss JBPM SVN: r2085 - jbpm3/trunk/hudson/hudson-home.
by do-not-reply@jboss.org
Author: thomas.diesler(a)jboss.com
Date: 2008-09-03 10:29:46 -0400 (Wed, 03 Sep 2008)
New Revision: 2085
Modified:
jbpm3/trunk/hudson/hudson-home/command.sh
Log:
Fix dependency:tree
Modified: jbpm3/trunk/hudson/hudson-home/command.sh
===================================================================
--- jbpm3/trunk/hudson/hudson-home/command.sh 2008-09-03 14:23:35 UTC (rev 2084)
+++ jbpm3/trunk/hudson/hudson-home/command.sh 2008-09-03 14:29:46 UTC (rev 2085)
@@ -30,13 +30,13 @@
#
# log dependency tree
#
+cd $JBPMDIR
+cp profiles.xml.example profiles.xml
mvn -Ddatabase=$DATABASE dependency:tree | tee $WORKSPACE/dependency-tree.txt
#
# Build distro
#
-cd $JBPMDIR
-cp profiles.xml.example profiles.xml
mvn -U -Pdistro clean package; MVN_STATUS=$?
if [ $MVN_STATUS -ne 0 ]; then
echo maven exit status $MVN_STATUS
17 years, 7 months
JBoss JBPM SVN: r2084 - jbpm3/trunk/hudson/hudson-home/jobs/jBPM3-JDK1.5.
by do-not-reply@jboss.org
Author: thomas.diesler(a)jboss.com
Date: 2008-09-03 10:23:35 -0400 (Wed, 03 Sep 2008)
New Revision: 2084
Modified:
jbpm3/trunk/hudson/hudson-home/jobs/jBPM3-JDK1.5/config.xml
Log:
Use SVNed command.sh
Modified: jbpm3/trunk/hudson/hudson-home/jobs/jBPM3-JDK1.5/config.xml
===================================================================
--- jbpm3/trunk/hudson/hudson-home/jobs/jBPM3-JDK1.5/config.xml 2008-09-03 14:17:37 UTC (rev 2083)
+++ jbpm3/trunk/hudson/hudson-home/jobs/jBPM3-JDK1.5/config.xml 2008-09-03 14:23:35 UTC (rev 2084)
@@ -55,8 +55,8 @@
#
# call command.sh
#
-/bin/sh $HUDSON_BASE/hudson-home/command.sh
-#/bin/sh $JBPMDIR/hudson/hudson-home/command.sh
+#/bin/sh $HUDSON_BASE/hudson-home/command.sh
+/bin/sh $JBPMDIR/hudson/hudson-home/command.sh
</command>
</hudson.tasks.Shell>
</builders>
17 years, 7 months
JBoss JBPM SVN: r2083 - jbpm3/trunk/hudson/hudson-home.
by do-not-reply@jboss.org
Author: thomas.diesler(a)jboss.com
Date: 2008-09-03 10:17:37 -0400 (Wed, 03 Sep 2008)
New Revision: 2083
Modified:
jbpm3/trunk/hudson/hudson-home/command.sh
Log:
testFailureIgnore=true
Modified: jbpm3/trunk/hudson/hudson-home/command.sh
===================================================================
--- jbpm3/trunk/hudson/hudson-home/command.sh 2008-09-03 12:18:10 UTC (rev 2082)
+++ jbpm3/trunk/hudson/hudson-home/command.sh 2008-09-03 14:17:37 UTC (rev 2083)
@@ -28,6 +28,11 @@
ENVIRONMENT="-Djboss.bind.address=$JBOSS_BINDADDR -Djboss.home=$JBOSS_HOME"
#
+# log dependency tree
+#
+mvn -Ddatabase=$DATABASE dependency:tree | tee $WORKSPACE/dependency-tree.txt
+
+#
# Build distro
#
cd $JBPMDIR
@@ -39,6 +44,15 @@
fi
#
+# build the tests
+#
+mvn -Ddatabase=$DATABASE process-test-classes 2>&1; MVN_STATUS=$?
+if [ $MVN_STATUS -ne 0 ]; then
+ echo maven exit status $MVN_STATUS
+ exit 1
+fi
+
+#
# Deploy distro
#
sed s:CONTAINER:$CONTAINER: $DISTRODIR/resources/auto-install-$DATABASE.xml > auto-install.xml
@@ -59,14 +73,11 @@
fi
#
-# log dependency tree
-#
-mvn -Ddatabase=$DATABASE dependency:tree | tee $WORKSPACE/dependency-tree.txt
-
-#
# execute tests
#
-mvn -Ddatabase=$DATABASE test 2>&1; MVN_STATUS=$?
+mvn -Ddatabase=$DATABASE -DtestFailureIgnore=true test 2>&1 | tee $WORKSPACE/tests.log
+cat $WORKSPACE/tests.log | egrep FIXME\|FAILED | sort -u | tee $WORKSPACE/fixme.txt
+cat $WORKSPACE/fixme.txt | egrep "\[\S*]" > $WORKSPACE/errata-$CONTAINER.txt
#
# stop jbossas
@@ -74,7 +85,3 @@
$JBPMDIR/hudson/jboss/bin/jboss.sh $JBOSS_HOME stop
cp $JBOSS_HOME/server/$JBOSS_SERVER/log/boot.log $WORKSPACE/jboss-boot.log
cp $JBOSS_HOME/server/$JBOSS_SERVER/log/server.log $WORKSPACE/jboss-server.log
-
-echo maven exit status $MVN_STATUS
-exit $MVN_STATUS
-
17 years, 7 months