Author: camunda Date: 2009-02-13 11:15:34 -0500 (Fri, 13 Feb 2009) New Revision: 3874 Modified: jbpm3/trunk/modules/core/src/main/java/org/jbpm/persistence/jta/JtaDbPersistenceService.java Log: changed log level of commit/rollback events from ERROR to DEBUG since exceptions shoul deither be logged OR thrown Modified: jbpm3/trunk/modules/core/src/main/java/org/jbpm/persistence/jta/JtaDbPersistenceService.java =================================================================== --- jbpm3/trunk/modules/core/src/main/java/org/jbpm/persistence/jta/JtaDbPersistenceService.java 2009-02-13 16:04:59 UTC (rev 3873) +++ jbpm3/trunk/modules/core/src/main/java/org/jbpm/persistence/jta/JtaDbPersistenceService.java 2009-02-13 16:15:34 UTC (rev 3874) @@ -99,7 +99,11 @@ "optimistic locking failed, could not commit " + transaction, e); } else { - log.error("transaction commit failed", e); + // Switched to debug because either handle OR log + // an exception is best practice, not both! + // Example: Clustered JobExecutor may have + // Exceptions which should be kept quiet + log.debug("transaction commit failed", e); } return e; } @@ -112,7 +116,11 @@ return null; } catch (Exception e) { - log.error("transaction rollback failed", e); + // Switched to debug because either handle OR log + // an exception is best practice, not both! + // Example: Clustered JobExecutor may have + // Exceptions which should be kept quiet + log.debug("transaction rollback failed", e); return e; } }