[JBoss JIRA] Commented: (JBPM-1015) ProcessLogs that represent changes of process intance that take place within Timer.Execute are not saved in DB
by Bernd Ruecker (JIRA)
[ https://jira.jboss.org/jira/browse/JBPM-1015?page=com.atlassian.jira.plug... ]
Bernd Ruecker commented on JBPM-1015:
-------------------------------------
Okay, I added an addAutoSave to the methods... Tests are all green and my local test with the BAM stuff works fine now :-) So this small change will be released with jbpm 3.3.1
> ProcessLogs that represent changes of process intance that take place within Timer.Execute are not saved in DB
> --------------------------------------------------------------------------------------------------------------
>
> Key: JBPM-1015
> URL: https://jira.jboss.org/jira/browse/JBPM-1015
> Project: JBoss jBPM
> Issue Type: Bug
> Components: Core Engine
> Affects Versions: jBPM 3.2.1
> Environment: Tomcat 5.0.28 or Jboss
> Reporter: Gil Messerman
> Assignee: Tom Baeyens
> Priority: Critical
> Fix For: jBPM 3.2.2
>
>
> It seems to be a problem with Timer implementation. When some change in process occurs (such as transition or action call), the process instance should be added to jbpmContext to the list of auto saved process instances (actual saving occurs when JBPMContex.close() is called). Apparently Timer.execute does not do it and as a result, the log of all operations performed by Timer.execute is not stored in DB and getting lost.
> To fix the problem, the token.getProcessInstance() should be added to "autoSaveProcessInstances" list in JBPMContext.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
16 years, 1 month
[JBoss JIRA] Commented: (JBPM-1015) ProcessLogs that represent changes of process intance that take place within Timer.Execute are not saved in DB
by Bernd Ruecker (JIRA)
[ https://jira.jboss.org/jira/browse/JBPM-1015?page=com.atlassian.jira.plug... ]
Bernd Ruecker commented on JBPM-1015:
-------------------------------------
There is one problem remaining with this implementation, at least for me at the moment:
jbpmContext.save() is called AFTER token.signal(). So if there is an Exception during execution, the jbpmContext.save is never called.
Unfortunately I use the LoggingService at the moment to create BAM events (also see http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4191842 for some information on that). So in case of exception my own LoggingServices is never called, which is bad!
I will add an jbpmContext.loadTokenForUpdate(token) at the mentioned places at the very beginning to add the autoSave we have at the other places of jbpm. And because of the Hibernate Session cache it shouldn't have any negative effects...
Then it is consistent overall jbpm. Votes against that?
> ProcessLogs that represent changes of process intance that take place within Timer.Execute are not saved in DB
> --------------------------------------------------------------------------------------------------------------
>
> Key: JBPM-1015
> URL: https://jira.jboss.org/jira/browse/JBPM-1015
> Project: JBoss jBPM
> Issue Type: Bug
> Components: Core Engine
> Affects Versions: jBPM 3.2.1
> Environment: Tomcat 5.0.28 or Jboss
> Reporter: Gil Messerman
> Assignee: Tom Baeyens
> Priority: Critical
> Fix For: jBPM 3.2.2
>
>
> It seems to be a problem with Timer implementation. When some change in process occurs (such as transition or action call), the process instance should be added to jbpmContext to the list of auto saved process instances (actual saving occurs when JBPMContex.close() is called). Apparently Timer.execute does not do it and as a result, the log of all operations performed by Timer.execute is not stored in DB and getting lost.
> To fix the problem, the token.getProcessInstance() should be added to "autoSaveProcessInstances" list in JBPMContext.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
16 years, 1 month