[JBoss JIRA] Resolved: (JBPM-1058) Remove useless null checks from JbpmContext methods
by Alejandro Guizar (JIRA)
[ http://jira.jboss.com/jira/browse/JBPM-1058?page=all ]
Alejandro Guizar resolved JBPM-1058.
------------------------------------
Resolution: Done
Done as part of a larger set of redundant null check removals.
http://fisheye.jboss.com/changelog/JbpmSvn/?cs=1475
> Remove useless null checks from JbpmContext methods
> ---------------------------------------------------
>
> Key: JBPM-1058
> URL: http://jira.jboss.com/jira/browse/JBPM-1058
> Project: JBoss jBPM
> Issue Type: Task
> Components: Core Engine
> Affects Versions: jPDL 3.2.3
> Reporter: Johan Parent
> Assigned To: Alejandro Guizar
> Fix For: jPDL 3.2.4
>
>
> Remove useless null checks from often used methods to obtain:
> /**
> * more logging related database access.
> */
> public LoggingSession getLoggingSession() {
> PersistenceService persistenceService = getPersistenceService();
> return (persistenceService!=null ? persistenceService.getLoggingSession() : null);
> }
> /**
> * more messaging related database access.
> */
> public MessagingSession getMessagingSession() {
> PersistenceService persistenceService = getPersistenceService();
> return (persistenceService!=null ? persistenceService.getMessagingSession() : null);
> }
> /**
> * more scheduling related database access.
> */
> public SchedulerSession getSchedulerSession() {
> PersistenceService persistenceService = getPersistenceService();
> return (persistenceService!=null ? persistenceService.getSchedulerSession() : null);
> }
> /**
> * more graph (process) related database access.
> */
> public GraphSession getGraphSession() {
> PersistenceService persistenceService = getPersistenceService();
> return (persistenceService!=null ? persistenceService.getGraphSession() : null);
> }
> /**
> * more task related database access.
> */
> public TaskMgmtSession getTaskMgmtSession() {
> PersistenceService persistenceService = getPersistenceService();
> return (persistenceService!=null ? persistenceService.getTaskMgmtSession() : null);
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
16 years, 5 months
[JBoss JIRA] Updated: (JBPM-1058) Remove useless null checks from JbpmContext methods
by Alejandro Guizar (JIRA)
[ http://jira.jboss.com/jira/browse/JBPM-1058?page=all ]
Alejandro Guizar updated JBPM-1058:
-----------------------------------
Component/s: Core Engine
Fix Version/s: jPDL 3.2.4
Affects Version/s: jPDL 3.2.3
> Remove useless null checks from JbpmContext methods
> ---------------------------------------------------
>
> Key: JBPM-1058
> URL: http://jira.jboss.com/jira/browse/JBPM-1058
> Project: JBoss jBPM
> Issue Type: Task
> Components: Core Engine
> Affects Versions: jPDL 3.2.3
> Reporter: Johan Parent
> Assigned To: Alejandro Guizar
> Fix For: jPDL 3.2.4
>
>
> Remove useless null checks from often used methods to obtain:
> /**
> * more logging related database access.
> */
> public LoggingSession getLoggingSession() {
> PersistenceService persistenceService = getPersistenceService();
> return (persistenceService!=null ? persistenceService.getLoggingSession() : null);
> }
> /**
> * more messaging related database access.
> */
> public MessagingSession getMessagingSession() {
> PersistenceService persistenceService = getPersistenceService();
> return (persistenceService!=null ? persistenceService.getMessagingSession() : null);
> }
> /**
> * more scheduling related database access.
> */
> public SchedulerSession getSchedulerSession() {
> PersistenceService persistenceService = getPersistenceService();
> return (persistenceService!=null ? persistenceService.getSchedulerSession() : null);
> }
> /**
> * more graph (process) related database access.
> */
> public GraphSession getGraphSession() {
> PersistenceService persistenceService = getPersistenceService();
> return (persistenceService!=null ? persistenceService.getGraphSession() : null);
> }
> /**
> * more task related database access.
> */
> public TaskMgmtSession getTaskMgmtSession() {
> PersistenceService persistenceService = getPersistenceService();
> return (persistenceService!=null ? persistenceService.getTaskMgmtSession() : null);
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
16 years, 5 months
[JBoss JIRA] Updated: (JBPM-1058) Remove useless null checks from JbpmContext methods
by Alejandro Guizar (JIRA)
[ http://jira.jboss.com/jira/browse/JBPM-1058?page=all ]
Alejandro Guizar updated JBPM-1058:
-----------------------------------
Issue Type: Task (was: Patch)
> Remove useless null checks from JbpmContext methods
> ---------------------------------------------------
>
> Key: JBPM-1058
> URL: http://jira.jboss.com/jira/browse/JBPM-1058
> Project: JBoss jBPM
> Issue Type: Task
> Reporter: Johan Parent
> Assigned To: Alejandro Guizar
>
> Remove useless null checks from often used methods to obtain:
> /**
> * more logging related database access.
> */
> public LoggingSession getLoggingSession() {
> PersistenceService persistenceService = getPersistenceService();
> return (persistenceService!=null ? persistenceService.getLoggingSession() : null);
> }
> /**
> * more messaging related database access.
> */
> public MessagingSession getMessagingSession() {
> PersistenceService persistenceService = getPersistenceService();
> return (persistenceService!=null ? persistenceService.getMessagingSession() : null);
> }
> /**
> * more scheduling related database access.
> */
> public SchedulerSession getSchedulerSession() {
> PersistenceService persistenceService = getPersistenceService();
> return (persistenceService!=null ? persistenceService.getSchedulerSession() : null);
> }
> /**
> * more graph (process) related database access.
> */
> public GraphSession getGraphSession() {
> PersistenceService persistenceService = getPersistenceService();
> return (persistenceService!=null ? persistenceService.getGraphSession() : null);
> }
> /**
> * more task related database access.
> */
> public TaskMgmtSession getTaskMgmtSession() {
> PersistenceService persistenceService = getPersistenceService();
> return (persistenceService!=null ? persistenceService.getTaskMgmtSession() : null);
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
16 years, 5 months
[JBoss JIRA] Assigned: (JBPM-1058) Remove useless null checks from JbpmContext methods
by Alejandro Guizar (JIRA)
[ http://jira.jboss.com/jira/browse/JBPM-1058?page=all ]
Alejandro Guizar reassigned JBPM-1058:
--------------------------------------
Assignee: Alejandro Guizar
> Remove useless null checks from JbpmContext methods
> ---------------------------------------------------
>
> Key: JBPM-1058
> URL: http://jira.jboss.com/jira/browse/JBPM-1058
> Project: JBoss jBPM
> Issue Type: Patch
> Reporter: Johan Parent
> Assigned To: Alejandro Guizar
>
> Remove useless null checks from often used methods to obtain:
> /**
> * more logging related database access.
> */
> public LoggingSession getLoggingSession() {
> PersistenceService persistenceService = getPersistenceService();
> return (persistenceService!=null ? persistenceService.getLoggingSession() : null);
> }
> /**
> * more messaging related database access.
> */
> public MessagingSession getMessagingSession() {
> PersistenceService persistenceService = getPersistenceService();
> return (persistenceService!=null ? persistenceService.getMessagingSession() : null);
> }
> /**
> * more scheduling related database access.
> */
> public SchedulerSession getSchedulerSession() {
> PersistenceService persistenceService = getPersistenceService();
> return (persistenceService!=null ? persistenceService.getSchedulerSession() : null);
> }
> /**
> * more graph (process) related database access.
> */
> public GraphSession getGraphSession() {
> PersistenceService persistenceService = getPersistenceService();
> return (persistenceService!=null ? persistenceService.getGraphSession() : null);
> }
> /**
> * more task related database access.
> */
> public TaskMgmtSession getTaskMgmtSession() {
> PersistenceService persistenceService = getPersistenceService();
> return (persistenceService!=null ? persistenceService.getTaskMgmtSession() : null);
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
16 years, 5 months
[JBoss JIRA] Created: (JBPM-1289) session is closed error, when letting jbpm cleate an hibernate session in a transactional environment
by Thomas Heute (JIRA)
session is closed error, when letting jbpm cleate an hibernate session in a transactional environment
-----------------------------------------------------------------------------------------------------
Key: JBPM-1289
URL: http://jira.jboss.com/jira/browse/JBPM-1289
Project: JBoss jBPM
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: Core Engine
Affects Versions: jBPM jPDL 3.2.2
Reporter: Thomas Heute
The following scenario seems to fail:
1) Open a Tx
2) Open a jbpmSession
--> jbpm will create a new Hibernate session in DBPersistenceService, and mark it to be close
3) do jbpm operation(s)
4) close the jbpm session
--> jbpm closes the Hibernate session
5) close the Tx
--> This will fail because of JobSession$DeleteJobsSynchronization which tries to execute operations with the now closed Hibernate session
org.hibernate.SessionException: Session is closed!
at org.hibernate.impl.AbstractSessionImpl.errorIfClosed(AbstractSessionImpl.java:49)
at org.hibernate.impl.SessionImpl.getNamedQuery(SessionImpl.java:1258)
at org.jbpm.db.JobSession$DeleteJobsSynchronization.beforeCompletion(JobSession.java:190)
This is a major issue for jbpm upgrade in JBoss Portal
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
16 years, 5 months