[JBoss JIRA] Created: (JBPM-1185) Node, State and ProcessState don't support Conditions on Transitions
by Britt Miner (JIRA)
Node, State and ProcessState don't support Conditions on Transitions
--------------------------------------------------------------------
Key: JBPM-1185
URL: http://jira.jboss.com/jira/browse/JBPM-1185
Project: JBoss jBPM
Issue Type: Bug
Components: Core Engine
Affects Versions: jBPM jPDL 3.2.2
Reporter: Britt Miner
Assigned To: Tom Baeyens
Node, State, and ProcessState don't provide any preliminary check for conditions provided on transitions. No check is performed until the transition is signaled, at which point the process will barf if a condition is present on the default transition, and that condition evaluates to false.
Regardless if a person "should" be using transition conditions in Node or State, the schema allows it, the documentation doesn't forbid it, and the current behavior of a Transition element in the jpdl is inconsistent. The fix to make everything consistent is fairly simple--only org.jbpm.graph.def.Node needs to really be altered (and a one-liner in ProcessState):
In org.jbpm.graph.def.Node, add the following method:
// BRITT--
public Transition calculateLeavingTransition(ExecutionContext executionContext) {
Transition transition = null;
boolean hasTransitioned = false;
Iterator iter = leavingTransitions.iterator();
while (iter.hasNext()) {
Transition candidate = (Transition) iter.next();
String conditionExpression = candidate.getCondition();
if (conditionExpression != null) {
Object result = JbpmExpressionEvaluator.evaluate(conditionExpression, executionContext);
if (Boolean.TRUE.equals(result)) {
transition = candidate;
}
} else {
transition = candidate;
}
}
if (!hasTransitioned) {
this.getDefaultLeavingTransition().removeConditionEnforcement();
log.warn("All transition conditions have evaluated to 'false'. Taking the default transition.");
transition = this.getDefaultLeavingTransition();
}
return transition;
}
// --BRITT
...and modify "leave(ExecutionContext executionContext)":
// BRITT --replace the following line with the code below
// to check conditions before selecting the transition to take...
//leave(executionContext, getDefaultLeavingTransition()); //original line
leave(executionContext, calculateLeavingTransition(executionContext));
// --BRITT
For consistency, ProcessState should also have one line modified at the very end of it's "leave(ExecutionContext, Transition)" method:
// BRITT-- rather than specify which transition, let the super class decide...
//super.leave(executionContext, getDefaultLeavingTransition());
super.leave(executionContext, calculateLeavingTransition(executionContext));
// --BRITT
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
15 years, 10 months
[JBoss JIRA] Created: (JBPM-2042) Add possibility to query failed Jobs
by Bernd Ruecker (JIRA)
Add possibility to query failed Jobs
------------------------------------
Key: JBPM-2042
URL: https://jira.jboss.org/jira/browse/JBPM-2042
Project: JBoss jBPM
Issue Type: Feature Request
Security Level: Public (Everyone can see)
Components: Core Engine
Reporter: Bernd Ruecker
Assignee: Bernd Ruecker
Priority: Minor
Fix For: jBPM 3.2.6 GA
The JobExecutor decrements the number of retries every time an exception is thrown during execution of jobs. The exception stacktrace is saved in the Jobs.
In the API (JobSession) I now add a method to query all failed jobs (where retries==0 and excpetion!=null) which will not be executed again by the JobExecutor.
I added the method "findFailedJobs", the hibernate named query "JobSession.findFailedJobs" and a test case for it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
15 years, 10 months
[JBoss JIRA] Created: (JBPM-2074) Fix intermittent problem with JbpmConfigurationTest.testDomainModelConfigsWithoutJbpmContext
by Thomas Diesler (JIRA)
Fix intermittent problem with JbpmConfigurationTest.testDomainModelConfigsWithoutJbpmContext
--------------------------------------------------------------------------------------------
Key: JBPM-2074
URL: https://jira.jboss.org/jira/browse/JBPM-2074
Project: JBoss jBPM
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: Core Engine
Reporter: Thomas Diesler
Fix For: jBPM 3.2.6 GA
It seems that some asynchronous process creates a JbpmContext
2009-02-28 19:53:53,895 DEBUG [org.jbpm.AbstractJbpmTestCase] ### START org.jbpm.JbpmConfigurationTest.testDomainModelConfigsWithoutJbpmContext ####################################################
2009-02-28 19:53:53,895 DEBUG [org.jbpm.configuration.ObjectFactoryImpl] adding object info 'jbpmConfiguration'
2009-02-28 19:53:53,895 DEBUG [org.jbpm.persistence.db.StaleObjectLogConfigurer] stale object exceptions are already hidden from logging
2009-02-28 19:53:53,896 DEBUG [org.jbpm.configuration.JbpmContextInfo] creating jbpm context with service factories '[message, tx, scheduler, authentication, persistence, logging]'
2009-02-28 19:53:53,896 DEBUG [org.jbpm.JbpmContext] creating org.jbpm.JbpmContext@1a7abed
2009-02-28 19:53:53,896 DEBUG [org.jbpm.JbpmContext] closing jbpmContext org.jbpm.JbpmContext@1a7abed
2009-02-28 19:53:53,896 INFO [org.hibernate.connection.DriverManagerConnectionProvider] cleaning up connection pool: jdbc:hsqldb:mem:jbpm
2009-02-28 19:53:53,897 DEBUG [org.jbpm.configuration.JbpmContextInfo] creating jbpm context with service factories '[message, tx, scheduler, authentication, persistence, logging]'
2009-02-28 19:53:53,897 DEBUG [org.jbpm.JbpmContext] creating org.jbpm.JbpmContext@1bfe151
2009-02-28 19:53:53,898 DEBUG [org.jbpm.JbpmContext] closing jbpmContext org.jbpm.JbpmContext@1bfe151
2009-02-28 19:53:53,898 DEBUG [org.jbpm.configuration.JbpmContextInfo] creating jbpm context with service factories '[message, tx, scheduler, authentication, persistence, logging]'
2009-02-28 19:53:53,898 DEBUG [org.jbpm.JbpmContext] creating org.jbpm.JbpmContext@10994db
2009-02-28 19:53:53,898 DEBUG [org.jbpm.JbpmContext] closing jbpmContext org.jbpm.JbpmContext@10994db
2009-02-28 19:53:53,899 DEBUG [org.jbpm.configuration.JbpmContextInfo] creating jbpm context with service factories '[]'
2009-02-28 19:53:53,899 DEBUG [org.jbpm.JbpmContext] creating org.jbpm.JbpmContext@1945b7a
2009-02-28 19:53:53,899 DEBUG [org.jbpm.JbpmContext] closing jbpmContext org.jbpm.JbpmContext@1945b7a
2009-02-28 19:53:53,901 DEBUG [org.jbpm.AbstractJbpmTestCase] ### END org.jbpm.JbpmConfigurationTest.testDomainModelConfigsWithoutJbpmContext ######################################################
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
15 years, 10 months
[JBoss JIRA] Commented: (JBPM-1210) spring configuration support
by Andries Inze (JIRA)
[ https://jira.jboss.org/jira/browse/JBPM-1210?page=com.atlassian.jira.plug... ]
Andries Inze commented on JBPM-1210:
------------------------------------
Changes have been committed to ainze branch.
> spring configuration support
> ----------------------------
>
> Key: JBPM-1210
> URL: https://jira.jboss.org/jira/browse/JBPM-1210
> Project: JBoss jBPM
> Issue Type: Feature Request
> Components: PVM
> Reporter: Tom Baeyens
> Assignee: Mauricio Salatino
> Priority: Minor
> Fix For: jBPM 4.0.x
>
> Attachments: spring-jbpm-24022009-patch.zip, spring-jbpm-v1.7z, spring-jbpm-v1.zip
>
>
> The first goal is to create an EnvironmentFactory implementation that is based on spring configuration.
> The class to complete is org.jbpm.pvm.internal.env.SpringEnvironmentFactory
> The SpringEnvironmentFactory should relate to a spring ApplicationContext, I believe. The first thing to do is create a test that shows how a spring configuration can be used to create hibernate sessions.
> Something like this:
> static EnvironmentFactory environmentFactory = SpringEnvironmentFactory.parseResource("org/jbpm/pvm/spring/springbeans.xml");
> Environment environment = environmentFactory.openEnvironment();
> try {
> Session hibernateSession = environment.get(Session.class);
> assertNotNull(hibernateSession);
> } finally {
> environment.close();
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
15 years, 10 months
[JBoss JIRA] Created: (JBPM-2051) Incorrect WARN messages for swimlanes
by Martin Putz (JIRA)
Incorrect WARN messages for swimlanes
-------------------------------------
Key: JBPM-2051
URL: https://jira.jboss.org/jira/browse/JBPM-2051
Project: JBoss jBPM
Issue Type: Bug
Security Level: Public (Everyone can see)
Affects Versions: jBPM 3.3.1 GA, jBPM-3.2.5.SP1
Reporter: Martin Putz
Assignee: Martin Putz
Fix For: jBPM 3.2.6 GA
Defining a swimlane in a processdefinition with an assignment that is not using a delegation class leads to incorrect WARN messages in the logs at process deploy time:
<swimlane name="test">
<assignment actor-id="admin" />
</swimlane>
WARN [JpdlXmlReader] process xml warning: swimlane 'test' does not have an assignment
WARN [JpdlXmlReader] process parse warning: swimlane 'test' does not have an assignment
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
15 years, 10 months