[
https://jira.jboss.org/jira/browse/JBPM-1775?page=com.atlassian.jira.plug...
]
Bernd Ruecker commented on JBPM-1775:
-------------------------------------
Hi.
The current commited fix doesn't work. The code isAbleToHandleExceptions has a bug,
this was the check made:
JbpmContext jbpmContext = executionContext.getJbpmContext();
if (jbpmContext != null) {
Services services = jbpmContext.getServices();
if (services != null) {
Service service = services.getPersistenceService();
if (service instanceof DbPersistenceService) {
DbPersistenceService persistenceService = (DbPersistenceService) service;
return persistenceService.isTransactionActive() ||
persistenceService.getTransaction() == null;
}
}
}
Unfortunately, the persistence.getTransaction() returns null in case the transaction is
marked for rollback (at least in our case). And persistenceService.isTransactionActive()
returns still true!
I changed the code (and committed) to
return persistenceService.getTransaction() != null &&
persistenceService.isTransactionActive();
But I guess it would be even better to do:
return persistenceService.getTransaction() != null &&
persistenceService.isTransactionActive() &&
!persistenceService.isTransactionRollbackOnly();
Or to change the isTransactionActive() implementation (which I didn't want to touch
;-)).
Maybe Alex can have a look on it?
verify if collection exceptionHandlers can be loaded lazy
---------------------------------------------------------
Key: JBPM-1775
URL:
https://jira.jboss.org/jira/browse/JBPM-1775
Project: JBoss jBPM
Issue Type: Task
Security Level: Public(Everyone can see)
Components: Runtime Engine
Reporter: Tom Baeyens
Assignee: Alejandro Guizar
Fix For: jBPM 3.3.1 GA
From Martin Putz:
"
A quick test showed that setting all those relations to lazy="true" cuts down
the number of executed SQL selects quite drastically.
I don't see any negative side effects of changing these settings, but I'm curious
about the reasons why lazy="false" is chosen as default. Especially as I
don't see a lot of our customers using exception handlers (or at least they don't
report it).
Regards,
Martin
"
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira