[jbpm-issues] [JBoss JIRA] Resolved: (JBPM-2964) Throw the exception on commit when both commit and rollback fail

Throw the exception on commit when both commit and rollback fail ---------------------------------------------------------------- Key: JBPM-2964 URL: https://jira.jboss.org/browse/JBPM-2964 Project: jBPM Issue Type: Bug Security Level: Public(Everyone can see) Components: Runtime Engine Affects Versions: jBPM 3.2.9 Reporter: Toshiya Kobayashi Assignee: Alejandro Guizar Fix For: jBPM 3.2.10 Attachments: JBPM-2964.patch Original Estimate: 0 minutes Remaining Estimate: 0 minutes In case that commit() throws an exception (e.g. StaleObjectStateException) in DbPersistenceService.endTransaction(), rollback() will be called. And then, if rollback() also throws an exception, a client application will get the latter exception (Usually, it would be java.lang.IllegalStateException: BaseTransaction.rollback - [com.arjuna.ats.internal.jta.transaction.arjunacore.notx] [com.arjuna.ats.internal.jta.transaction.arjunacore.notx] no transaction! ). public void endTransaction() { if (!isTransactionRollbackOnly()) { Exception commitException = commit(); if (commitException != null) { rollback(); closeSession(); closeConnection(); throw new JbpmPersistenceException("transaction commit failed", commitException); } } It is not a desirable behaviour. It's better to catch the exception on rollback, log it and throw the exception on commit.