[jbpm-issues] [JBoss JIRA] Commented: (JBPM-2904) allow slash in jpdl activity name
[
https://jira.jboss.org/browse/JBPM-2904?page=com.atlassian.jira.plugin.sy...
]
Maciej Swiderski commented on JBPM-2904:
----------------------------------------
In general it looks good to me. However I have few comments:
- please remove system.out.println statements from method
- why you use equals method to compare booleans?! isn't it enough to just use them in
if statement?
- perhaps it is worth mentioning it in docs as well
BTW, nice to see that you found a way to set this within configuration file
allow slash in jpdl activity name
---------------------------------
Key: JBPM-2904
URL: https://jira.jboss.org/browse/JBPM-2904
Project: jBPM
Issue Type: Patch
Security Level: Public(Everyone can see)
Components: Runtime Engine
Affects Versions: jBPM 4.3
Reporter: Huisheng Xu
Assignee: Huisheng Xu
Priority: Optional
Fix For: jBPM 4.4
Attachments: JBPM-2904.patch
Provide a parameter 'jbpm.activity.allow.slash' in jbpm.cfg.xml to decision
whether we should validate the activity name for whether or not allow contains slash(/).
Default is false, not allow slash(/) in activity name.
If someone want to use slash(/) in activity name, should set <true
name='jbpm.activity.allow.slash'/> in <process-engine-context>.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira