[jbpm-issues] [JBoss JIRA] Reopened: (JBPM-2630) JbpmConfiguration.popJbpmConfiguration() doesn't implement a pop operation

JbpmConfiguration.popJbpmConfiguration() doesn't implement a pop operation -------------------------------------------------------------------------- Key: JBPM-2630 URL: https://jira.jboss.org/jira/browse/JBPM-2630 Project: jBPM Issue Type: Bug Security Level: Public(Everyone can see) Components: Runtime Engine Affects Versions: jBPM 3.2.7, jBPM 3.2.8 Reporter: Toshiya Kobayashi Assignee: Alejandro Guizar Fix For: jBPM 3.2.9 Attachments: mylyn-context.zip Original Estimate: 0 minutes Remaining Estimate: 0 minutes org.jbpm.JbpmConfiguration.java: ===== synchronized void popJbpmConfiguration() { getJbpmConfigurationStack().remove(this); } ===== List.remove() can break ordering in the jbpmConfigurationStack, then eventually getCurrentJbpmConfiguration() will return an wrong jbpmConfiguration instance. (List.remove(java.lang.Object) behaves like FIFO if there are multiple elements which refer the same object) On the other hand, popJbpmContext() pops properly. ===== void popJbpmContext(JbpmContext jbpmContext) { List stack = getJbpmContextStack(); int size = stack.size(); if (size == 0) { ... } else if (jbpmContext != stack.remove(size - 1)) { ... } } =====