[JBoss JIRA] Created: (JBPM-2492) GetOutcomes returns an additional Outcome than what is already specified than the
4:37 p.m.
GetOutcomes returns an additional Outcome than what is already specified than the
----------------------------------------------------------------------------------
Key: JBPM-2492
URL: https://jira.jboss.org/jira/browse/JBPM-2492
Project: jBPM
Issue Type: Bug
Security Level: Public (Everyone can see)
Affects Versions: jBPM 4.0.CR1
Reporter: Shekhar Vemuri
Fix For: jBPM 4.1
Description is below:
It was decided in a discussion in the forum(referenced in this issue) that we would not
add the additional transition to the list of transitions that are available as part of
completing a task.
Problem:
Is there a particular reason for why GetOutComes does this?
Code:
Set<String> outcomes = new HashSet<String>();
outcomes.add(Task.STATE_COMPLETED);
.. logic to add other transitions specified in the activity.
When the TaskService.getOutComes(long taskDbId) is called with a task id it returns
completed as an entry in the list of Transitions that will eventually be shown to the
user.
But this particular transition is not even being modeled in the process_definition.
There are other places in the code, where in if a transition/outcome name is not specified
then the transition is assumed to the 'completed' and special handling is done,
Code:
if (Task.STATE_COMPLETED.equals(signalName)) {
if (outgoingTransitions.size()==1) {
transition = outgoingTransitions.get(0);
} else {
transition = activity.getDefaultOutgoingTransition();
}
}
The above snippet is from TaskActivity.
What is the reasoning behind adding this to the transitions that can be taken out of a
Task node?
_________________
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:34 a.m.
New subject: [JBoss JIRA] Updated: (JBPM-2492) GetOutcomes returns an additional Outcome than what is already specified than the
[
https://jira.jboss.org/jira/browse/JBPM-2492?page=com.atlassian.jira.plug...
]
Ronald van Kuijk updated JBPM-2492:
-----------------------------------
Fix Version/s: jBPM 4.2
(was: jBPM 4.1)
Sorry, but the jira freeze for 4.1 has already happend and the code freeze is near
(comming tuesday) since it is not trivial to fix (also needs console changes), it cannot
be included in 4.1
GetOutcomes returns an additional Outcome than what is already
specified than the
----------------------------------------------------------------------------------
Key: JBPM-2492
URL: https://jira.jboss.org/jira/browse/JBPM-2492
Project: jBPM
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: jBPM 4.0.CR1
Reporter: Shekhar Vemuri
Fix For: jBPM 4.2
Description is below:
It was decided in a discussion in the forum(referenced in this issue) that we would not
add the additional transition to the list of transitions that are available as part of
completing a task.
Problem:
Is there a particular reason for why GetOutComes does this?
Code:
Set<String> outcomes = new HashSet<String>();
outcomes.add(Task.STATE_COMPLETED);
.. logic to add other transitions specified in the activity.
When the TaskService.getOutComes(long taskDbId) is called with a task id it returns
completed as an entry in the list of Transitions that will eventually be shown to the
user.
But this particular transition is not even being modeled in the process_definition.
There are other places in the code, where in if a transition/outcome name is not
specified then the transition is assumed to the 'completed' and special handling
is done,
Code:
if (Task.STATE_COMPLETED.equals(signalName)) {
if (outgoingTransitions.size()==1) {
transition = outgoingTransitions.get(0);
} else {
transition = activity.getDefaultOutgoingTransition();
}
}
The above snippet is from TaskActivity.
What is the reasoning behind adding this to the transitions that can be taken out of a
Task node?
_________________
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:23 a.m.
New subject: [JBoss JIRA] Commented: (JBPM-2492) GetOutcomes returns an additional Outcome than what is already specified than the
[
https://jira.jboss.org/jira/browse/JBPM-2492?page=com.atlassian.jira.plug...
]
Tom Baeyens commented on JBPM-2492:
-----------------------------------
Here's how we want to change the outcomes handling:
The strategy that we propose is that we couple the outcomes to the outgoing transition
names directly. So transitions without a name will match with the outcome value of null.
If no outcome will be specified with completing a task, null will be used as outcome and
hence it will bind to the first transition without a name. The getOutcomes method will
return null values for transitions without name. In the jBPM web console, the null values
from the getOutcomes will be mapped to a default transition button name like
"Completed".
a) suppose task has one outgoing transition without a name
then:
- getOutcomes() returns a collection that includes one null value
- taskService.completeTask(taskId) will take that outgoing transition
- taskService.completeTask(taskId, null) will take that outgoing transition
- taskService.completeTask(taskId, "anyvalue") will result in an exception
b) suppose task has one outgoing transition with name 'Accept'
then:
- getOutcomes() returns a collection that includes one 'Accept' value
- taskService.completeTask(taskId) will result in an exception (as there is no transition
without a name)
- taskService.completeTask(taskId, null) will will result in an exception (as there is no
transition without a name)
- taskService.completeTask(taskId, "anyvalue") will result in an exception
- taskService.completeTask(taskId, "Accept") will take the 'Accept'
transition
c) suppose a task has multiple outgoing transitions. one without a name and one with name
'Reject'
- getOutcomes() returns a collection that includes a null value and 'Accept'
- taskService.completeTask(taskId) will take the transition without a name
- taskService.completeTask(taskId, null) will take the transition without a name
- taskService.completeTask(taskId, "anyvalue") will result in an exception
- taskService.completeTask(taskId, "Reject") will take the 'Reject'
transition
d) suppose a task has multiple outgoing transitions. one called 'Accept', one
called 'Reject' and no transition without a name
- getOutcomes() returns a collection that includes 'Accept' and 'Reject'
- taskService.completeTask(taskId) will result in an exception
- taskService.completeTask(taskId, null) will result in an exception
- taskService.completeTask(taskId, "anyvalue") will result in an exception
- taskService.completeTask(taskId, "Accept") will take the 'Accept'
transition
- taskService.completeTask(taskId, "Reject") will take the 'Reject'
transition
GetOutcomes returns an additional Outcome than what is already
specified than the
----------------------------------------------------------------------------------
Key: JBPM-2492
URL: https://jira.jboss.org/jira/browse/JBPM-2492
Project: jBPM
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: jBPM 4.0.CR1
Reporter: Shekhar Vemuri
Assignee: Tom Baeyens
Fix For: jBPM 4.2
Description is below:
It was decided in a discussion in the forum(referenced in this issue) that we would not
add the additional transition to the list of transitions that are available as part of
completing a task.
Problem:
Is there a particular reason for why GetOutComes does this?
Code:
Set<String> outcomes = new HashSet<String>();
outcomes.add(Task.STATE_COMPLETED);
.. logic to add other transitions specified in the activity.
When the TaskService.getOutComes(long taskDbId) is called with a task id it returns
completed as an entry in the list of Transitions that will eventually be shown to the
user.
But this particular transition is not even being modeled in the process_definition.
There are other places in the code, where in if a transition/outcome name is not
specified then the transition is assumed to the 'completed' and special handling
is done,
Code:
if (Task.STATE_COMPLETED.equals(signalName)) {
if (outgoingTransitions.size()==1) {
transition = outgoingTransitions.get(0);
} else {
transition = activity.getDefaultOutgoingTransition();
}
}
The above snippet is from TaskActivity.
What is the reasoning behind adding this to the transitions that can be taken out of a
Task node?
_________________
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:36 a.m.
New subject: [JBoss JIRA] Updated: (JBPM-2492) GetOutcomes returns an additional Outcome than what is already specified than the
[
https://jira.jboss.org/jira/browse/JBPM-2492?page=com.atlassian.jira.plug...
]
Tom Baeyens updated JBPM-2492:
------------------------------
Priority: Minor (was: Major)
GetOutcomes returns an additional Outcome than what is already
specified than the
----------------------------------------------------------------------------------
Key: JBPM-2492
URL: https://jira.jboss.org/jira/browse/JBPM-2492
Project: jBPM
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: jBPM 4.0.CR1
Reporter: Shekhar Vemuri
Assignee: Tom Baeyens
Priority: Minor
Fix For: jBPM 4.2
Description is below:
It was decided in a discussion in the forum(referenced in this issue) that we would not
add the additional transition to the list of transitions that are available as part of
completing a task.
Problem:
Is there a particular reason for why GetOutComes does this?
Code:
Set<String> outcomes = new HashSet<String>();
outcomes.add(Task.STATE_COMPLETED);
.. logic to add other transitions specified in the activity.
When the TaskService.getOutComes(long taskDbId) is called with a task id it returns
completed as an entry in the list of Transitions that will eventually be shown to the
user.
But this particular transition is not even being modeled in the process_definition.
There are other places in the code, where in if a transition/outcome name is not
specified then the transition is assumed to the 'completed' and special handling
is done,
Code:
if (Task.STATE_COMPLETED.equals(signalName)) {
if (outgoingTransitions.size()==1) {
transition = outgoingTransitions.get(0);
} else {
transition = activity.getDefaultOutgoingTransition();
}
}
The above snippet is from TaskActivity.
What is the reasoning behind adding this to the transitions that can be taken out of a
Task node?
_________________
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:50 a.m.
New subject: [JBoss JIRA] Updated: (JBPM-2492) improve task outcomes
[
https://jira.jboss.org/jira/browse/JBPM-2492?page=com.atlassian.jira.plug...
]
Tom Baeyens updated JBPM-2492:
------------------------------
Summary: improve task outcomes (was: GetOutcomes returns an additional
Outcome than what is already specified than the )
Original Estimate: 2 days
Remaining Estimate: 2 days
improve task outcomes
---------------------
Key: JBPM-2492
URL: https://jira.jboss.org/jira/browse/JBPM-2492
Project: jBPM
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: jBPM 4.0.CR1
Reporter: Shekhar Vemuri
Assignee: Tom Baeyens
Priority: Minor
Fix For: jBPM 4.2
Original Estimate: 2 days
Remaining Estimate: 2 days
Description is below:
It was decided in a discussion in the forum(referenced in this issue) that we would not
add the additional transition to the list of transitions that are available as part of
completing a task.
Problem:
Is there a particular reason for why GetOutComes does this?
Code:
Set<String> outcomes = new HashSet<String>();
outcomes.add(Task.STATE_COMPLETED);
.. logic to add other transitions specified in the activity.
When the TaskService.getOutComes(long taskDbId) is called with a task id it returns
completed as an entry in the list of Transitions that will eventually be shown to the
user.
But this particular transition is not even being modeled in the process_definition.
There are other places in the code, where in if a transition/outcome name is not
specified then the transition is assumed to the 'completed' and special handling
is done,
Code:
if (Task.STATE_COMPLETED.equals(signalName)) {
if (outgoingTransitions.size()==1) {
transition = outgoingTransitions.get(0);
} else {
transition = activity.getDefaultOutgoingTransition();
}
}
The above snippet is from TaskActivity.
What is the reasoning behind adding this to the transitions that can be taken out of a
Task node?
_________________
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:07 a.m.
New subject: [JBoss JIRA] Updated: (JBPM-2492) improve task outcomes
[
https://jira.jboss.org/jira/browse/JBPM-2492?page=com.atlassian.jira.plug...
]
Tom Baeyens updated JBPM-2492:
------------------------------
Fix Version/s: jBPM 4.3
(was: jBPM 4.2)
improve task outcomes
---------------------
Key: JBPM-2492
URL: https://jira.jboss.org/jira/browse/JBPM-2492
Project: jBPM
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: jBPM 4.0.CR1
Reporter: Shekhar Vemuri
Assignee: Tom Baeyens
Priority: Minor
Fix For: jBPM 4.3
Original Estimate: 2 days
Remaining Estimate: 2 days
Description is below:
It was decided in a discussion in the forum(referenced in this issue) that we would not
add the additional transition to the list of transitions that are available as part of
completing a task.
Problem:
Is there a particular reason for why GetOutComes does this?
Code:
Set<String> outcomes = new HashSet<String>();
outcomes.add(Task.STATE_COMPLETED);
.. logic to add other transitions specified in the activity.
When the TaskService.getOutComes(long taskDbId) is called with a task id it returns
completed as an entry in the list of Transitions that will eventually be shown to the
user.
But this particular transition is not even being modeled in the process_definition.
There are other places in the code, where in if a transition/outcome name is not
specified then the transition is assumed to the 'completed' and special handling
is done,
Code:
if (Task.STATE_COMPLETED.equals(signalName)) {
if (outgoingTransitions.size()==1) {
transition = outgoingTransitions.get(0);
} else {
transition = activity.getDefaultOutgoingTransition();
}
}
The above snippet is from TaskActivity.
What is the reasoning behind adding this to the transitions that can be taken out of a
Task node?
_________________
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:22 a.m.
New subject: [JBoss JIRA] Assigned: (JBPM-2492) improve task outcomes
[
https://jira.jboss.org/jira/browse/JBPM-2492?page=com.atlassian.jira.plug...
]
Tom Baeyens reassigned JBPM-2492:
---------------------------------
Assignee: Joram Barrez (was: Tom Baeyens)
improve task outcomes
---------------------
Key: JBPM-2492
URL: https://jira.jboss.org/jira/browse/JBPM-2492
Project: jBPM
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: jBPM 4.0.CR1
Reporter: Shekhar Vemuri
Assignee: Joram Barrez
Priority: Minor
Fix For: jBPM 4.3
Original Estimate: 2 days
Remaining Estimate: 2 days
Description is below:
It was decided in a discussion in the forum(referenced in this issue) that we would not
add the additional transition to the list of transitions that are available as part of
completing a task.
Problem:
Is there a particular reason for why GetOutComes does this?
Code:
Set<String> outcomes = new HashSet<String>();
outcomes.add(Task.STATE_COMPLETED);
.. logic to add other transitions specified in the activity.
When the TaskService.getOutComes(long taskDbId) is called with a task id it returns
completed as an entry in the list of Transitions that will eventually be shown to the
user.
But this particular transition is not even being modeled in the process_definition.
There are other places in the code, where in if a transition/outcome name is not
specified then the transition is assumed to the 'completed' and special handling
is done,
Code:
if (Task.STATE_COMPLETED.equals(signalName)) {
if (outgoingTransitions.size()==1) {
transition = outgoingTransitions.get(0);
} else {
transition = activity.getDefaultOutgoingTransition();
}
}
The above snippet is from TaskActivity.
What is the reasoning behind adding this to the transitions that can be taken out of a
Task node?
_________________
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:11 a.m.
New subject: [JBoss JIRA] Commented: (JBPM-2492) improve task outcomes
[
https://jira.jboss.org/jira/browse/JBPM-2492?page=com.atlassian.jira.plug...
]
Joram Barrez commented on JBPM-2492:
------------------------------------
Changes after lengthy discussion with Tom and Bernd:
b) suppose task has one outgoing transition with name 'Accept' then:
- taskService.completeTask(taskId) will take the single outgoing transition
d) suppose a task has multiple outgoing transitions. one called 'Accept', one
called 'Reject' and no transition without a name
- taskService.completeTask(taskId) will result in an exception
--> We're throwing an exception in the second case since this is likely a
programmatic error.
In the first case, it's unlikely to be a programmatic error since there is only one
outgoing transition
improve task outcomes
---------------------
Key: JBPM-2492
URL: https://jira.jboss.org/jira/browse/JBPM-2492
Project: jBPM
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: jBPM 4.0.CR1
Reporter: Shekhar Vemuri
Assignee: Joram Barrez
Priority: Minor
Fix For: jBPM 4.3
Original Estimate: 2 days
Remaining Estimate: 2 days
Description is below:
It was decided in a discussion in the forum(referenced in this issue) that we would not
add the additional transition to the list of transitions that are available as part of
completing a task.
Problem:
Is there a particular reason for why GetOutComes does this?
Code:
Set<String> outcomes = new HashSet<String>();
outcomes.add(Task.STATE_COMPLETED);
.. logic to add other transitions specified in the activity.
When the TaskService.getOutComes(long taskDbId) is called with a task id it returns
completed as an entry in the list of Transitions that will eventually be shown to the
user.
But this particular transition is not even being modeled in the process_definition.
There are other places in the code, where in if a transition/outcome name is not
specified then the transition is assumed to the 'completed' and special handling
is done,
Code:
if (Task.STATE_COMPLETED.equals(signalName)) {
if (outgoingTransitions.size()==1) {
transition = outgoingTransitions.get(0);
} else {
transition = activity.getDefaultOutgoingTransition();
}
}
The above snippet is from TaskActivity.
What is the reasoning behind adding this to the transitions that can be taken out of a
Task node?
_________________
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:32 a.m.
New subject: [JBoss JIRA] Resolved: (JBPM-2492) improve task outcomes
[
https://jira.jboss.org/jira/browse/JBPM-2492?page=com.atlassian.jira.plug...
]
Joram Barrez resolved JBPM-2492.
--------------------------------
Resolution: Done
improve task outcomes
---------------------
Key: JBPM-2492
URL: https://jira.jboss.org/jira/browse/JBPM-2492
Project: jBPM
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: jBPM 4.0.CR1
Reporter: Shekhar Vemuri
Assignee: Joram Barrez
Priority: Minor
Fix For: jBPM 4.3
Original Estimate: 2 days
Remaining Estimate: 2 days
Description is below:
It was decided in a discussion in the forum(referenced in this issue) that we would not
add the additional transition to the list of transitions that are available as part of
completing a task.
Problem:
Is there a particular reason for why GetOutComes does this?
Code:
Set<String> outcomes = new HashSet<String>();
outcomes.add(Task.STATE_COMPLETED);
.. logic to add other transitions specified in the activity.
When the TaskService.getOutComes(long taskDbId) is called with a task id it returns
completed as an entry in the list of Transitions that will eventually be shown to the
user.
But this particular transition is not even being modeled in the process_definition.
There are other places in the code, where in if a transition/outcome name is not
specified then the transition is assumed to the 'completed' and special handling
is done,
Code:
if (Task.STATE_COMPLETED.equals(signalName)) {
if (outgoingTransitions.size()==1) {
transition = outgoingTransitions.get(0);
} else {
transition = activity.getDefaultOutgoingTransition();
}
}
The above snippet is from TaskActivity.
What is the reasoning behind adding this to the transitions that can be taken out of a
Task node?
_________________
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5514
days inactive
5625
days old
8 comments
4 participants
participants (4)
-
Joram Barrez (JIRA) -
Ronald van Kuijk (JIRA)
-
Shekhar Vemuri (JIRA)
-
Tom Baeyens (JIRA)