5:25 a.m.
Custom mail producer can not be a spring bean
---------------------------------------------
Key: JBPM-2891
URL: https://jira.jboss.org/browse/JBPM-2891
Project: jBPM
Issue Type: Patch
Security Level: Public (Everyone can see)
Components: Runtime Engine
Reporter: Marta Psenkova
Attachments: custom_mail_producer_expr.pvm.r6398.patch
It is not possible to put spring beans or expressions to custom mail producer, e.g.:
<notification expr="#{jbpmCustomMailProducer}">
<field name="templateName"><string
value="planning-approval-start-notifcation"/></field>
</notification>
this won't work, because only factory or class is allowed, but not expr.
The solution here is to allow it :)
See patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:25 a.m.
New subject: [JBoss JIRA] Updated: (JBPM-2891) Custom mail producer can not be a spring bean
[
https://jira.jboss.org/browse/JBPM-2891?page=com.atlassian.jira.plugin.sy...
]
Marta Psenkova updated JBPM-2891:
---------------------------------
Attachment: custom_mail_producer_expr.pvm.r6398.patch
implementation for jBPM4 - pvm project
Custom mail producer can not be a spring bean
---------------------------------------------
Key: JBPM-2891
URL: https://jira.jboss.org/browse/JBPM-2891
Project: jBPM
Issue Type: Patch
Security Level: Public(Everyone can see)
Components: Runtime Engine
Reporter: Marta Psenkova
Attachments: custom_mail_producer_expr.pvm.r6398.patch
It is not possible to put spring beans or expressions to custom mail producer, e.g.:
<notification expr="#{jbpmCustomMailProducer}">
<field name="templateName"><string
value="planning-approval-start-notifcation"/></field>
</notification>
this won't work, because only factory or class is allowed, but not expr.
The solution here is to allow it :)
See patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:36 a.m.
New subject: [JBoss JIRA] Updated: (JBPM-2891) Custom mail producer can not be a spring bean
[
https://jira.jboss.org/browse/JBPM-2891?page=com.atlassian.jira.plugin.sy...
]
Marta Psenkova updated JBPM-2891:
---------------------------------
Fix Version/s: jBPM 4.4
Affects Version/s: jBPM 4.3
Custom mail producer can not be a spring bean
---------------------------------------------
Key: JBPM-2891
URL: https://jira.jboss.org/browse/JBPM-2891
Project: jBPM
Issue Type: Patch
Security Level: Public(Everyone can see)
Components: Runtime Engine
Affects Versions: jBPM 4.3
Reporter: Marta Psenkova
Fix For: jBPM 4.4
Attachments: custom_mail_producer_expr.pvm.r6398.patch
It is not possible to put spring beans or expressions to custom mail producer, e.g.:
<notification expr="#{jbpmCustomMailProducer}">
<field name="templateName"><string
value="planning-approval-start-notifcation"/></field>
</notification>
this won't work, because only factory or class is allowed, but not expr.
The solution here is to allow it :)
See patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:45 a.m.
New subject: [JBoss JIRA] Commented: (JBPM-2891) Custom mail producer can not be a spring bean
[
https://jira.jboss.org/browse/JBPM-2891?page=com.atlassian.jira.plugin.sy...
]
Maciej Swiderski commented on JBPM-2891:
----------------------------------------
In fact there is a way to inject custom mail producer on runtime using factory syntax.
There needs to be some additional stuff added to the CustomMailProducer class (method that
will return itself).
Here is an example how to achieve this:
<notification method="getMailProducer">
<factory><ref object="mailProducer"/></factory>
</notification>
Assumptions:
- your custom mail producer class has a method getMailProducer that returns itself of type
MailProducer
- under name 'mailProducer' there is a variable that is your custom mail producer
filled in with all required stuff such as templates or capable of fetching default
templates from the environment
I have not tried that in Spring environment but in regular one it works fine.
HTH
Custom mail producer can not be a spring bean
---------------------------------------------
Key: JBPM-2891
URL: https://jira.jboss.org/browse/JBPM-2891
Project: jBPM
Issue Type: Patch
Security Level: Public(Everyone can see)
Components: Runtime Engine
Affects Versions: jBPM 4.3
Reporter: Marta Psenkova
Fix For: jBPM 4.4
Attachments: custom_mail_producer_expr.pvm.r6398.patch
It is not possible to put spring beans or expressions to custom mail producer, e.g.:
<notification expr="#{jbpmCustomMailProducer}">
<field name="templateName"><string
value="planning-approval-start-notifcation"/></field>
</notification>
this won't work, because only factory or class is allowed, but not expr.
The solution here is to allow it :)
See patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:02 p.m.
New subject: [JBoss JIRA] Updated: (JBPM-2891) Custom mail producer can not be a spring bean
[
https://jira.jboss.org/browse/JBPM-2891?page=com.atlassian.jira.plugin.sy...
]
Huisheng Xu updated JBPM-2891:
------------------------------
Attachment: JBPM-2891.patch
Custom mail producer can not be a spring bean
---------------------------------------------
Key: JBPM-2891
URL: https://jira.jboss.org/browse/JBPM-2891
Project: jBPM
Issue Type: Patch
Security Level: Public(Everyone can see)
Components: Runtime Engine
Affects Versions: jBPM 4.3
Reporter: Marta Psenkova
Fix For: jBPM 4.4
Attachments: custom_mail_producer_expr.pvm.r6398.patch, JBPM-2891.patch
It is not possible to put spring beans or expressions to custom mail producer, e.g.:
<notification expr="#{jbpmCustomMailProducer}">
<field name="templateName"><string
value="planning-approval-start-notifcation"/></field>
</notification>
this won't work, because only factory or class is allowed, but not expr.
The solution here is to allow it :)
See patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:10 p.m.
New subject: [JBoss JIRA] Commented: (JBPM-2891) Custom mail producer can not be a spring bean
[
https://jira.jboss.org/browse/JBPM-2891?page=com.atlassian.jira.plugin.sy...
]
Huisheng Xu commented on JBPM-2891:
-----------------------------------
The problem is isObjectDescriptor() of ObjectBinding didn't allow using expr for
notification, so it won't evaluate expr for CustomMailProducer, Even if we didn't
use spring bean, we couldn't use custom mailProducer by expr.
I attach the patch and testcase.
Custom mail producer can not be a spring bean
---------------------------------------------
Key: JBPM-2891
URL: https://jira.jboss.org/browse/JBPM-2891
Project: jBPM
Issue Type: Patch
Security Level: Public(Everyone can see)
Components: Runtime Engine
Affects Versions: jBPM 4.3
Reporter: Marta Psenkova
Fix For: jBPM 4.4
Attachments: custom_mail_producer_expr.pvm.r6398.patch, JBPM-2891.patch
It is not possible to put spring beans or expressions to custom mail producer, e.g.:
<notification expr="#{jbpmCustomMailProducer}">
<field name="templateName"><string
value="planning-approval-start-notifcation"/></field>
</notification>
this won't work, because only factory or class is allowed, but not expr.
The solution here is to allow it :)
See patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:14 a.m.
New subject: [JBoss JIRA] Commented: (JBPM-2891) Custom mail producer can not be a spring bean
[
https://jira.jboss.org/browse/JBPM-2891?page=com.atlassian.jira.plugin.sy...
]
Maciej Swiderski commented on JBPM-2891:
----------------------------------------
Yes, I tested that with expr (same as your patch) I was just wondering if there should be
expr added to the ObjectBinding?!
I think that if you add another attribute to notification, template for instance you will
get schema validation exception.
Custom mail producer can not be a spring bean
---------------------------------------------
Key: JBPM-2891
URL: https://jira.jboss.org/browse/JBPM-2891
Project: jBPM
Issue Type: Patch
Security Level: Public(Everyone can see)
Components: Runtime Engine
Affects Versions: jBPM 4.3
Reporter: Marta Psenkova
Fix For: jBPM 4.4
Attachments: custom_mail_producer_expr.pvm.r6398.patch, JBPM-2891.patch
It is not possible to put spring beans or expressions to custom mail producer, e.g.:
<notification expr="#{jbpmCustomMailProducer}">
<field name="templateName"><string
value="planning-approval-start-notifcation"/></field>
</notification>
this won't work, because only factory or class is allowed, but not expr.
The solution here is to allow it :)
See patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:42 p.m.
New subject: [JBoss JIRA] Commented: (JBPM-2891) Custom mail producer can not be a spring bean
[
https://jira.jboss.org/browse/JBPM-2891?page=com.atlassian.jira.plugin.sy...
]
Huisheng Xu commented on JBPM-2891:
-----------------------------------
As expr is a common attribute of ObjectDescriptor, isObjectDescriptor() should return
true, if there is expr attribute on an element.
The template attribute isn't a common attribute for object descriptor element, As I
knew, the template attribute is an attribute of mail complex type.
Custom mail producer can not be a spring bean
---------------------------------------------
Key: JBPM-2891
URL: https://jira.jboss.org/browse/JBPM-2891
Project: jBPM
Issue Type: Patch
Security Level: Public(Everyone can see)
Components: Runtime Engine
Affects Versions: jBPM 4.3
Reporter: Marta Psenkova
Fix For: jBPM 4.4
Attachments: custom_mail_producer_expr.pvm.r6398.patch, JBPM-2891.patch
It is not possible to put spring beans or expressions to custom mail producer, e.g.:
<notification expr="#{jbpmCustomMailProducer}">
<field name="templateName"><string
value="planning-approval-start-notifcation"/></field>
</notification>
this won't work, because only factory or class is allowed, but not expr.
The solution here is to allow it :)
See patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:13 a.m.
New subject: [JBoss JIRA] Commented: (JBPM-2891) Custom mail producer can not be a spring bean
[
https://jira.jboss.org/browse/JBPM-2891?page=com.atlassian.jira.plugin.sy...
]
Maciej Swiderski commented on JBPM-2891:
----------------------------------------
fair enough HuiSheng, then go for it. I wanted to make sure we're doing the right
thing. Cheers
Custom mail producer can not be a spring bean
---------------------------------------------
Key: JBPM-2891
URL: https://jira.jboss.org/browse/JBPM-2891
Project: jBPM
Issue Type: Patch
Security Level: Public(Everyone can see)
Components: Runtime Engine
Affects Versions: jBPM 4.3
Reporter: Marta Psenkova
Fix For: jBPM 4.4
Attachments: custom_mail_producer_expr.pvm.r6398.patch, JBPM-2891.patch
It is not possible to put spring beans or expressions to custom mail producer, e.g.:
<notification expr="#{jbpmCustomMailProducer}">
<field name="templateName"><string
value="planning-approval-start-notifcation"/></field>
</notification>
this won't work, because only factory or class is allowed, but not expr.
The solution here is to allow it :)
See patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:48 a.m.
New subject: [JBoss JIRA] Resolved: (JBPM-2891) Custom mail producer can not be a spring bean
[
https://jira.jboss.org/browse/JBPM-2891?page=com.atlassian.jira.plugin.sy...
]
Huisheng Xu resolved JBPM-2891.
-------------------------------
Assignee: Huisheng Xu
Resolution: Done
checked in r6464
Custom mail producer can not be a spring bean
---------------------------------------------
Key: JBPM-2891
URL: https://jira.jboss.org/browse/JBPM-2891
Project: jBPM
Issue Type: Patch
Security Level: Public(Everyone can see)
Components: Runtime Engine
Affects Versions: jBPM 4.3
Reporter: Marta Psenkova
Assignee: Huisheng Xu
Fix For: jBPM 4.4
Attachments: custom_mail_producer_expr.pvm.r6398.patch, JBPM-2891.patch
It is not possible to put spring beans or expressions to custom mail producer, e.g.:
<notification expr="#{jbpmCustomMailProducer}">
<field name="templateName"><string
value="planning-approval-start-notifcation"/></field>
</notification>
this won't work, because only factory or class is allowed, but not expr.
The solution here is to allow it :)
See patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5057
days inactive
5078
days old
9 comments
3 participants
participants (3)
-
Huisheng Xu (JIRA) -
Maciej Swiderski (JIRA)
-
Marta Psenkova (JIRA)