[
http://jira.jboss.com/jira/browse/JBPM-1194?page=all ]
Ronald van Kuijk updated JBPM-1194:
-----------------------------------
Priority: Minor (was: Major)
First I think the subject is incorrect. EL expressionevaluation *is* in mail templates,
just not in the attributes of the variable value element. Correct?
Besides that, if you want *specific* subjects, you can set those in the template and
override the default one. The fact that the default currently only is static is not a big
deal imo. The advantage only comes in when using complex EL in many places.
Thirdly, I'd make a totally different patch and change the mailvariableresolver to
parse the value of the value attribute as an EL and not do it in the getters as you do
now
Enable variable reference evaluation in Mail Templates
------------------------------------------------------
Key: JBPM-1194
URL:
http://jira.jboss.com/jira/browse/JBPM-1194
Project: JBoss jBPM
Issue Type: Patch
Components: Core Engine
Affects Versions: jBPM jPDL 3.2
Reporter: Matthias Grossmann
Assigned To: Tom Baeyens
Priority: Minor
Changes in org.jbpm.mail.Mail:
public String getSubject() {
if (subject==null) return null;
Object parsedValue = null;
String ret = subject;
do {
ret = evaluate(ret);
ret = JbpmExpressionEvaluator.translateExpressionToDollars(ret);
parsedValue = new ExpressionEvaluatorImpl().parseExpressionString(ret);
} while (!(parsedValue instanceof String));
return ret;
}
public String getText() {
if (text==null) return null;
Object parsedValue = null;
String ret = text;
do {
ret = evaluate(ret);
ret = JbpmExpressionEvaluator.translateExpressionToDollars(ret);
parsedValue = new ExpressionEvaluatorImpl().parseExpressionString(ret);
} while (!(parsedValue instanceof String));
return ret;
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira