[ http://jira.jboss.com/jira/browse/JBPM-1183?page=comments#action_12415467 ] Britt Miner commented on JBPM-1183: ----------------------------------- Also note that placing code similar to this in the "leave(ExecutionContext)" method allows all Node subclasses to inherit a consistent, predictable handling of Transition Conditions. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBPM-1183?page=comments#action_12415469 ] Britt Miner commented on JBPM-1183: ----------------------------------- Of course, another way to handle this is to implement this code in the getDefaultLeavingTransition() method instead--but I didn't want to suggest changing the definition of what a "default" transition is. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBPM-1183?page=all ] Britt Miner updated JBPM-1183: ------------------------------ Description: Node and State don't provide any preliminary check for conditions provided on transitions. No check is performed until the transition is signaled, at which point the process will barf if the condition evaluates to false. Regardless if a person "should" be using transition conditions in Node or State, the schema allows it, the documentation doesn't forbid it, and the current behavior of a Transition element in the jpdl is inconsistent. The fix to make everything consistent is fairly simple--only org.jbpm.graph.def.Node needs to be altered: Add the following method: // BRITT-- public Transition calculateLeavingTransition(ExecutionContext executionContext) { Transition transition = null; boolean hasTransitioned = false; Iterator iter = leavingTransitions.iterator(); while (iter.hasNext()) { Transition candidate = (Transition) iter.next(); String conditionExpression = candidate.getCondition(); if (conditionExpression != null) { Object result = JbpmExpressionEvaluator.evaluate(conditionExpression, executionContext); if (Boolean.TRUE.equals(result)) { transition = candidate; } } else { transition = candidate; } } if (!hasTransitioned) { this.getDefaultLeavingTransition().removeConditionEnforcement(); log.warn("All transition conditions have evaluated to 'false'. Taking the default transition."); transition = this.getDefaultLeavingTransition(); } return transition; } // --BRITT ...and modify "leave(ExecutionContext executionContext)": // BRITT --replace the following line with the code below // to check conditions before selecting the transition to take... //leave(executionContext, getDefaultLeavingTransition()); //original line leave(executionContext, calculateLeavingTransition(executionContext)); // --BRITT For consistency, ProcessState should also have one line modified at the very end of it's "leave(ExecutionContext, Transition)" method: // BRITT-- rather than specify which transition, let the super class decide... //super.leave(executionContext, getDefaultLeavingTransition()); super.leave(executionContext, calculateLeavingTransition(executionContext)); // --BRITT was: Node and State don't provide any preliminary check for conditions provided on transitions. No check is performed until the transition is signaled, at which point the process will barf if the condition evaluates to false. Regardless if a person "should" be using transition conditions in Node or State, the schema allows it, the documentation doesn't forbid it, and the current behavior of a Transition element in the jpdl is inconsistent. The fix to make everything consistent is fairly simple--only org.jbpm.graph.def.Node needs to be altered: // BRITT --replace the following line with the code below // to check conditions before selecting the transition to take... //leave(executionContext, getDefaultLeavingTransition());//original line boolean hasTransitioned = false; Iterator iter = leavingTransitions.iterator(); while (iter.hasNext()) { Transition candidate = (Transition) iter.next(); String conditionExpression = candidate.getCondition(); if (conditionExpression != null) { Object result = JbpmExpressionEvaluator.evaluate(conditionExpression, executionContext); if (Boolean.TRUE.equals(result)) { leave(executionContext, candidate); hasTransitioned = true; break; } } else { leave(executionContext, candidate); hasTransitioned = true; break; } } if (!hasTransitioned) { this.getDefaultLeavingTransition().removeConditionEnforcement(); log.warn("All transition conditions have evaluated to 'false'. Taking the default transition."); leave(executionContext, this.getDefaultLeavingTransition()); } // --BRITT -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira