[ http://jira.jboss.com/jira/browse/JBPM-1072?page=comments#action_12398846 ] Alejandro Guizar commented on JBPM-1072: ---------------------------------------- Consider the following code. protected Collection acquireJobs() { Collection acquiredJobs = null; log.debug("acquiring jobs for execution..."); JbpmContext jbpmContext = jbpmConfiguration.createJbpmContext(); try { try { ... } finally { jbpmContext.close(); } acquiredJobs = jobsToLock; log.debug("obtained locks on following jobs: "+acquiredJobs); } catch (StaleStateException e) { log.debug("couldn't acquire lock on job(s): "+jobsToLock); } return acquiredJobs; } The catch block is never executed if a StaleStateException is thrown inside jbpmContext.close(). This is because: 1) DbPersistenceService.close() catches it, rolls back the transaction and wraps it into a JbpmPersistenceException 12:09:42,687 [JbpmJobExector:192.168.125.34:1] INFO DbPersistenceService : optimistic locking failed 12:09:42,687 [JbpmJobExector:192.168.125.34:1] DEBUG DbPersistenceService : rolling back hibernate transaction 12:09:42,687 [JbpmJobExector:192.168.125.34:1] DEBUG DbPersistenceService : closing hibernate session 2) Services.close() logs the JbpmPersistenceException but does not rethrow it. 12:09:42,687 [JbpmJobExector:192.168.125.34:1] INFO Services : problem closing service 'persistence': optimistic locking failed 3) The exception does not reach the JobExecutorThread, which proceeds as if nothing had happened. 12:09:42,687 [JbpmJobExector:192.168.125.34:1] DEBUG JobExecutorThread : obtained locks on following jobs: [job[444795]] As I see it, Services.close() has to rethrow the JbpmPersistenceException, even if the cause is a StaleObjectStateException. Currently it suppresses *any* JbpmPersistenceException! In turn, JobExecutorThread has to catch JbpmPersistenceException instead of StaleStateException. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira